blender
/
blender
134
399
Fork 581
Code Issues 6.3k Pull Requests 758 Projects 19 Wiki Activity

Nested Bone Collections 4.1 Notes #116795

New Issue
Open
opened 2024-01-04 17:59:45 +01:00 by Demeter Dzadik · 6 comments
Demeter Dzadik commented 2024-01-04 17:59:45 +01:00
Member
Copy Link

I've been testing the new Nested Bone Collections system and giving lots of small points of feedback, so Sybren asked me to create a task so they don't get lost. Only adding points that have been previously discussed and agreed upon (or at least not disagreed with) in chat or IRL.

UI module:

  • UX: Clicking on a collection shouldn't un-collapse it. (#117402)

Anim Module:

  • UX: Adding a new collection should add a sibling after the active item, rather than root entry at bottom of list.
  • UX: Removing active item should take hierarchy into account and go to the item that is visually above the removed one. (Imo this would be best implemented such that the operator asks the UI what element should become active, since the UI knows which element is being drawn above the current one. Will then also work when filtering is added.)
  • UX: Should be possible to un-solo a collection, without un-hiding collections that were always hidden to begin with. (#117414)
  • UI: Use empty circle icon to indicate when a selected bone is assigned to a child of a collection.
  • Bug: Show All and Solo Visibility operators don't currently work
  • PyAPI Bug: coll.move() doesn't update collections.active_index, so it can fall out of sync with UI and collections.active.index
  • PyAPI: Expose "unfold children" property of collections to Python (#116940)
  • PyAPI: Add a .parent accessor
  • PyAPI: Allow .parent to be writable too instead of coll.move_to_parent(some_coll). Shoutout to Sergey for the help! :)
  • PyAPI: Add a .index accessor
  • PyAPI: Add a .bones_recursive accessor
  • Suggested Hotkeys:
    • F2: Rename
    • X: Delete
    • Shift+A: Add
    • Ctrl+F: Search (once it's there) like a just-start-typing kinda thing
    • Up/Down Arrow Keys: Changing active element
    • Left/Right Arrow Keys: (Un)collapse
    • Enter: Toggle visibility
    • Ctrl+Enter: Solo
  • 'Remove Empty Collections' operator, that removes all bone collections that have no bones and no child collections either.
I've been testing the new [Nested Bone Collections system](https://projects.blender.org/blender/blender/issues/108941) and giving lots of small points of feedback, so Sybren asked me to create a task so they don't get lost. Only adding points that have been previously discussed and agreed upon (or at least not disagreed with) in chat or IRL. UI module: - [ ] UX: Clicking on a collection shouldn't un-collapse it. (#117402) Anim Module: - [x] UX: Adding a new collection should add a sibling after the active item, rather than root entry at bottom of list. - [ ] UX: Removing active item should take hierarchy into account and go to the item that is visually above the removed one. (Imo this would be best implemented such that the operator asks the UI what element should become active, since the UI knows which element is being drawn above the current one. Will then also work when filtering is added.) - [ ] UX: Should be possible to un-solo a collection, without un-hiding collections that were always hidden to begin with. (#117414) - [x] UI: [Use empty circle icon to indicate when a selected bone is assigned to a child of a collection.](/attachments/bd4d44d5-56e3-4d66-9945-cba330d28bad) - [x] Bug: Show All and Solo Visibility operators don't currently work - [x] PyAPI Bug: `coll.move()` doesn't update `collections.active_index`, so it can fall out of sync with UI and `collections.active.index` - [ ] PyAPI: Expose "unfold children" property of collections to Python (#116940) - [x] PyAPI: [Add a `.parent` accessor](https://projects.blender.org/blender/blender/commit/9f38c6e887c38b2999c5a6c74e233e8df2ae906b) - [x] PyAPI: [Allow `.parent` to be writable too](https://projects.blender.org/blender/blender/commit/29be81ec238) instead of `coll.move_to_parent(some_coll)`. Shoutout to Sergey for the help! :) - [x] PyAPI: [Add a `.index` accessor](https://projects.blender.org/blender/blender/commit/cd8f1853ed558bb73beac38be285997641e7877a) - [x] PyAPI: [Add a .bones_recursive accessor](https://projects.blender.org/blender/blender/commit/65d25ed8136594df71b5876eb5523958aa37c0fb) - [ ] Suggested Hotkeys: - F2: Rename - X: Delete - Shift+A: Add - Ctrl+F: Search (once it's there) like a just-start-typing kinda thing - Up/Down Arrow Keys: Changing active element - Left/Right Arrow Keys: (Un)collapse - Enter: Toggle visibility - Ctrl+Enter: Solo - [x] 'Remove Empty Collections' operator, that removes all bone collections that have no bones and no child collections either.
image.png
5.9 KiB
image.png
5.0 KiB
image.png
Demeter Dzadik added the
Type
To Do
 label 2024-01-04 17:59:45 +01:00
Iliya Katushenock added this to the Animation & Rigging project 2024-01-04 22:52:10 +01:00
Nika Kutsniashvili commented 2024-01-13 18:37:10 +01:00
Contributor
Copy Link

UX-wise one thing I don't like is that I preferred dot icons on the left of the name, its way easier to see for many reasons, and on the right being next ro eye icon it makes it look like you can click it and expect some result too.

Also, icons on left was more inlined with Outliner, where icon on the left indicates which objects you have in active edit mode.

UX-wise one thing I don't like is that I preferred dot icons on the left of the name, its way easier to see for many reasons, and on the right being next ro eye icon it makes it look like you can click it and expect some result too. Also, icons on left was more inlined with Outliner, where icon on the left indicates which objects you have in active edit mode.
Sybren A. Stüvel commented 2024-01-22 11:43:40 +01:00
Member
Copy Link

When you move the dots to the left, this is what you'd get:

image

I'm not a fan; having the text closer to the triangle makes the hierarchy visually clearer to me. Note that this is not yet with #116200 applied, so maybe once that lands we should revisit this.

on the right being next ro eye icon it makes it look like you can click it and expect some result too.

This is what I wouldn't mind having, actually. Assign/unassign by clicking that icon.

When you move the dots to the left, this is what you'd get: ![image](/attachments/f6b018ec-114f-40a7-9af9-6a5629769627) I'm not a fan; having the text closer to the triangle makes the hierarchy visually clearer to me. Note that this is not yet with #116200 applied, so maybe once that lands we should revisit this. > on the right being next ro eye icon it makes it look like you can click it and expect some result too. This is what I wouldn't mind having, actually. Assign/unassign by clicking that icon.
image.png
65 KiB
Sybren A. Stüvel commented 2024-01-22 13:44:43 +01:00
Member
Copy Link

UX: Ctrl+Clicking an eye icon should Solo a collection, and Ctrl+Clicking it again should restore visibilities to their pre-solo states. (Can discuss most ideal behaviour in more detail; Look to 3D View's Local View for inspiration!)

I'm assuming you're referring to the 3D View local collections:

image

These work in a weird way, at least on my computer:

  • Ctrl+click on the eye doesn't do anything. Ctrl+click on the label does the solo'ing. This to me feels quite counter-intuitive.
  • Dragging on the eyes doesn't do anything either, so toggling every eye is no more a matter of pressing the LMB and dragging, but users are forced to do this one-by-one.

I don't know if this is such a good example for inspiration.

> UX: Ctrl+Clicking an eye icon should Solo a collection, and Ctrl+Clicking it again should restore visibilities to their pre-solo states. (Can discuss most ideal behaviour in more detail; Look to 3D View's Local View for inspiration!) I'm assuming you're referring to the 3D View local collections: ![image](/attachments/8e1b9599-3876-4530-bd6f-d1f22c19f6b0) These work in a weird way, at least on my computer: - Ctrl+click on the eye doesn't do anything. Ctrl+click on the label does the solo'ing. This to me feels quite counter-intuitive. - Dragging on the eyes doesn't do anything either, so toggling every eye is no more a matter of pressing the LMB and dragging, but users are forced to do this one-by-one. I don't know if this is such a good example for inspiration.
image.png
32 KiB
Demeter Dzadik commented 2024-01-22 14:12:17 +01:00
Author
Member
Copy Link

I also prefer the dots on the right side but I can't really justify it beyond "I like how it looks", so if someone has a strong argument for changing it then I won't complain.
I love the spelling "Boan", I should use that.

I'm assuming you're referring to the 3D View local collections

No, sorry, I totally forgot this UI element existed, that's why I wasn't specific enough, but I meant collections in the Outliner; There, you should be able to do the Ctrl+clicking on eye icon to solo behaviour that I described.

I also prefer the dots on the right side but I can't really justify it beyond "I like how it looks", so if someone has a strong argument for changing it then I won't complain. I love the spelling "Boan", I should use that. -------------------------------- > I'm assuming you're referring to the 3D View local collections No, sorry, I totally forgot this UI element existed, that's why I wasn't specific enough, but I meant collections in the Outliner; There, you should be able to do the Ctrl+clicking on eye icon to solo behaviour that I described. <video src="/attachments/3dabcafd-a7ba-4b20-b0a4-c618a0de1560" title="outliner_collection_solo.mp4" controls></video>
outliner_collection_solo.mp4
304 KiB
Demeter Dzadik commented 2024-01-22 14:33:36 +01:00
Author
Member
Copy Link

And to elaborate on this:

Can discuss most ideal behaviour in more detail; Look to 3D View's Local View for inspiration!

What I mean is that when un-soloing an object collection, as you can see near the end of the above video, it just unhides all collections, even if they were hidden before anything got solo'd.

Contrast that with what I implemented in CloudRig:

Which you can also test and see the code of in this .blend:
cloudrig_collection_solo.blend

It just doesn't un-hide collections which were already hidden before soloing a collection. So un-soloing more or less returns you to the state that you started out from.
Why I think that's vital:

  • In the old box layer system, soloing a layer was as simple as clicking on it. Although admittedly, there was no "un-solo" option at all! :'D
  • Most rigs will have mechanism/deform bones on hidden collections.
  • As an animator, let's say you want to solo the Fingers collection.
  • When you un-solo, you don't want to reveal the mechanism/deform collections that were hidden in the first place. It would cover your screen in bones! You only want to reveal collections that got hidden by the Solo action.
And to elaborate on this: > Can discuss most ideal behaviour in more detail; Look to 3D View's Local View for inspiration! What I mean is that when un-soloing an object collection, as you can see near the end of the above video, it just unhides all collections, even if they were hidden before anything got solo'd. Contrast that with what I implemented in CloudRig: <video src="/attachments/e287fe97-580c-4913-a692-238fa77fcb92" title="cloudrig_collection_solo.mp4" controls></video> Which you can also test and see the code of in this .blend: [cloudrig_collection_solo.blend](/attachments/f1c14b4b-05d9-4799-b87a-e846983ccdd6) It just doesn't un-hide collections which were already hidden before soloing a collection. So un-soloing more or less returns you to the state that you started out from. **Why I think that's vital**: - In the old box layer system, soloing a layer was as simple as clicking on it. Although admittedly, there was no "un-solo" option at all! :'D - Most rigs will have mechanism/deform bones on hidden collections. - As an animator, let's say you want to solo the Fingers collection. - When you un-solo, you don't want to reveal the mechanism/deform collections that were hidden in the first place. It would cover your screen in bones! You only want to reveal collections that got hidden by the Solo action.
cloudrig_collection_solo.blend
1.7 MiB
cloudrig_collection_solo.mp4
676 KiB
Sybren A. Stüvel commented 2024-01-22 16:58:25 +01:00
Member
Copy Link

PR in #117414 :)

PR in #117414 :)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
brush-assets-project
blender-v3.3-release
partial-write-refactor
universal-scene-description
fix-121021
blender-v4.1-release
blender-v3.6-release
blender-v3.6-temp_wmoss_animrig_public
temp-sculpt-dyntopo
gpencil-next
anim/animation-id-113594
blender-v4.0-release
blender-projects-basics
bridge-curves
sculpt-blender
asset-browser-frontend-split
asset-shelf
tmp-usd-python-mtl
tmp-usd-3.6
blender-v3.5-release
blender-v2.93-release
realtime-clock
sculpt-dev
bevelv2
xr-dev
v4.1.1
v3.6.11
v3.3.18
v4.1.0
v3.3.17
v3.6.10
v3.6.9
v3.3.16
v3.6.8
v3.6.7
v3.3.14
v4.0.2
v4.0.1
v4.0.0
v3.6.5
v3.3.12
v3.6.4
v3.6.3
v3.3.11
v3.6.2
v3.3.10
v3.6.1
v3.3.9
v3.6.0
v3.3.8
v3.3.7
v2.93.18
v3.5.1
v3.3.6
v2.93.17
v3.5.0
v2.93.16
v3.3.5
v3.3.4
v2.93.15
v2.93.14
v3.3.3
v2.93.13
v2.93.12
v3.4.1
v3.3.2
v3.4.0
v3.3.1
v2.93.11
v3.3.0
v3.2.2
v2.93.10
v3.2.1
v3.2.0
v2.83.20
v2.93.9
v3.1.2
v3.1.1
v3.1.0
v2.83.19
v2.93.8
v3.0.1
v2.93.7
v3.0.0
v2.93.6
v2.93.5
v2.83.18
v2.93.4
v2.93.3
v2.83.17
v2.93.2
v2.93.1
v2.83.16
v2.93.0
v2.83.15
v2.83.14
v2.83.13
v2.92.0
v2.83.12
v2.91.2
v2.83.10
v2.91.0
v2.83.9
v2.83.8
v2.83.7
v2.90.1
v2.83.6.1
v2.83.6
v2.90.0
v2.83.5
v2.83.4
v2.83.3
v2.83.2
v2.83.1
v2.83
v2.82a
v2.82
v2.81a
v2.81
v2.80
v2.80-rc3
v2.80-rc2
v2.80-rc1
v2.79b
v2.79a
v2.79
v2.79-rc2
v2.79-rc1
v2.78c
v2.78b
v2.78a
v2.78
v2.78-rc2
v2.78-rc1
v2.77a
v2.77
v2.77-rc2
v2.77-rc1
v2.76b
v2.76a
v2.76
v2.76-rc3
v2.76-rc2
v2.76-rc1
v2.75a
v2.75
v2.75-rc2
v2.75-rc1
v2.74
v2.74-rc4
v2.74-rc3
v2.74-rc2
v2.74-rc1
v2.73a
v2.73
v2.73-rc1
v2.72b
2.72b
v2.72a
v2.72
v2.72-rc1
v2.71
v2.71-rc2
v2.71-rc1
v2.70a
v2.70
v2.70-rc2
v2.70-rc
v2.69
v2.68a
v2.68
v2.67b
v2.67a
v2.67
v2.66a
v2.66
v2.65a
v2.65
v2.64a
v2.64
v2.63a
v2.63
v2.61
v2.60a
v2.60
v2.59
v2.58a
v2.58
v2.57b
v2.57a
v2.57
v2.56a
v2.56
v2.55
v2.54
v2.53
v2.52
v2.51
v2.50
v2.49b
v2.49a
v2.49
v2.48a
v2.48
v2.47
v2.46
v2.45
v2.44
v2.43
v2.42a
v2.42
v2.41
v2.40
v2.37a
v2.37
v2.36
v2.35a
v2.35
v2.34
v2.33a
v2.33
v2.32
v2.31a
v2.31
v2.30
v2.28c
v2.28a
v2.28
v2.27
v2.26
v2.25
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Animation & Rigging
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#116795
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?