Undo (Ctrl+z) doesn't work properly on shading and timeline #117092

New Issue

Open

opened 2024-01-13 16:24:47 +01:00 by Felipe · 9 comments

Felipe commented

2024-01-13 16:24:47 +01:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 527.37

Blender Version
Broken: version: 4.0.2, branch: blender-v4.0-release, commit date: 2023-12-05 07:41, hash: 9be62e85b727
Worked: (newest version of Blender that worked as expected)

Short description of error
It's simple, I do a minor change on the shading or timeline, I want go back and it doesn't work. I then press a bunch of times and I lose a like 10 changes I did on the project. Was it supposed to be like this?

Exact steps for others to reproduce the error
Go into shading mode, change color or any value, then try to undo it (doesn't work here)
Go into pose mode, select all bones, go into time line, if you make a single change on the keyframes, you need 2~3 ctrlz to undo it, if you do two changes, you need 7~8 and it won't be in steps, the two changes will be undone, not just one.

Also, I've teste with just a cube, both shading and posing works perfectly. * confused *

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 527.37 **Blender Version** Broken: version: 4.0.2, branch: blender-v4.0-release, commit date: 2023-12-05 07:41, hash: `9be62e85b727` Worked: (newest version of Blender that worked as expected) **Short description of error** It's simple, I do a minor change on the shading or timeline, I want go back and it doesn't work. I then press a bunch of times and I lose a like 10 changes I did on the project. Was it supposed to be like this? **Exact steps for others to reproduce the error** Go into shading mode, change color or any value, then try to undo it (doesn't work here) Go into pose mode, select all bones, go into time line, if you make a single change on the keyframes, you need 2~3 ctrlz to undo it, if you do two changes, you need 7~8 and it won't be in steps, the two changes will be undone, not just one. Also, I've teste with just a cube, both shading and posing works perfectly. * confused *

pomni bug.blend

20 MiB

Felipe added the

labels 2024-01-13 16:24:48 +01:00

Iliya Katushenock added the

label 2024-01-13 16:41:31 +01:00

Pratik Borhade commented

2024-01-15 12:31:50 +01:00

Member

Thanks for the report. Can confirm actually. Somehow changes done in UI is writing to paintcurve_undosystem

Thanks for the report. Can confirm actually. Somehow changes done in UI is writing to `paintcurve_undosystem`

Pratik Borhade commented

2024-01-15 13:01:37 +01:00

Member

Possibly the file was somehow corrupted? UI changes in pose mode should be written to memfile instead of paintcurve_undosys
Did you have any add-on that allowed you to paint/draw in different modes?

Possibly the file was somehow corrupted? UI changes in pose mode should be written to memfile instead of paintcurve_undosys Did you have any add-on that allowed you to paint/draw in different modes?

Pratik Borhade added

Needs Information from User

and removed

labels 2024-01-15 13:02:40 +01:00

Felipe commented

2024-01-15 18:33:05 +01:00

Author

Thank you guys for replying

I don't have any addons.

I'm thinking of one thing I can do that might help you guys. I have like v1, v2, v3 all the way to this final, I can try to see where it starts to happen.

Would that help?

Thank you guys for replying I don't have any addons. I'm thinking of one thing I can do that might help you guys. I have like v1, v2, v3 all the way to this final, I can try to see where it starts to happen. Would that help?

Pratik Borhade commented

2024-01-16 10:49:11 +01:00

Member

That might help, yes. I further deleted everything and replaced with single bone but paintcurve_undosys still writes the undo step for UI changes.

That might help, yes. I further deleted everything and replaced with single bone but `paintcurve_undosys` still writes the undo step for UI changes.

pomni bug-2.blend

3.2 MiB

Pratik Borhade commented

2024-02-14 10:04:39 +01:00

Member

Hi, any updates?

Hi, any updates?

Pratik Borhade commented

2024-03-01 05:30:25 +01:00

Member

Not sure how file end up in such situation, I don't think this is a bug. @mont29 hi, can you check?

Not sure how file end up in such situation, I don't think this is a bug. @mont29 hi, can you check?

Bastien Montagne added the

Sculpt, Paint & Texture

label 2024-03-01 11:39:58 +01:00

Bastien Montagne commented

2024-03-01 11:46:26 +01:00

Owner

I think this is a problem for the Sculpt & Paint module.

From quick analysis, the issue lies in the poll code of this module. Specifically:

BKE_undosys_type_from_context loops over all known undo types and call their poll function with current context.
paintcurve_undosys_poll calls paint_curve_poll
paint_curve_poll gets no valid RegionView3D nor SpaceImage pointers from the context.
a. But it does get a valid Paint pointer from BKE_paint_get_active_from_context, and the brush there is a BRUSH_CURVE one, so it returns true.

This whole logic sounds flawed, or at least fragile/incomplete to me, and obviously here does not produce the expected result (paintcurve_undosys_poll should never return true when the active object is in Object or Pose mode!).

I think this is a problem for the Sculpt & Paint module. From quick analysis, the issue lies in the `poll` code of this module. Specifically: 1. `BKE_undosys_type_from_context` loops over all known undo types and call their `poll` function with current context. 2. `paintcurve_undosys_poll` calls `paint_curve_poll` 3. `paint_curve_poll` gets no valid `RegionView3D` nor `SpaceImage` pointers from the context. a. But it does get a valid `Paint` pointer from `BKE_paint_get_active_from_context`, and the brush there is a `BRUSH_CURVE` one, so it returns true. This whole logic sounds flawed, or at least fragile/incomplete to me, and obviously here does not produce the expected result (`paintcurve_undosys_poll` should never return `true` when the active object is in Object or Pose mode!).

Bastien Montagne added

and removed

Needs Information from User

labels 2024-03-01 11:46:46 +01:00

Felipe commented

2024-03-01 18:41:18 +01:00

Author

Hey, can you believe I never had this issue anymore?

I really don't know what happened, I'm bad at 3D but I wasn't expecting to break blender.

I'm thinking about closing the thread here, since it's "solved".

Should I? Would I intefere in your investigation doing this?

Regards

Hey, can you believe I never had this issue anymore? I really don't know what happened, I'm bad at 3D but I wasn't expecting to break blender. I'm thinking about closing the thread here, since it's "solved". Should I? Would I intefere in your investigation doing this? Regards

Bastien Montagne commented

2024-03-01 20:42:16 +01:00

Owner

@al777 there is a problem, but I think it only shows up if your last used brush is a curve one, which I guess does not happen often...

@al777 there is a problem, but I think it only shows up if your last used brush is a curve one, which I guess does not happen often...

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#117092

No description provided.