Regression: Crash when Using IME in the Fields Existing more than 24 Bytes Text #117632

New Issue

Ruri-Res · 2024-01-29T15:23:45+01:00

Ruri-Res commented

2024-01-29 15:23:45 +01:00

System Information
Operating system: Windows 10
Graphics card:

Blender Version
Broken: 4.1.0 Alpha, branch: main, commit date: 2024-01-23 00:20, hash:b5a9c98e04fa
Worked: 4.1.0 Alpha, branch: main, commit date: 2024-01-22 11:27, hash:29aaa2922d1d

Short description of error
When there are more than 24 bytes text in a text input field, blender will crash after "IME composition" (it may give an UI redraw?) in it.
Test with IME: "Rime Weasel", "微软拼音"(Microsoft Pinyin)

Exact steps for others to reproduce the error

**System Information** Operating system: Windows 10 Graphics card: **Blender Version** Broken: 4.1.0 Alpha, branch: main, commit date: 2024-01-23 00:20, hash:b5a9c98e04fa Worked: 4.1.0 Alpha, branch: main, commit date: 2024-01-22 11:27, hash:29aaa2922d1d **Short description of error** When there are more than 24 bytes text in a text input field, blender will crash after "IME composition" (it may give an UI redraw?) in it. Test with IME: "Rime Weasel", "微软拼音"(Microsoft Pinyin) **Exact steps for others to reproduce the error** ![MoreThan24Bytes.png](/attachments/091ed49a-e362-4258-b15a-9d9602832102)

MoreThan24Bytes.png

54 KiB

Ruri-Res added the

labels 2024-01-29 15:23:45 +01:00

Pratik Borhade commented

2024-01-30 10:27:47 +01:00

Hi, can confirm the crash in release build. Debug lite/ninja builds are not crashing here.

Stack trace:
blender.exe         :0x00007FF6CE5B0F70  ui_but_update_ex
blender.exe         :0x00007FF6CE5DBA80  ui_do_but_textedit
blender.exe         :0x00007FF6CE5DB240  ui_do_but_TEX
blender.exe         :0x00007FF6CE5DC730  ui_do_button
blender.exe         :0x00007FF6CE5DE000  ui_handle_button_event
blender.exe         :0x00007FF6CE5E0690  ui_handler_region_menu
blender.exe         :0x00007FF6CE0242C0  wm_handlers_do_intern
blender.exe         :0x00007FF6CE0234B0  wm_handlers_do
blender.exe         :0x00007FF6CE01FDC0  wm_event_do_handlers
blender.exe         :0x00007FF6CE004640  WM_main
blender.exe         :0x00007FF6CDA08480  main
blender.exe         :0x00007FF6D0312CA4  __scrt_common_main_seh
KERNEL32.DLL        :0x00007FFF552F2560  BaseThreadInitThunk
ntdll.dll           :0x00007FFF566CAA30  RtlUserThreadStart

Hi, can confirm the crash in release build. Debug lite/ninja builds are not crashing here. ``` Stack trace: blender.exe :0x00007FF6CE5B0F70 ui_but_update_ex blender.exe :0x00007FF6CE5DBA80 ui_do_but_textedit blender.exe :0x00007FF6CE5DB240 ui_do_but_TEX blender.exe :0x00007FF6CE5DC730 ui_do_button blender.exe :0x00007FF6CE5DE000 ui_handle_button_event blender.exe :0x00007FF6CE5E0690 ui_handler_region_menu blender.exe :0x00007FF6CE0242C0 wm_handlers_do_intern blender.exe :0x00007FF6CE0234B0 wm_handlers_do blender.exe :0x00007FF6CE01FDC0 wm_event_do_handlers blender.exe :0x00007FF6CE004640 WM_main blender.exe :0x00007FF6CDA08480 main blender.exe :0x00007FF6D0312CA4 __scrt_common_main_seh KERNEL32.DLL :0x00007FFF552F2560 BaseThreadInitThunk ntdll.dll :0x00007FFF566CAA30 RtlUserThreadStart ```

Pratik Borhade added

and removed

labels 2024-01-30 10:28:00 +01:00

Hans Goudey self-assigned this 2024-01-31 05:28:12 +01:00

Hans Goudey commented

2024-01-31 19:35:53 +01:00

Actually without a Windows build myself, not sure I can solve this without the ability to reproduce it. Maybe someone with a debug build could give a more specific stack trace with line numbers?

Pratik Borhade commented

2024-02-02 06:32:02 +01:00

Manage to replicate in debug build (with_input_ime was off earlier). Attaching full logs:

 	blender.exe!std::_Narrow_char_traits<char,int>::assign(char & _Left, const char & _Right) Line 444	C++
 	blender.exe!std::string::_Eos(const unsigned __int64 _New_size) Line 4824	C++
 	blender.exe!std::string::clear() Line 3672	C++
>	blender.exe!ui_but_update_ex(uiBut * but, const bool validate) Line 3920	C++
 	blender.exe!ui_but_update_edited(uiBut * but) Line 3930	C++
 	blender.exe!ui_do_but_textedit(bContext * C, uiBlock * block, uiBut * but, uiHandleButtonData * data, const wmEvent * event) Line 4065	C++
 	blender.exe!ui_do_but_TEX(bContext * C, uiBlock * block, uiBut * but, uiHandleButtonData * data, const wmEvent * event) Line 4782	C++
 	blender.exe!ui_do_button(bContext * C, uiBlock * block, uiBut * but, const wmEvent * event) Line 8206	C++
 	blender.exe!ui_handle_button_event(bContext * C, const wmEvent * event, uiBut * but) Line 9506	C++
 	blender.exe!ui_handler_region_menu(bContext * C, const wmEvent * event, void * __formal) Line 11666	C++
 	blender.exe!wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, const bool always_pass) Line 833	C++
 	blender.exe!wm_handlers_do_intern(bContext * C, wmWindow * win, wmEvent * event, ListBase * handlers) Line 3331	C++
 	blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 3450	C++
 	blender.exe!wm_event_do_handlers(bContext * C) Line 4077	C++
 	blender.exe!WM_main(bContext * C) Line 616	C++
 	blender.exe!main(int argc, const char * * __formal) Line 578	C++

Manage to replicate in debug build (`with_input_ime` was off earlier). Attaching full logs: ``` blender.exe!std::_Narrow_char_traits<char,int>::assign(char & _Left, const char & _Right) Line 444 C++ blender.exe!std::string::_Eos(const unsigned __int64 _New_size) Line 4824 C++ blender.exe!std::string::clear() Line 3672 C++ > blender.exe!ui_but_update_ex(uiBut * but, const bool validate) Line 3920 C++ blender.exe!ui_but_update_edited(uiBut * but) Line 3930 C++ blender.exe!ui_do_but_textedit(bContext * C, uiBlock * block, uiBut * but, uiHandleButtonData * data, const wmEvent * event) Line 4065 C++ blender.exe!ui_do_but_TEX(bContext * C, uiBlock * block, uiBut * but, uiHandleButtonData * data, const wmEvent * event) Line 4782 C++ blender.exe!ui_do_button(bContext * C, uiBlock * block, uiBut * but, const wmEvent * event) Line 8206 C++ blender.exe!ui_handle_button_event(bContext * C, const wmEvent * event, uiBut * but) Line 9506 C++ blender.exe!ui_handler_region_menu(bContext * C, const wmEvent * event, void * __formal) Line 11666 C++ blender.exe!wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, const bool always_pass) Line 833 C++ blender.exe!wm_handlers_do_intern(bContext * C, wmWindow * win, wmEvent * event, ListBase * handlers) Line 3331 C++ blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 3450 C++ blender.exe!wm_event_do_handlers(bContext * C) Line 4077 C++ blender.exe!WM_main(bContext * C) Line 616 C++ blender.exe!main(int argc, const char * * __formal) Line 578 C++ ```

Pratik Borhade commented

2024-02-02 07:43:46 +01:00

Did git bisect, caused by 089c389b5c

Did git bisect, caused by 089c389b5c00ec2794299a18fd5b05dd7c4c54cc

Pratik Borhade changed title from ~~Crash when Using IME in the Fields Existing more than 24 Bytes Text~~ to Regression: Crash when Using IME in the Fields Existing more than 24 Bytes Text

2024-02-02 07:49:40 +01:00

Hans Goudey referenced a pull request that will close this issue

2024-02-08 01:53:56 +01:00

Fix #117632: IME input crash after refactor to use std::string #117968

Hans Goudey referenced this issue from a commit

2024-02-08 05:52:28 +01:00

Fix #117632: IME input crash after refactor to use std::string

Hans Goudey closed this issue

2024-02-08 05:52:31 +01:00

Blender Bot added

Status

Resolved