Bake Node unnecessary calculations #118012

Open
opened 2024-02-08 19:51:12 +01:00 by Marco · 8 comments
Member

Blender Version
Broken: 4.1 Beta (hash: 4a50f1d4ee9a)

Short description of error
When using the same setup with a Bake Node in between, it looks like both input geometries are calculated instead of just the chosen one with the Switch Node, and I can tell it because "Real" takes roughly 300ms while "Optimized" takes around 200ms, the Output Node shows the sum of them when using a Bake Node in between.

Exact steps for others to reproduce the error
Cannot provide test file due to license

**Blender Version** Broken: 4.1 Beta (hash: `4a50f1d4ee9a`) **Short description of error** When using the same setup with a Bake Node in between, it looks like both input geometries are calculated instead of just the chosen one with the Switch Node, and I can tell it because "Real" takes roughly 300ms while "Optimized" takes around 200ms, the Output Node shows the sum of them when using a Bake Node in between. <video src="/attachments/1145fdf6-b294-4a9c-a564-469d5537d366" title="Screencast.webm" controls></video> **Exact steps for others to reproduce the error** Cannot provide test file due to license
Marco added the
Priority
Normal
Type
Report
Status
Needs Triage
labels 2024-02-08 19:51:13 +01:00

Even if some outputs is unused now, all inputs of Bake have to be computed so you will be able to change output links of node without re-bake them.
So, this is expected behavior.

Even if some outputs is unused now, all inputs of `Bake` have to be computed so you will be able to change output links of node without re-bake them. So, this is expected behavior.
Blender Bot added
Status
Archived
and removed
Status
Needs Triage
labels 2024-02-08 20:03:03 +01:00
Iliya Katushenock added the
Interest
Geometry Nodes
Interest
Nodes & Physics
labels 2024-02-08 20:03:09 +01:00
Author
Member

This is expected behaviour if the node already has baked data, but here I'm talking about it not having any baked data.

This is expected behaviour if the node already has baked data, but here I'm talking about it not having any baked data.
Marco reopened this issue 2024-02-08 21:05:40 +01:00
Blender Bot added
Status
Needs Triage
and removed
Status
Archived
labels 2024-02-08 21:05:42 +01:00
@JacquesLucke /
Member

Hi, thanks for the report. I'm not able to confirm this in local file. Could you create one sample file where the problem is more visible?
Maybe I'm missing something, So uploaded the file which I used

Hi, thanks for the report. I'm not able to confirm this in local file. Could you create one sample file where the problem is more visible? Maybe I'm missing something, So uploaded the file which I used
Pratik Borhade added
Status
Needs Information from User
and removed
Status
Needs Triage
labels 2024-02-09 07:39:04 +01:00

I can confirm, LazyFunctionForBakeNode::get_bake_state_from_inputs calculates all inputs in all cases (baking all frames, single frame, or just pass inputs to outputs). This can be improved, but this is not a bug.

Maybe I'm missing something, So uploaded the file which I used

Both inputs of Bake node have to be different nodes with complicated results. Then, even if only one result of Bake node is used, both input nodes will be computed.

I can confirm, `LazyFunctionForBakeNode::get_bake_state_from_inputs` calculates all inputs in all cases (baking all frames, single frame, or just pass inputs to outputs). This can be improved, but this is not a bug. > Maybe I'm missing something, So uploaded the file which I used Both inputs of `Bake` node have to be different nodes with complicated results. Then, even if only one result of `Bake` node is used, both input nodes will be computed.
Iliya Katushenock added
Status
Needs Triage
and removed
Status
Needs Information from User
labels 2024-02-09 09:09:15 +01:00
Member

Both inputs of Bake node have to be different nodes with complicated results

Oh, ok. I thought "subdivide" operation would be sufficient to get > 300ms calculation time :)
Can you upload test file anyways, @mod_moder

> Both inputs of Bake node have to be different nodes with complicated results Oh, ok. I thought "subdivide" operation would be sufficient to get > 300ms calculation time :) Can you upload test file anyways, @mod_moder

Sure @PratikPB2123 , here is this:

Sure @PratikPB2123 , here is this:
Member

This is something that can be improved, but for now this is a known limitation and not a bug.

The main reason why this is not entirely straight forward is that the bake node does a bit more than just pass-through even when it is not baked. Specifically, it removes anonymous attributes that won't be baked.

This is something that can be improved, but for now this is a known limitation and not a bug. The main reason why this is not entirely straight forward is that the bake node does a bit more than just pass-through even when it is not baked. Specifically, it removes anonymous attributes that won't be baked.
Jacques Lucke added
Type
Known Issue
and removed
Type
Report
labels 2024-02-12 12:41:20 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#118012
No description provided.