Image datablock filepath change doesn't update when compositor is set to GPU execution mode. Works in tiles and full frame. #118117

New Issue

Closed

opened 2024-02-12 03:06:33 +01:00 by michael campbell · 6 comments

michael campbell commented

2024-02-12 03:06:33 +01:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 537.58

Blender Version
Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-02-09 16:43, hash: 7e13522a4fd0
Worked: (unknown)

Short description of error
Image datablock filepath change doesn't update when compositor is set to GPU execution mode. Works in tiles and full frame.

Exact steps for others to reproduce the error

unzip attached and open blend file from unzipped location (don't move blend file out of folder). Ensure load UI is enabled.
Make sure there are no other addons installed that use the frame_change_post handler.
In the script editor click the run script icon.
In all 3 compositor modes (tiled, full frame, GPU) try: playback, changing the frame with the arrow keys, and moving the timeline with the mouse.
In full frame and tiled mode the compositor backdrop will change to show the new image datablocks updated filepath. In GPU mode it won't update.

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 537.58 **Blender Version** Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-02-09 16:43, hash: `7e13522a4fd0` Worked: (unknown) **Short description of error** Image datablock filepath change doesn't update when compositor is set to GPU execution mode. Works in tiles and full frame. **Exact steps for others to reproduce the error** 1. unzip attached and open blend file from unzipped location (don't move blend file out of folder). Ensure load UI is enabled. 2. Make sure there are no other addons installed that use the frame_change_post handler. 3. In the script editor click the run script icon. 4. In all 3 compositor modes (tiled, full frame, GPU) try: playback, changing the frame with the arrow keys, and moving the timeline with the mouse. 5. In full frame and tiled mode the compositor backdrop will change to show the new image datablocks updated filepath. In GPU mode it won't update.

images dont update in gpu mode frame change.zip

1.0 MiB

michael campbell added the

labels 2024-02-12 03:06:34 +01:00

Pratik Borhade commented

2024-02-12 06:55:31 +01:00

Member

Thanks for the report. Can confirm.
cc @OmarEmaraDev @zazizizou

Thanks for the report. Can confirm. cc @OmarEmaraDev @zazizizou

Pratik Borhade added

and removed

labels 2024-02-12 06:55:48 +01:00

Omar Emara self-assigned this 2024-02-12 14:58:13 +01:00

~~Omar Emara referenced this issue 2024-02-13 08:36:06 +01:00~~

Fix: Image does not update when file path changes #118187

Omar Emara commented

2024-02-13 13:29:06 +01:00

Member

@Sergey I couldn't immediately figure it out, but here are my findings. First, download the above file but replace the blend file with this one: missingReclacFlags.blend

In v4.1, with #118187 applied.
Change to viewport rendered mode to activate the viewport compositor.
Execute the script.
Scrub the timeline and notice that the image in the image editor does indeed change, but doesn't in the viewport compositor.
Change the image path manually in the UI, it works.
In the console, change the image path through python, it works.

We conclude that:

The issue seems to be that updates in the frame post handler are ignored.
The accumulated recalc flag in flush_editors_id_update is zero for the handler case, while non zero in the change through UI case.

@Sergey I couldn't immediately figure it out, but here are my findings. First, download the above file but replace the blend file with this one: [missingReclacFlags.blend](/attachments/1730f5ab-1c57-4744-b149-81eb4ac3b121) - In v4.1, with #118187 applied. - Change to viewport rendered mode to activate the viewport compositor. - Execute the script. - Scrub the timeline and notice that the image in the image editor does indeed change, but doesn't in the viewport compositor. - Change the image path manually in the UI, it works. - In the console, change the image path through python, it works. We conclude that: - The issue seems to be that updates in the frame post handler are ignored. - The accumulated recalc flag in `flush_editors_id_update` is zero for the handler case, while non zero in the change through UI case.

missingReclacFlags.blend

842 KiB

michael campbell commented

2024-02-13 13:36:26 +01:00

Author

Perhaps you could add a force compositor update python command, preferably with a 'wait till complete' option which tells blender not to continue to the next frame until the compositor completes. Currently when I want that behaviour I have to call render.render(), which I'm guessing is a very slow way of updating the compositor.

Perhaps you could add a force compositor update python command, preferably with a 'wait till complete' option which tells blender not to continue to the next frame until the compositor completes. Currently when I want that behaviour I have to call render.render(), which I'm guessing is a very slow way of updating the compositor.

Omar Emara commented

2024-02-13 13:38:26 +01:00

Member

@3di This is not really related to compositor updates, but rather, cache invalidation of cached images.

This is fixed in latest master by the way, we are just looking for a different solution for v4.1.

@3di This is not really related to compositor updates, but rather, cache invalidation of cached images. This is fixed in latest master by the way, we are just looking for a different solution for v4.1.

michael campbell commented

2024-02-13 13:43:48 +01:00

Author

I'll try the latest master now thanks.....Works great, perfect 👍

I'll try the latest master now thanks.....Works great, perfect 👍

michael campbell commented

2024-02-13 13:52:10 +01:00

Author

I do notice that the GPU mode suffers perhaps a little more with this bug #112526 too, perhaps it's also related to the cache?

I do notice that the GPU mode suffers perhaps a little more with this bug https://projects.blender.org/blender/blender/issues/112526 too, perhaps it's also related to the cache?

Sergey Sharybin referenced a pull request that will close this issue

2024-02-28 11:58:48 +01:00

Fix #118034: Cycles: Driven View Layer property not considered in realtime #118846

Sergey Sharybin referenced this issue from a commit

2024-02-28 15:56:40 +01:00

Fix #118034: Cycles: Driven View Layer property not considered in realtime

Sergey Sharybin closed this issue

2024-02-28 15:56:43 +01:00

Blender Bot added

and removed

labels 2024-02-28 15:56:45 +01:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#118117

No description provided.