blender/blender

Render region ruins compositing for image input #118156

New Issue

Closed

opened 2024-02-12 20:22:52 +01:00 by Lord Odin · 7 comments

Lord Odin commented

2024-02-12 20:22:52 +01:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 546.17

Blender Version
Broken: version: 4.0.1, branch: blender-v4.0-release, commit date: 2023-11-16 16:40, hash: d0dd92834a08

Short description of error
Doing a border render with compositing does not behave correctly in the Render Result window or when saving to disk during render animation, however it is correct when you save the render with a File Output node or look at it through the Viewer node.

Exact steps for others to reproduce the error
Add an image to the compositor with a scale node after it, do a border render of the default cube.

https://youtu.be/THAseqq04Ck

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 546.17 **Blender Version** Broken: version: 4.0.1, branch: blender-v4.0-release, commit date: 2023-11-16 16:40, hash: `d0dd92834a08` **Short description of error** Doing a border render with compositing does not behave correctly in the Render Result window or when saving to disk during render animation, however it is correct when you save the render with a File Output node or look at it through the Viewer node. **Exact steps for others to reproduce the error** Add an image to the compositor with a scale node after it, do a border render of the default cube. https://youtu.be/THAseqq04Ck

240 KiB

Lord Odin added the

labels 2024-02-12 20:22:52 +01:00

Pratik Borhade commented

2024-02-13 06:30:13 +01:00

Member

Thanks for the report. I can confirm.
cc @OmarEmaraDev

Thanks for the report. I can confirm. cc @OmarEmaraDev

Pratik Borhade added

and removed

labels 2024-02-13 06:30:27 +01:00

Pratik Borhade changed title from ~~Render border ruins compositing~~ to Render region ruins compositing for image input

2024-02-13 06:30:59 +01:00

Omar Emara commented

2024-02-13 09:21:58 +01:00

Member

This is the expected behavior as far as I can see. The compositor is part of the render pipeline, and the border option affects the entire pipeline. What do you expect to happen?

This is the expected behavior as far as I can see. The compositor is part of the render pipeline, and the border option affects the entire pipeline. What do you expect to happen?

Lord Odin commented

2024-02-13 10:21:34 +01:00

Author

If that is your argument, why isn’t it the same behavior for the viewer node or the file output node. I’m just supposed to know the result I see won’t be the one saved to disk? Why would the render result and the file output node ever be different unless directly instructed to do so?

The expected behavior would be that the render border does not crop composited elements unless specified to do so, it’s called post processing for a reason. If I’m done rendering. Why can’t I add a background to it in post? It’s a silly problem to have in the first place.

Border render provides significant speed gains for rendering and denoising. So much so that render times can be halved or even more… Which means the render budget can be halved.

By default a frame does not crop to the border size, it expands it to the full frame size. Why isn’t there an option to do compositing on the full frame? Default behavior might be the expected behavior in some very specific pipelines but it’s not expected in mine. In my 10+ years of VFX I have never exported cropped renders WITH compositing. We save that for software that can actually do the job.

An option to have both cropped and full frame compositing would make the compositor massively more useful, solve this specific issue and an absolute mountain of other issues since this functionality can effects the vse as well.

If that is your argument, why isn’t it the same behavior for the viewer node or the file output node. I’m just supposed to know the result I see won’t be the one saved to disk? Why would the render result and the file output node ever be different unless directly instructed to do so? The expected behavior would be that the render border does not crop composited elements unless specified to do so, it’s called post processing for a reason. If I’m done rendering. Why can’t I add a background to it in post? It’s a silly problem to have in the first place. Border render provides significant speed gains for rendering and denoising. So much so that render times can be halved or even more… Which means the render budget can be halved. By default a frame does not crop to the border size, it expands it to the full frame size. Why isn’t there an option to do compositing on the full frame? Default behavior might be the expected behavior in some very specific pipelines but it’s not expected in mine. In my 10+ years of VFX I have never exported cropped renders WITH compositing. We save that for software that can actually do the job. An option to have both cropped and full frame compositing would make the compositor massively more useful, solve this specific issue and an absolute mountain of other issues since this functionality can effects the vse as well.

Omar Emara commented

2024-02-13 10:28:06 +01:00

Member

I am not giving an argument in favor of that, just presenting the existing reasoning. The domain of the viewer and file output nodes are determined by their inputs, not the output, so it is expected that they produce different outputs sometimes.

In any case, I will bring this up in the module meeting and get back to you.

I am not giving an argument in favor of that, just presenting the existing reasoning. The domain of the viewer and file output nodes are determined by their inputs, not the output, so it is expected that they produce different outputs sometimes. In any case, I will bring this up in the module meeting and get back to you.

Omar Emara self-assigned this 2024-02-13 10:49:02 +01:00

Omar Emara removed their assignment 2024-02-13 13:35:28 +01:00

Omar Emara commented

2024-02-13 13:40:00 +01:00

Member

So we discussed this in the meeting, and as mentioned, it is indeed by design. However, we recognized the utility of the behavior you mentioned, and we shall look into adding an option for it with a proper design. But closing this report since it is not a bug.

So we discussed this in the meeting, and as mentioned, it is indeed by design. However, we recognized the utility of the behavior you mentioned, and we shall look into adding an option for it with a proper design. But closing this report since it is not a bug.

Omar Emara closed this issue

2024-02-13 13:40:04 +01:00

Blender Bot added

and removed

labels 2024-02-13 13:40:06 +01:00

Lord Odin commented

2024-02-13 17:36:48 +01:00

Author

So just to verify, the viewer node and file output node not being the same as the render output is not considered a bug?

So just to verify, the viewer node and file output node not being the same as the render output is not considered a bug?

Omar Emara commented

2024-02-13 17:47:45 +01:00

Member

@derekbarker Yes. Composite nodes write the area of their input that intersects the render, while viewer nodes write their input in its entirety.

This is useful because when you are viewing your images, you don't want them to be clipped by the render resolution, what you plug is what what you get.

@derekbarker Yes. Composite nodes write the area of their input that intersects the render, while viewer nodes write their input in its entirety. This is useful because when you are viewing your images, you don't want them to be clipped by the render resolution, what you plug is what what you get.

Sign in to join this conversation.

No Label

Animation & Rigging

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Asset Browser Project

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#118156

No description provided.