Shear: enter an angle instead of offset #118414

New Issue

Jorijn de Graaf · 2024-02-17T18:43:27+01:00

Jorijn de Graaf commented

2024-02-17 18:43:27 +01:00

System Information
Operating system: Windows 10
Graphics card: RTX 2070 SUPER

Blender Version
Broken: Every version
Worked: Never

Short description of error
It's not an error per se, but I find that setting the Offset value is not an intuitive way to use the Shear tool.
In other programs shear takes an angle value, which I find much more intuitive.

Exact steps for others to reproduce the error
Use the Shear tool, then try getting a specific angle by setting the Offset value.

Solution
Replace Offset with Angle, and internally convert it with this formula: offset = tan(radians(90) - angle)

Notes
Perhaps this should be a feature request on another site rather than an issue here, but I decided to open one anyway since I'm going to make a pull request here.

**System Information** Operating system: Windows 10 Graphics card: RTX 2070 SUPER **Blender Version** Broken: Every version Worked: Never **Short description of error** It's not an error per se, but I find that setting the Offset value is not an intuitive way to use the Shear tool. In other programs shear takes an angle value, which I find much more intuitive. **Exact steps for others to reproduce the error** Use the Shear tool, then try getting a specific angle by setting the Offset value. **Solution** Replace Offset with Angle, and internally convert it with this formula: `offset = tan(radians(90) - angle)` **Notes** Perhaps this should be a feature request on another site rather than an issue here, but I decided to open one anyway since I'm going to make a pull request here.

shear_offset.blend

860 KiB

Jorijn de Graaf added the

labels 2024-02-17 18:43:28 +01:00

Jorijn de Graaf commented

2024-02-17 23:18:19 +01:00

Oh boy, all the transform operators are part of one big thing.
This might be more complicated than I thought.

Oh boy, all the transform operators are part of one big thing. This might be more complicated than I thought.

Richard Antalik commented

2024-02-18 20:53:13 +01:00

Oh boy, all the transform operators are part of one big thing.

I know that feeling :)

In any case, I would suggest discussing potentially complicated changes with module members before you spend a lot of time on coding. I can see your solution to be useful, but other users may want to use offset too, so I think there are things to discuss before implementing the feature.

> Oh boy, all the transform operators are part of one big thing. I know that feeling :) In any case, I would suggest discussing potentially complicated changes with module members before you spend a lot of time on coding. I can see your solution to be useful, but other users may want to use offset too, so I think there are things to discuss before implementing the feature.

👍 1

Pratik Borhade commented

2024-02-19 07:00:33 +01:00

offset = tan(radians(90) - angle)

Hi, I'm not able to verify this. Could reference the source .cc file?

> offset = tan(radians(90) - angle) Hi, I'm not able to verify this. Could reference the source .cc file?

Pratik Borhade added

Module

Modeling

Status

Needs Info from Developers

and removed

Status

Needs Triage

labels 2024-02-19 07:00:46 +01:00

Jorijn de Graaf commented

2024-02-20 00:18:47 +01:00

offset = tan(radians(90) - angle)

Hi, I'm not able to verify this.

My bad, it's just tan(angle); I found it through trial and error, and 90 minus 36 degrees was what I needed in a project.
Note that the angle needs to be in radians for tan to give sensible results, so when typing it in the UI you have to use tan(radians(angle)).

Could reference the source .cc file?

Relevant source files might be transform_gizmo_3d_shear.cc, transform_mode_shear.cc, or transform_ops.cc.
I stopped looking into it when I realized it might be complicated, but will resume if this is a feature people want.

Initially I thought angle would replace offset, but now I'm thinking there should be a way to use both (whichever the user prefers).

> > offset = tan(radians(90) - angle) > > Hi, I'm not able to verify this. My bad, it's just `tan(angle)`; I found it through trial and error, and 90 minus 36 degrees was what I needed in a project. Note that the angle needs to be in radians for tan to give sensible results, so when typing it in the UI you have to use `tan(radians(angle))`. > Could reference the source .cc file? Relevant source files might be `transform_gizmo_3d_shear.cc`, `transform_mode_shear.cc`, or `transform_ops.cc`. I stopped looking into it when I realized it might be complicated, but will resume if this is a feature people want. Initially I thought angle would replace offset, but now I'm thinking there should be a way to use both (whichever the user prefers).

Pratik Borhade commented

2024-02-22 06:54:19 +01:00

I'm still confused here. so if I enter offset value 2, operator evaluates it as tan(2 radian)?: Result when I offset an edge by 2
I think @mano-wii knows better about transform code.

I'm still confused here. so if I enter offset value 2, operator evaluates it as tan(2 radian)?: [Result when I offset an edge by 2](/attachments/2bdaa500-9247-4526-a332-3bb774cf06aa) I think @mano-wii knows better about transform code.

image.png

36 KiB

Jorijn de Graaf commented

2024-02-22 14:48:09 +01:00

I'm still confused here. so if I enter offset value 2, operator evaluates it as tan(2 radian)?

That's the wrong way around, let me try to explain it with some examples:
When you enter tan(radians(45)), that evaluates to an offset of 1, which visually is 45 degrees.
An offset of 2 equates to an angle around 63 degrees, because tan(radians(angle)) = offset.
This offset value in turn is plugged into the transformation matrix in some way I don't fully grasp.

> I'm still confused here. so if I enter offset value 2, operator evaluates it as tan(2 radian)? That's the wrong way around, let me try to explain it with some examples: When you enter `tan(radians(45))`, that evaluates to an offset of 1, which visually is 45 degrees. An offset of 2 equates to an angle around 63 degrees, because `tan(radians(angle)) = offset`. This offset value in turn is plugged into the transformation matrix in some way I don't fully grasp.

Germano Cavalcante changed title from ~~Shear tool Offset is unintuitive~~ to Shear: enter an angle instead of offset

2024-02-23 03:12:52 +01:00

Germano Cavalcante referenced this issue

2024-02-23 03:13:25 +01:00

Snapping & precision modeling improvements #73993

Germano Cavalcante commented

2024-02-23 03:24:58 +01:00

To support this it would be convenient to copy some of the solutions seen in the "TRANSFORM_OT_rotate_normal" operator.
Such as:

use angle property for "value" in transform_ops.cc.
use mouse input INPUT_ANGLE in transform_mode_shear.cc.

Since the offset value is currently the tangent of the angle, the conversion would basically make the angle a tangent with tanf(value).

I'm not much in position to confirm feature requests, but it seems like a convenient change. Therefore I added this task i created:
#73993 Snapping & precision modeling improvements

(I also added #73908: Shear: Support modal axis & user/local space switching).

@bonj, feel free to create a PR if you are working on this ;)

To support this it would be convenient to copy some of the solutions seen in the "TRANSFORM_OT_rotate_normal" operator. Such as: - use angle property for "value" in `transform_ops.cc`. - use mouse input `INPUT_ANGLE` in `transform_mode_shear.cc`. Since the offset value is currently the tangent of the angle, the conversion would basically make the angle a tangent with `tanf(value)`. I'm not much in position to confirm feature requests, but it seems like a convenient change. Therefore I added this task i created: #73993 Snapping & precision modeling improvements (I also added #73908: Shear: Support modal axis & user/local space switching). @bonj, feel free to create a PR if you are working on this ;)

Germano Cavalcante added

and removed

Needs Info from Developers

Type

Report

labels 2024-02-23 03:25:28 +01:00

Sign in to join this conversation.