blender/blender
147
472
Fork 691
Code Issues 6.7k Pull Requests 896 Projects 18 Wiki Activity

Library changes for Blender 4.2 #118455

New Issue
Open
opened 2024-02-19 13:27:57 +01:00 by Brecht Van Lommel · 40 comments
Brecht Van Lommel commented 2024-02-19 13:27:57 +01:00
Owner
Copy Link

Here is the list of all changes to our libraries for the Blender 4.2 release.

Note: now that we are in the LTS maintenance phase, the checklist has changed

To Do

  • None

Done 24-08-06

Done 24-07-08

Rejected

  • USD 24.03 maybe, would help with #92956 but perhaps needs more justification)

skipped 24.03 directly to 24.05

Here is the list of all changes to our libraries for the Blender 4.2 release. Note: now that we are in the LTS maintenance phase, the checklist has changed #### To Do - None #### Done 24-08-06 - [x] OpenCollada update to `dfc341ab0b3b23` - [x] Update CMake deps builder in main - [x] Add to back-ports in #124452 - [x] Back-port landed in 4.2 release branch ( @lichtwerk ) - [x] Update libs - [x] Add Package file to GIT (blender/lib-source@17e9f49a2a) - [x] Add precompiled libraries - [x] Windows X64 (blender/lib-windows_x64@41c5a2d2553a3fded0687d97088a19991d983c3b) - [x] Windows ARM64 (blender/blender@6377142b8aef83a79fcc8b2fb9d30c16324f9b07) - [x] Linux X64 (blender/blender@c10d9a556f085ae65da2a1049ce400e25b26e575) - [x] macOS Intel (blender/blender@92149a4a28) - [x] macOS Arm (blender/blender@92149a4a28) - [x] ~~Update `install_linux_packages`~~ N/A #### Done 24-07-08 - [x] lib265 / FFmpeg rebuild - [x] Update CMake deps builder (#120079) (880193d689) - [x] Add Package file to GIT (blender/lib-source@9eea661b8f) - [x] Add precompiled libraries - [x] Windows X64 (blender/lib-windows_x64@7707ad99af1839bc664cc94406a59c5f8f9cb335) - [x] Windows ARM64 (blender/lib-windows_arm64@06a9cd56a271b0d44a600858aedc8e32d18229a9) - [x] Linux (blender/lib-linux_x64@ae7099ed83d1dc40a4ac5f8db64a1f90a1cf0a22) - [x] macOS Intel - [x] macOS Arm - [x] Update `install_linux_packages` script _(N/A)_ - [x] OpenPGL 0.6.0 - [x] Update CMake deps builder (#118328) - [x] Add Package file to GIT (blender/lib-source@a3ed1adc29) - [x] Add precompiled libraries - [x] Windows X64 (blender/lib-windows_x64@7707ad99af1839bc664cc94406a59c5f8f9cb335) - [x] ~~Windows ARM64~~ (n/a, Windows ARM64 does not yet ship with OpenPGL) - [x] Linux (blender/lib-linux_x64@ae7099ed83d1dc40a4ac5f8db64a1f90a1cf0a22) - [x] macOS Intel - [x] macOS Arm - [x] Update `install_linux_packages` script - [x] OIDN 2.3.0 Final (was Beta) - [x] Update CMake deps builder (#121359, #123433) - [x] Add Package file to GIT (blender/lib-source@9eea661b8f) - [x] Add precompiled libraries - [x] Windows X64 (blender/lib-windows_x64@ede83a94b99ef9e5941836b6f1896d2451907b6f) - [x] Windows ARM64 (blender/lib-windows_arm64@06a9cd56a271b0d44a600858aedc8e32d18229a9) - [x] Linux (blender/lib-linux_x64@ae7099ed83d1dc40a4ac5f8db64a1f90a1cf0a22) - [x] macOS Intel - [x] macOS Arm - [x] Update `install_linux_packages` script (8501472c81ae5) - [x] USD 24.05 - [x] Update CMake deps builder (#121702) (e8fe320ea0fcea9ed3d394574a2e4f91e7c1e2d4) - [x] Add Package file to GIT (blender/lib-source@9eea661b8f) - [x] Add precompiled libraries - [x] Windows X64 (blender/lib-windows_x64@7707ad99af1839bc664cc94406a59c5f8f9cb335) - [x] Windows ARM64 (blender/lib-windows_arm64@06a9cd56a271b0d44a600858aedc8e32d18229a9) - [x] Linux (blender/lib-linux_x64@ae7099ed83d1dc40a4ac5f8db64a1f90a1cf0a22) - [x] macOS Intel - [x] macOS Arm - [x] Update `install_linux_packages` script (8501472c81ae5) - [x] OIIO v2.5.11.0 - Rebuild due PSD Loading Issue required - [x] Update CMake deps builder (#121823) (#121136) (8db709e149) (8082d92273280d313a50e1b8138a3212bcea82e5) - [x] Add Package file to GIT (blender/lib-source@9eea661b8f) - [x] Add precompiled libraries - [x] Windows X64 (blender/lib-windows_x64@) - [x] Windows ARM64 (blender/lib-windows_arm64@30392df6de73a5a10bdd1972ada583fc020d552c) - [x] Linux (blender/lib-linux_x64@052235e75a62d6eb9fc120540cc567718215e5ba) - [X] macOS Intel (blender/lib-macos_x64@416a2bc376) - [X] macOS Arm (blender/lib-macos_arm64@9cc70eaa4f) - [x] Update `install_linux_packages` script (8501472c81ae5) - [x] OSL Rebuild (no version change, but needs to be rebuild due to the OIIO version change) - [x] Update CMake deps builder (N/A) - [x] Add Package file to GIT (N/A) - [x] Add precompiled libraries - [x] Windows X64 (blender/lib-windows_x64@7707ad99af1839bc664cc94406a59c5f8f9cb335) - [x] Windows ARM64 (blender/lib-windows_arm64@06a9cd56a271b0d44a600858aedc8e32d18229a9) - [x] Linux (blender/lib-linux_x64@1e1739093a05bd09bd9f2003877d51ffa86d176b) - [x] macOS Intel - [x] macOS Arm - [x] Update `install_linux_packages` script _(N/A)_ - [x] OpenEXR 3.2.4 - [x] Update CMake deps builder (#121823) (8db709e149) - [x] Add Package file to GIT (blender/lib-source@9eea661b8f) - [x] Add precompiled libraries - [x] Windows X64 (blender/lib-windows_x64@7707ad99af1839bc664cc94406a59c5f8f9cb335) - [x] Windows ARM64 (blender/lib-windows_arm64@06a9cd56a271b0d44a600858aedc8e32d18229a9) - [x] Linux (blender/lib-linux_x64@ae7099ed83d1dc40a4ac5f8db64a1f90a1cf0a22) - [x] macOS Intel - [x] macOS Arm - [x] Update `install_linux_packages` script (8501472c81ae5) - [x] LibTIFF 4.6.0 - [x] Update CMake deps builder (#121823) (8db709e149) - [x] Add Package file to GIT (blender/lib-source@9eea661b8f) - [x] Add precompiled libraries - [x] Windows X64 (blender/lib-windows_x64@7707ad99af1839bc664cc94406a59c5f8f9cb335) - [x] Windows ARM64 (blender/lib-windows_arm64@06a9cd56a271b0d44a600858aedc8e32d18229a9) - [x] Linux (blender/lib-linux_x64@ae7099ed83d1dc40a4ac5f8db64a1f90a1cf0a22) - [x] macOS Intel - [x] macOS Arm - [x] Update `install_linux_packages` script _(N/A)_ - [x] FFTW with Threads - [x] Update CMake deps builder (#121816) - [x] Add Package file to GIT (N/A Rebuild only) - [x] Add precompiled libraries - [x] Windows X64 (blender/lib-windows_x64@7707ad99af1839bc664cc94406a59c5f8f9cb335) - [x] Windows ARM64 (blender/lib-windows_arm64@06a9cd56a271b0d44a600858aedc8e32d18229a9) - [x] Linux (blender/lib-linux_x64@ae7099ed83d1dc40a4ac5f8db64a1f90a1cf0a22) - [x] macOS Intel - [x] macOS Arm - [x] Update `install_linux_packages` script _(N/A)_ - [x] Level Zero 1.16.1 (d690b08c1f - 8fa578dcc2 - d8b3f852b9) - [x] Update CMake deps builder (#122242) - [x] Add Package file to GIT (blender/lib-source@9eea661b8f) - [x] Add precompiled libraries - [x] Windows X64 (blender/lib-windows_x64@7707ad99af1839bc664cc94406a59c5f8f9cb335) - [x] Windows ARM64 (blender/lib-windows_arm64@06a9cd56a271b0d44a600858aedc8e32d18229a9) - [x] Linux (blender/lib-linux_x64@ae7099ed83d1dc40a4ac5f8db64a1f90a1cf0a22) - [x] macOS Intel - [x] macOS Arm - [x] Update `install_linux_packages` script (8501472c81ae5) - [x] Embree 4.3.2-blender - [x] Update CMake deps builder (#122242) (d690b08c1f - 8fa578dcc2 - d8b3f852b9) - [x] Add Package file to GIT (blender/lib-source@9eea661b8f) - [x] Add precompiled libraries - [x] Windows X64 (blender/lib-windows_x64@7707ad99af1839bc664cc94406a59c5f8f9cb335) - [x] Windows ARM64 (blender/lib-windows_arm64@06a9cd56a271b0d44a600858aedc8e32d18229a9) - [x] Linux (blender/lib-linux_x64@ae7099ed83d1dc40a4ac5f8db64a1f90a1cf0a22) - [x] macOS Intel - [x] macOS Arm - [x] Update `install_linux_packages` script (8501472c81ae5) - [x] dpcpp d2817d6d317db1143bb227168e85c409d5ab7c82 (tip of sycl-rel_5_2_0 as of 2024.05.24) - [x] Update CMake deps builder (#122242) (d690b08c1f - 8fa578dcc2 - d8b3f852b9) - [x] Add Package file to GIT (blender/lib-source@9eea661b8f) - [x] Add precompiled libraries - [x] Windows X64 (blender/lib-windows_x64@7707ad99af1839bc664cc94406a59c5f8f9cb335) - [x] ~~Windows ARM64~~ (n/a Windows ARM64 does not use DPCPP) - [x] Linux (blender/lib-linux_x64@ae7099ed83d1dc40a4ac5f8db64a1f90a1cf0a22) - [x] macOS Intel - [x] macOS Arm - [x] Update `install_linux_packages` script _(N/A)_ - [x] Opencollada switch to aras_p's fork - [x] Update CMake deps builder (#122270) (f510722a20) - [x] Add Package file to GIT (blender/lib-source@9eea661b8f) - [x] Add precompiled libraries - [x] Windows X64 (blender/lib-windows_x64@7707ad99af1839bc664cc94406a59c5f8f9cb335) - [x] Windows ARM64 (blender/lib-windows_arm64@06a9cd56a271b0d44a600858aedc8e32d18229a9) - [x] Linux (blender/lib-linux_x64@ae7099ed83d1dc40a4ac5f8db64a1f90a1cf0a22) - [x] macOS Intel - [x] macOS Arm - [x] Update `install_linux_packages` script _(N/A)_ - [x] LibSndFile rebuild due to build system change to cmake - [x] Update CMake deps builder (#121401) (3aa00e14e4) - [x] Add Package file to GIT (N/A) - [x] Add precompiled libraries - [x] Windows X64 (blender/lib-windows_x64@7707ad99af1839bc664cc94406a59c5f8f9cb335) - [x] Windows ARM64 (blender/lib-windows_arm64@06a9cd56a271b0d44a600858aedc8e32d18229a9) - [x] Linux (blender/lib-linux_x64@ae7099ed83d1dc40a4ac5f8db64a1f90a1cf0a22) - [x] macOS Intel - [x] macOS Arm - [x] Update `install_linux_packages` script _(N/A)_ - [x] wayland 1.23 - [x] Update CMake deps builder (bb4946135a51e8848d830ac4b966044db82091a1) - [x] Add Package file to GIT (blender/lib-source@9eea661b8f) - [x] Add precompiled libraries - [x] Windows X64 _(N/A)_ - [x] Windows ARM64 _(N/A)_ - [x] Linux (blender/lib-linux_x64@4d2e4b4ba301e0a911d94dca83b99b88e5c579fe) - [x] macOS Intel _(N/A)_ - [x] macOS Arm _(N/A)_ - [x] Update `install_linux_packages` script _(N/A)_ - [x] wayland_protocols 1.36 - [x] Update CMake deps builder (bb4946135a51e8848d830ac4b966044db82091a1) - [x] Add Package file to GIT (blender/lib-source@9eea661b8f) - [x] Add precompiled libraries - [x] Windows X64 _(N/A)_ - [x] Windows ARM64 _(N/A)_ - [x] Linux (blender/lib-linux_x64@4d2e4b4ba301e0a911d94dca83b99b88e5c579fe) - [x] macOS Intel _(N/A)_ - [x] macOS Arm _(N/A)_ - [x] Update `install_linux_packages` script _(N/A)_ - [x] wayland_libdecor 0.2.2 - [x] Update CMake deps builder (bb4946135a51e8848d830ac4b966044db82091a1) - [x] Add Package file to GIT (blender/lib-source@9eea661b8f) - [x] Add precompiled libraries - [x] Windows X64 _(N/A)_ - [x] Windows ARM64 _(N/A)_ - [x] Linux (blender/lib-linux_x64@4d2e4b4ba301e0a911d94dca83b99b88e5c579fe) - [x] macOS Intel _(N/A)_ - [x] macOS Arm _(N/A)_ - [x] Update `install_linux_packages` script _(N/A)_ - [x] wayland_weston 13.0.3 - [x] Update CMake deps builder (bb4946135a51e8848d830ac4b966044db82091a1) - [x] Add Package file to GIT (blender/lib-source@9eea661b8f) - [x] Add precompiled libraries - [x] Windows X64 _(N/A)_ - [x] Windows ARM64 _(N/A)_ - [x] Linux (blender/lib-linux_x64@4d2e4b4ba301e0a911d94dca83b99b88e5c579fe) - [x] macOS Intel _(N/A)_ - [x] macOS Arm _(N/A)_ - [x] Update `install_linux_packages` script _(N/A)_ ### Rejected - [x] USD 24.03 maybe, would help with #92956 but perhaps needs more justification) skipped 24.03 directly to 24.05 ---
Brecht Van Lommel added this to the 4.2 LTS milestone 2024-02-19 13:27:57 +01:00
Brecht Van Lommel commented 2024-02-19 13:29:57 +01:00
Author
Owner
Copy Link

CC @farsthary @LazyDodo @ideasman42, you might want to subscribe to this issue.

The OpenPGL library update is not urgent at all, and may be more convenient to do after 4.1 is out.

CC @farsthary @LazyDodo @ideasman42, you might want to subscribe to this issue. The OpenPGL library update is not urgent at all, and may be more convenient to do after 4.1 is out.
👍 1
Ray molenkamp commented 2024-03-17 19:44:16 +01:00
Member
Copy Link

is there a module ticket/request for libx265 support or is it more of a if we will add it, someone will integrate it?

edit:
I'm scripting it currently, given the origin of this request is unknown, i'll drop the questions over here:

x265 supports 8/10/12 bits bit depths, but you'll have to build the lib 3 times if you want all three, what do we want to do here? supporting 8/10/12 sounds like the most future proof way to go about it but it may bloat the final binary a tiny bit (guessing it'll come in well below 10MiB though, do note: guessing as i haven't done the work yet)

is there a module ticket/request for libx265 support or is it more of a if we will add it, someone will integrate it? edit: I'm scripting it currently, given the origin of this request is unknown, i'll drop the questions over here: x265 supports 8/10/12 bits bit depths, but you'll have to build the lib 3 times if you want all three, what do we want to do here? supporting 8/10/12 sounds like the most future proof way to go about it but it may bloat the final binary a tiny bit (guessing it'll come in well below 10MiB though, do note: guessing as i haven't done the work yet)
Sergey Sharybin commented 2024-03-18 09:51:13 +01:00
Owner
Copy Link

@LazyDodo There is a ticket to support high bit depth for videos #118493. Having x265 would improve interoperability. However, the resources for supporting new formats are a bit limited, and for the technical changes on Blender side h264/AV1 seems to be sufficient for developers to work.

So if you have time, having a compiled library will definitely be welcome and will help with moving forward, but if you don't have time then there is no rush with it.

@LazyDodo There is a ticket to support high bit depth for videos #118493. Having x265 would improve interoperability. However, the resources for supporting new formats are a bit limited, and for the technical changes on Blender side h264/AV1 seems to be sufficient for developers to work. So if you have time, having a compiled library will definitely be welcome and will help with moving forward, but if you don't have time then there is no rush with it.
👍 1
Attila Áfra commented 2024-04-02 17:02:58 +02:00
Contributor
Copy Link

@brecht Would you be interested in integrating an OIDN 2.3 beta release into Blender 4.2 alpha? I think this way we could catch and fix issues (e.g. HIP) much earlier than last time, and the upgrade to final OIDN 2.3 should be much smoother.

@brecht Would you be interested in integrating an OIDN 2.3 beta release into Blender 4.2 alpha? I think this way we could catch and fix issues (e.g. HIP) much earlier than last time, and the upgrade to final OIDN 2.3 should be much smoother.
Brecht Van Lommel commented 2024-04-15 18:34:37 +02:00
Author
Owner
Copy Link

@aafra if there are changes in 2.3 that have some risk of causing system or platform specific issues, then it seems useful indeed to integrate the beta.

@aafra if there are changes in 2.3 that have some risk of causing system or platform specific issues, then it seems useful indeed to integrate the beta.
👍 1
Attila Áfra commented 2024-04-15 22:25:53 +02:00
Contributor
Copy Link

@brecht Yes, there will be such changes in 2.3. Thanks!

@brecht Yes, there will be such changes in 2.3. Thanks!
Jesse Yurkovich commented 2024-05-13 18:02:49 +02:00
Member
Copy Link

How would we feel about just bumping OpenImageIO to 2.5.11? It contains the mentioned patch from above as well as the one inside our oiio_4044.diff (so we can drop those 2). It also contains a few DDS related fix/improvements that might be good to have for LTS.

How would we feel about just bumping OpenImageIO to 2.5.11? It contains the mentioned patch from above as well as the one inside our `oiio_4044.diff` (so we can drop those 2). It also contains a few DDS related fix/improvements that might be good to have for LTS.
Ray molenkamp commented 2024-05-13 18:42:30 +02:00
Member
Copy Link

fine with me, i may also want to bump libtiff/openexr to resolve to cve's probably best to do that in one go so we don't have to rebuild oiio over and over

fine with me, i may also want to bump libtiff/openexr to resolve to cve's probably best to do that in one go so we don't have to rebuild oiio over and over
Brecht Van Lommel commented 2024-05-13 18:53:29 +02:00
Author
Owner
Copy Link

Upgrading OIIO is fine with me.

Upgrading OIIO is fine with me.
Ray molenkamp commented 2024-05-13 18:54:24 +02:00
Member
Copy Link

I'll get that going

I'll get that going
Campbell Barton commented 2024-05-14 03:28:56 +02:00
Owner
Copy Link

+1 for OIIO upgrade.

+1 for OIIO upgrade.
Attila Áfra commented 2024-05-23 18:31:02 +02:00
Contributor
Copy Link

@brecht I just downloaded the latest 4.2 alpha build and I noticed that it's still built with OIDN 2.2.2 instead of 2.3.0-beta. This means that Blender users cannot test the new features and changes in OIDN 2.3.0, some of which are exposed through the Blender UI. The main reason why we released a beta version was to catch potential issues early in Blender, so we could fix them on time for the final release. Would it be still possible to upgrade now to 2.3.0-beta and then later upgrade again to final 2.3.0? Thanks!

@brecht I just downloaded the latest 4.2 alpha build and I noticed that it's still built with OIDN 2.2.2 instead of 2.3.0-beta. This means that Blender users cannot test the new features and changes in OIDN 2.3.0, some of which are exposed through the Blender UI. The main reason why we released a beta version was to catch potential issues early in Blender, so we could fix them on time for the final release. Would it be still possible to upgrade now to 2.3.0-beta and then later upgrade again to final 2.3.0? Thanks!
Brecht Van Lommel commented 2024-05-23 20:24:25 +02:00
Author
Owner
Copy Link

@aafra Yes, it's taking longer than I expected to update the libraries. I think the platform maintainers have been rather busy, but it should happen in the next two weeks since this is usually done before the end of bcon2.

@aafra Yes, it's taking longer than I expected to update the libraries. I think the platform maintainers have been rather busy, but it should happen in the next two weeks since this is usually done before the end of bcon2.
👍 1
Attila Áfra commented 2024-05-23 22:21:06 +02:00
Contributor
Copy Link

@brecht OK, thanks. And when should the upgrade to final OIDN 2.3.0 happen? Before the end of bcon3?

@brecht OK, thanks. And when should the upgrade to final OIDN 2.3.0 happen? Before the end of bcon3?
Brecht Van Lommel commented 2024-05-23 22:29:03 +02:00
Author
Owner
Copy Link

Preferably before the end of bcon2 (June 5). The end of bcon3 (July 10) is just 1 week before the release, so that's too late. Between that it's fuzzier, but I prefer not to bother platform maintainers with last minute updates if we can avoid it.

Preferably before the end of bcon2 (June 5). The end of bcon3 (July 10) is just 1 week before the release, so that's too late. Between that it's fuzzier, but I prefer not to bother platform maintainers with last minute updates if we can avoid it.
Attila Áfra commented 2024-05-23 22:48:24 +02:00
Contributor
Copy Link

I'm not sure what to do then. It sounds like you would need the final 2.3.0 by the time you could upgrade to the beta, so there's no point upgrading to the beta at all. I was hoping we could get at least a couple of weeks of testing of the beta before moving forward with the final release but it seems this won't be possible.

I'm not sure what to do then. It sounds like you would need the final 2.3.0 by the time you could upgrade to the beta, so there's no point upgrading to the beta at all. I was hoping we could get at least a couple of weeks of testing of the beta before moving forward with the final release but it seems this won't be possible.
Brecht Van Lommel commented 2024-05-23 23:13:29 +02:00
Author
Owner
Copy Link

The platform maintainers (@LazyDodo @farsthary @ideasman42) could upgrade e.g. tomorrow if they have time, but I can't speak for them. If they don't then indeed we won't be able to test the beta, sorry about that.

The platform maintainers (@LazyDodo @farsthary @ideasman42) could upgrade e.g. tomorrow if they have time, but I can't speak for them. If they don't then indeed we won't be able to test the beta, sorry about that.
👍 1
Ray molenkamp commented 2024-05-24 15:21:31 +02:00
Member
Copy Link

There must have been a miscommunication somewhere down the line, while my schedule was action packed, I wasn't aware OIDN wanted the update asap, and had the work scheduled with the rest of the lib updates (tail end of bcon2) .OIDN is pretty easy i could get it done today if need to be.

There must have been a miscommunication somewhere down the line, while my schedule was action packed, I wasn't aware OIDN wanted the update asap, and had the work scheduled with the rest of the lib updates (tail end of bcon2) .OIDN is pretty easy i could get it done today if need to be.
Attila Áfra commented 2024-05-24 15:32:17 +02:00
Contributor
Copy Link

@LazyDodo The idea was to upgrade to the OIDN beta first, have a few weeks of testing, fix any potential issues, and then upgrade to the final version. Blender 4.2 final shouldn't be released with a beta version of OIDN.

@LazyDodo The idea was to upgrade to the OIDN beta first, have a few weeks of testing, fix any potential issues, and then upgrade to the final version. Blender 4.2 final shouldn't be released with a beta version of OIDN.
Brecht Van Lommel commented 2024-05-24 17:01:50 +02:00
Author
Owner
Copy Link

@aafra On macOS there is an OIDN build error due to missing #include <thread> in devices/cpu/cpu_engine.h. Adding that include makes the build pass. We can patch this locally for now, but would be good to fix.

[ 70%] Building CXX object devices/cpu/CMakeFiles/OpenImageDenoise_device_cpu.dir/cpu_autoexposure.cpp.o
In file included from /Users/raulito/blender-git/build_darwin/deps/build/openimagedenoise/src/external_openimagedenoise/devices/cpu/cpu_autoexposure.cpp:4:
In file included from /Users/raulito/blender-git/build_darwin/deps/build/openimagedenoise/src/external_openimagedenoise/devices/cpu/cpu_autoexposure.h:7:
/Users/raulito/blender-git/build_darwin/deps/build/openimagedenoise/src/external_openimagedenoise/devices/cpu/cpu_engine.h:57:5: error: no type named 'thread' in namespace 'std'; did you mean 'thread_t'?
    std::thread queueThread;                   // thread that processes the queue
    ^~~~~~~~~~~
    thread_t
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk/usr/include/mach/mach_types.h:125:33: note: 'thread_t' declared here
typedef mach_port_t             thread_t;
                                ^
1 error generated.
@aafra On macOS there is an OIDN build error due to missing `#include <thread>` in `devices/cpu/cpu_engine.h`. Adding that include makes the build pass. We can patch this locally for now, but would be good to fix. ``` [ 70%] Building CXX object devices/cpu/CMakeFiles/OpenImageDenoise_device_cpu.dir/cpu_autoexposure.cpp.o In file included from /Users/raulito/blender-git/build_darwin/deps/build/openimagedenoise/src/external_openimagedenoise/devices/cpu/cpu_autoexposure.cpp:4: In file included from /Users/raulito/blender-git/build_darwin/deps/build/openimagedenoise/src/external_openimagedenoise/devices/cpu/cpu_autoexposure.h:7: /Users/raulito/blender-git/build_darwin/deps/build/openimagedenoise/src/external_openimagedenoise/devices/cpu/cpu_engine.h:57:5: error: no type named 'thread' in namespace 'std'; did you mean 'thread_t'? std::thread queueThread; // thread that processes the queue ^~~~~~~~~~~ thread_t /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk/usr/include/mach/mach_types.h:125:33: note: 'thread_t' declared here typedef mach_port_t thread_t; ^ 1 error generated. ```
Ray molenkamp commented 2024-05-24 18:53:11 +02:00
Member
Copy Link

Since there were no test failures, I updated the windows x64 libs they should be in the next nightly build, sorry for the delay

Since there were no test failures, I updated the windows x64 libs they should be in the next nightly build, sorry for the delay
👍 2 🚀 1
Attila Áfra commented 2024-05-24 18:58:18 +02:00
Contributor
Copy Link

@aafra On macOS there is an OIDN build error due to missing #include <thread> in devices/cpu/cpu_engine.h. Adding that include makes the build pass. We can patch this locally for now, but would be good to fix.

[ 70%] Building CXX object devices/cpu/CMakeFiles/OpenImageDenoise_device_cpu.dir/cpu_autoexposure.cpp.o
In file included from /Users/raulito/blender-git/build_darwin/deps/build/openimagedenoise/src/external_openimagedenoise/devices/cpu/cpu_autoexposure.cpp:4:
In file included from /Users/raulito/blender-git/build_darwin/deps/build/openimagedenoise/src/external_openimagedenoise/devices/cpu/cpu_autoexposure.h:7:
/Users/raulito/blender-git/build_darwin/deps/build/openimagedenoise/src/external_openimagedenoise/devices/cpu/cpu_engine.h:57:5: error: no type named 'thread' in namespace 'std'; did you mean 'thread_t'?
    std::thread queueThread;                   // thread that processes the queue
    ^~~~~~~~~~~
    thread_t
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk/usr/include/mach/mach_types.h:125:33: note: 'thread_t' declared here
typedef mach_port_t             thread_t;
                                ^
1 error generated.

Thanks! Strangely I cannot reproduce this on our machines but the include is indeed missing and will be fixed in the final version.

> @aafra On macOS there is an OIDN build error due to missing `#include <thread>` in `devices/cpu/cpu_engine.h`. Adding that include makes the build pass. We can patch this locally for now, but would be good to fix. > > ``` > [ 70%] Building CXX object devices/cpu/CMakeFiles/OpenImageDenoise_device_cpu.dir/cpu_autoexposure.cpp.o > In file included from /Users/raulito/blender-git/build_darwin/deps/build/openimagedenoise/src/external_openimagedenoise/devices/cpu/cpu_autoexposure.cpp:4: > In file included from /Users/raulito/blender-git/build_darwin/deps/build/openimagedenoise/src/external_openimagedenoise/devices/cpu/cpu_autoexposure.h:7: > /Users/raulito/blender-git/build_darwin/deps/build/openimagedenoise/src/external_openimagedenoise/devices/cpu/cpu_engine.h:57:5: error: no type named 'thread' in namespace 'std'; did you mean 'thread_t'? > std::thread queueThread; // thread that processes the queue > ^~~~~~~~~~~ > thread_t > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk/usr/include/mach/mach_types.h:125:33: note: 'thread_t' declared here > typedef mach_port_t thread_t; > ^ > 1 error generated. > ``` Thanks! Strangely I cannot reproduce this on our machines but the include is indeed missing and will be fixed in the final version.
Xavier Hallade commented 2024-05-28 08:50:07 +02:00
Member
Copy Link

We'd need to upgrade DPC++ (5.2) and Embree (4.3.2) to get latest improvements and fixes, I've opened a PR for this here: #122242

We'd need to upgrade DPC++ (5.2) and Embree (4.3.2) to get latest improvements and fixes, I've opened a PR for this here: https://projects.blender.org/blender/blender/pulls/122242
Anthony Roberts commented 2024-06-18 18:19:45 +02:00
Member
Copy Link

I updated Windows ARM64 last week, but didn't update this issue - now updated

I updated Windows ARM64 last week, but didn't update this issue - now updated
Jesse Yurkovich commented 2024-06-19 10:59:32 +02:00
Member
Copy Link

A heads up that there's likely a re-build necessary for OIIO due to a bug from the version we took: https://github.com/AcademySoftwareFoundation/OpenImageIO/issues/4298 (#123218)

I'll provide a patch on our side sometime soon. It will either revert the problematic change entirely or fix the issue.

A heads up that there's likely a re-build necessary for OIIO due to a bug from the version we took: https://github.com/AcademySoftwareFoundation/OpenImageIO/issues/4298 (#123218) I'll provide a patch on our side sometime soon. It will either revert the problematic change entirely or fix the issue.
Brecht Van Lommel commented 2024-06-19 17:55:41 +02:00
Author
Owner
Copy Link

There is the upgrade of OIDN from beta to final as well, I added it in the issue description.

There is the upgrade of OIDN from beta to final as well, I added it in the issue description.
Jesse Yurkovich commented 2024-06-24 17:48:58 +02:00
Member
Copy Link

Attached is the OpenImageIO diff that was reviewed and committed to fix the PSD file loading issue.
OIIO bug/PR: https://github.com/AcademySoftwareFoundation/OpenImageIO/issues/4298 / https://github.com/AcademySoftwareFoundation/OpenImageIO/pull/4302

It doesn't have the cmake changes though. @LazyDodo do you have those by chance since you were able to get me a build last week? There were no relevant changes since then.

Attached is the OpenImageIO diff that was reviewed and committed to fix the PSD file loading issue. OIIO bug/PR: https://github.com/AcademySoftwareFoundation/OpenImageIO/issues/4298 / https://github.com/AcademySoftwareFoundation/OpenImageIO/pull/4302 It doesn't have the cmake changes though. @LazyDodo do you have those by chance since you were able to get me a build last week? There were no relevant changes since then.
oiio_4298.diff
4.3 KiB
Ray molenkamp commented 2024-06-24 17:56:41 +02:00
Member
Copy Link

I didn't keep them, blew them away when i had to do some oidn work, it's not much work, i'll integrate it for you

I didn't keep them, blew them away when i had to do some oidn work, it's not much work, i'll integrate it for you
Ray molenkamp commented 2024-06-24 20:19:31 +02:00
Member
Copy Link

That OIIO patch has integrated in both 4.2 and main branches, and windows x64 libs have been updated, all other platforms still require a rebuild of oiio, top post has been updated to signify this.

That OIIO patch has integrated in both 4.2 and main branches, and windows x64 libs have been updated, all other platforms still require a rebuild of oiio, top post has been updated to signify this.
Campbell Barton commented 2024-06-26 08:13:19 +02:00
Owner
Copy Link

Bumped Wayland libraries, as they're dynamically loaded it's mainly to avoid complications if we need to back-port fixes to 4.2 that depend on newer protocols/API's.
The only remaining changes are to update install_linux_packages - see version changes in bb4946135a, CC @mont29.

Bumped Wayland libraries, as they're dynamically loaded it's mainly to avoid complications if we need to back-port fixes to 4.2 that depend on newer protocols/API's. The only remaining changes are to update `install_linux_packages` - see version changes in bb4946135a51e8848d830ac4b966044db82091a1, CC @mont29.
Bastien Montagne commented 2024-06-26 10:00:24 +02:00
Owner
Copy Link

@ideasman42 thanks for the poke. We don't track Wayland versions currently in install_linux_package, just use whatever is available as dev packages. Updated the task.

@ideasman42 thanks for the poke. We don't track Wayland versions currently in `install_linux_package`, just use whatever is available as dev packages. Updated the task.
Bastien Montagne commented 2024-06-26 10:01:55 +02:00
Owner
Copy Link

@Anthony-Roberts think we are only missing the rebuild for the patched OIIO on MacOS to be complete?

@Anthony-Roberts think we are only missing the rebuild for the patched OIIO on MacOS to be complete?
Anthony Roberts commented 2024-06-26 10:27:19 +02:00
Member
Copy Link

@mont29 MacOS? No idea

I can do an update for Windows ARM64 today, though

@mont29 MacOS? No idea I can do an update for Windows ARM64 today, though
👍 1
Bastien Montagne commented 2024-06-26 10:44:23 +02:00
Owner
Copy Link

@Anthony-Roberts Woops sorry...

@farsthary poke, to rebuild OSX OIIO libraries? Or has it been done already? Then could update the task ;)

@Anthony-Roberts Woops sorry... @farsthary poke, to rebuild OSX OIIO libraries? Or has it been done already? Then could update the task ;)
Raul Fernandez Hernandez commented 2024-06-26 14:18:30 +02:00
Member
Copy Link

I'll rebuild all macos libs again today (x86 and arm) but it will take me some time since
space is limited for me I wipe the results after pushing.

and seems to have problems downloading the library sources

`CMake Error at cmake/download.cmake:37 (file):
file DOWNLOAD cannot compute hash on failed download

status: [28;"Timeout was reached"]

Call Stack (most recent call first):
cmake/download.cmake:171 (download_source)
CMakeLists.txt:32 (include)
`

I'll rebuild all macos libs again today (x86 and arm) but it will take me some time since space is limited for me I wipe the results after pushing. and seems to have problems downloading the library sources > `CMake Error at cmake/download.cmake:37 (file): > file DOWNLOAD cannot compute hash on failed download > > status: [28;"Timeout was reached"] > Call Stack (most recent call first): > cmake/download.cmake:171 (download_source) > CMakeLists.txt:32 (include) > `
Sergey Sharybin commented 2024-06-26 14:45:21 +02:00
Owner
Copy Link

@farsthary I'll do the libraries update. Should be easier for me since we have dedicated machine here.

@farsthary I'll do the libraries update. Should be easier for me since we have dedicated machine here.
❤️ 1
Aras Pranckevicius commented 2024-07-21 16:31:17 +02:00
Member
Copy Link

Due to my stupidity there's an OpenCollada bug that breaks import of animated things (#124859). To fix the issue, OpenCOLLADA needs to be updated to version dfc341ab0b3b23 (commit) and all the platform libraries rebuilt and comitted. @LazyDodo said to just add a comment about all that here.

Due to my stupidity there's an OpenCollada bug that breaks import of animated things (#124859). To fix the issue, OpenCOLLADA needs to be updated to version `dfc341ab0b3b23` ([commit](https://github.com/aras-p/OpenCOLLADA/commit/dfc341ab0b3b23)) and all the platform libraries rebuilt and comitted. @LazyDodo said to just add a comment about all that here.
Sergey Sharybin commented 2024-07-22 12:21:00 +02:00
Owner
Copy Link

Added a section for 4.2.1 updates with a check-list to track the progress.
We didn't ship 4.2 for WoA, but the library would need to be updated for 4.3 anyway, so the WoA is on the list.

@LazyDodo What would be the best process in your experience? Commit libraries to 4.3/main, and cherry-pick/copy-over to 4.2? Or commit to 4.2, and merge to 4.3/main?

Added a section for 4.2.1 updates with a check-list to track the progress. We didn't ship 4.2 for WoA, but the library would need to be updated for 4.3 anyway, so the WoA is on the list. @LazyDodo What would be the best process in your experience? Commit libraries to 4.3/main, and cherry-pick/copy-over to 4.2? Or commit to 4.2, and merge to 4.3/main?
Ray molenkamp commented 2024-07-22 15:20:32 +02:00
Member
Copy Link

Added a section for 4.2.1 updates with a check-list to track the progress.

Add it to the top under todo instead (moved it for you), no one wants to scroll 2 miles to see if there's work to be done, this is also the location release managers also check there to see if there's work still to be done, the person who puts the lack checkmark in, may move the work from the todo section to the Done yy-mm-dd section just below it, and fill in the actual date the work was completed.

The workflow for LTS tickets is almost identical to the route a normal fix takes with some notable changes for scheduling purposes.

  1. Land the deps builder change in man
  2. Update the libs in main
  3. Add the commit to the 4.2 maintenance ticket #124452 In the remarks field note the platform maintainers need to update the libs in the 4.2 branch
  4. Once the commit lands in 4.2, the LTS maintainer will leave a comment on this ticket.
  5. Update the libs in the 4.2 release branch
> Added a section for 4.2.1 updates with a check-list to track the progress. Add it to the top under todo instead (moved it for you), no one wants to scroll 2 miles to see if there's work to be done, this is also the location release managers also check there to see if there's work still to be done, the person who puts the lack checkmark in, may move the work from the todo section to the `Done yy-mm-dd` section just below it, and fill in the actual date the work was completed. The workflow for LTS tickets is almost identical to the route a normal fix takes with some notable changes for scheduling purposes. 1. Land the deps builder change in man 2. Update the libs in main 3. Add the commit to the 4.2 maintenance ticket #124452 In the remarks field note the platform maintainers need to update the libs in the 4.2 branch 4. Once the commit lands in 4.2, the LTS maintainer will leave a comment on this ticket. 5. Update the libs in the 4.2 release branch
👍 1
Philipp Oeser commented 2024-07-26 09:34:18 +02:00
Member
Copy Link

Backport for OpenCollada is in https://projects.blender.org/blender/blender/commit/af5ff37dd5f , so libs should/could be updated

Backport for OpenCollada is in https://projects.blender.org/blender/blender/commit/af5ff37dd5f , so libs should/could be updated
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset System
Asset datablocks, libraries, browser and shelf

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Viewport & EEVEE

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Module
Viewport & EEVEE

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Severity
High

  
Severity
Low

  
Severity
Normal

  
Severity
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

Archived

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
4.2 LTS
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
12 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#118455
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?