Crash if you change the workspace when the script warning is displayed. #118765

New Issue

ugorek · 2024-02-26T22:39:27+01:00

ugorek commented

2024-02-26 22:39:27 +01:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1650/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 546.33

Blender Version
Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-02-26 15:01, hash: bace4c9a293c
Worked: ?

Short description of error

>	blender.exe!ui_handle_menus_recursive(bContext * C, const wmEvent * event, uiPopupBlockHandle * menu, int level, const bool is_parent_inside, const bool is_parent_menu, const bool is_floating) Line 11475	C++
 	blender.exe!ui_popup_handler(bContext * C, const wmEvent * event, void * userdata) Line 11723	C++
 	blender.exe!wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, const bool always_pass) Line 834	C++
 	blender.exe!wm_handlers_do_intern(bContext * C, wmWindow * win, wmEvent * event, ListBase * handlers) Line 3326	C++
 	blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 3445	C++
 	blender.exe!wm_event_do_handlers(bContext * C) Line 4072	C++
 	blender.exe!WM_main(bContext * C) Line 638	C++
 	blender.exe!main(int argc, const char * * __formal) Line 579	C++

Exact steps for others to reproduce the error

Remove your \4.2\config\startup.blend (optional?)
Open Blender
Factory settings (optional?)
Scripting workspace
New
Register checkbox
Layout workspace
Shift + drag to create new window
Save Startup File
Save File
Exit.
Open saved file.
Security-alert on second window?
Then change your workspace.
Wait ~1 second.
Crash!

It is quite possible that the attached file will not serve to replicate the problem. You must follow the steps exactly so that the popup appears in the second window (not in the main window).

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1650/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 546.33 **Blender Version** Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-02-26 15:01, hash: `bace4c9a293c` Worked: ? **Short description of error** ``` > blender.exe!ui_handle_menus_recursive(bContext * C, const wmEvent * event, uiPopupBlockHandle * menu, int level, const bool is_parent_inside, const bool is_parent_menu, const bool is_floating) Line 11475 C++ blender.exe!ui_popup_handler(bContext * C, const wmEvent * event, void * userdata) Line 11723 C++ blender.exe!wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, const bool always_pass) Line 834 C++ blender.exe!wm_handlers_do_intern(bContext * C, wmWindow * win, wmEvent * event, ListBase * handlers) Line 3326 C++ blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 3445 C++ blender.exe!wm_event_do_handlers(bContext * C) Line 4072 C++ blender.exe!WM_main(bContext * C) Line 638 C++ blender.exe!main(int argc, const char * * __formal) Line 579 C++ ``` <video src="/attachments/6802b726-a0da-4f0b-9fd8-43156538e6b9" title="24.02.29 20.00.00.mp4" controls></video> **Exact steps for others to reproduce the error** 1. Remove your `\4.2\config\startup.blend` (optional?) 2. Open Blender 3. Factory settings (optional?) 4. Scripting workspace 5. New 6. Register checkbox 7. Layout workspace 8. Shift + drag to create new window 9. Save Startup File 10. Save File 11. Exit. 12. Open saved file. 13. Security-alert on second window? 14. Then change your workspace. 15. Wait ~1 second. 16. Crash! It is quite possible that the attached file will not serve to replicate the problem. You must follow the steps exactly so that the popup appears in the second window (not in the main window).

untitled.blend

912 KiB

ugorek added the

labels 2024-02-26 22:39:27 +01:00

Germano Cavalcante commented

2024-02-27 15:28:15 +01:00

Hi @ugorek,

Thank you for reporting this issue. I have tried reproducing the issue using the .blend file I attached, but I was unable to encounter the crash.

To further investigate the issue, could you please provide us with a .blend file that consistently triggers the crash?

Hi @ugorek, Thank you for reporting this issue. I have tried reproducing the issue using the .blend file I attached, but I was unable to encounter the crash. To further investigate the issue, could you please provide us with a .blend file that consistently triggers the crash?

test.blend

938 KiB

Germano Cavalcante added

Status

Needs Information from User

and removed

Status

Needs Triage

labels 2024-02-27 15:28:24 +01:00

ugorek commented

2024-02-27 21:46:05 +01:00

I noticed that in your file you created a full copy of the window by bpy.ops.wm.window_new_main()?
To repeat the bug, you need to create just a new window, or use shift and drag through the corner of area.
@mano-wii

I noticed that in your file you created a full copy of the window by `bpy.ops.wm.window_new_main()`? To repeat the bug, you need to create just a new window, or use shift and drag through the corner of area. @mano-wii

untitled.blend

966 KiB

Germano Cavalcante added

Status

Needs Triage

and removed

Status

Needs Information from User

labels 2024-02-28 15:58:07 +01:00

Germano Cavalcante commented

2024-02-29 12:20:19 +01:00

~~Could you please provide a .blend file that consistently triggers the crash?~~
~~I'm confused on the steps as I'm not sure if it is possibly to change the workspace in a window that isn't the main one.~~~

EDIT:
Oh, I didn't see the attachment in last comment

~~Could you please provide a .blend file that consistently triggers the crash?~~ ~~I'm confused on the steps as I'm not sure if it is possibly to change the workspace in a window that isn't the main one.~~~ EDIT: Oh, I didn't see the attachment in last comment

Germano Cavalcante added

Status

Needs Information from User

and removed

Status

Needs Triage

labels 2024-02-29 12:20:28 +01:00

Germano Cavalcante commented

2024-02-29 12:24:36 +01:00

Is weird. But here the warning popup never appears in the window other than the main one.

ugorek commented

2024-02-29 14:02:49 +01:00

:O
This is true.

Here are the very precise steps to reproduce the bug:

Remove your \4.2\config\startup.blend (optional?)
Open Blender
Factory settings (optional?)
Scripting workspace
New
Register checkbox
Layout workspace
Shift + drag to create new window
Save Startup File
Save File
Exit.
Open saved file.
Security-alert on second window?
Then change your workspace.
Wait ~1 second.
Crash!

@mano-wii ^

:O This is true. Here are the very precise steps to reproduce the bug: 1. Remove your `\4.2\config\startup.blend` (optional?) 2. Open Blender 3. Factory settings (optional?) 4. Scripting workspace 5. New 6. Register checkbox 7. Layout workspace 8. Shift + drag to create new window 9. Save Startup File 10. Save File 11. Exit. 12. Open saved file. 13. Security-alert on second window? 14. Then change your workspace. 15. Wait ~1 second. 16. Crash! @mano-wii ^ <video src="/attachments/6802b726-a0da-4f0b-9fd8-43156538e6b9" title="24.02.29 20.00.00.mp4" controls></video>

24.02.29 20.00.00.mp4

5.0 MiB

Germano Cavalcante commented

2024-02-29 16:36:08 +01:00

I was able to replicate it now!
This is the call stack at the time of the crash:

>	blender.exe!ui_handle_menus_recursive(bContext * C, const wmEvent * event, uiPopupBlockHandle * menu, int level, const bool is_parent_inside, const bool is_parent_menu, const bool is_floating) Line 11475	C++
 	blender.exe!ui_popup_handler(bContext * C, const wmEvent * event, void * userdata) Line 11723	C++
 	blender.exe!wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, const bool always_pass) Line 834	C++
 	blender.exe!wm_handlers_do_intern(bContext * C, wmWindow * win, wmEvent * event, ListBase * handlers) Line 3326	C++
 	blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 3445	C++
 	blender.exe!wm_event_do_handlers(bContext * C) Line 4072	C++
 	blender.exe!WM_main(bContext * C) Line 638	C++
 	blender.exe!main(int argc, const char * * __formal) Line 579	C++

I will edit the description to include all steps.

I was able to replicate it now! This is the call stack at the time of the crash: ``` > blender.exe!ui_handle_menus_recursive(bContext * C, const wmEvent * event, uiPopupBlockHandle * menu, int level, const bool is_parent_inside, const bool is_parent_menu, const bool is_floating) Line 11475 C++ blender.exe!ui_popup_handler(bContext * C, const wmEvent * event, void * userdata) Line 11723 C++ blender.exe!wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, const bool always_pass) Line 834 C++ blender.exe!wm_handlers_do_intern(bContext * C, wmWindow * win, wmEvent * event, ListBase * handlers) Line 3326 C++ blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 3445 C++ blender.exe!wm_event_do_handlers(bContext * C) Line 4072 C++ blender.exe!WM_main(bContext * C) Line 638 C++ blender.exe!main(int argc, const char * * __formal) Line 579 C++ ``` I will edit the description to include all steps.

Germano Cavalcante added

and removed

Needs Information from User

labels 2024-02-29 16:40:56 +01:00

Harley Acheson self-assigned this 2024-03-05 20:15:11 +01:00

Harley Acheson commented

2024-03-05 20:46:00 +01:00

Interesting.

My gut feeling is that we should fix this simply.

The larger problem this points to is something we might not want to "fix". When we show a popup block we then will close it if you click anywhere else in that same window. But we don't close popup blocks if you click somewhere in a different window. And that's probably a good thing in many cases. In most cases we should avoid messing with content on other windows.

In this case, and for wm_test_opengl_deprecation_warning, this problem just goes away if we just show these warnings on the main window and not a child. That is the intent anyway, that these be prominent warnings on the main window. It is just an unintended bug that these show on the wrong window in the above circumstances. With that corrected this error can't occur.

Interesting. My gut feeling is that we should fix this simply. The larger problem this points to is something we might not want to "fix". When we show a popup block we then will close it if you click anywhere else in that same window. But we don't close popup blocks if you click somewhere in a different window. And that's probably a good thing in many cases. In most cases we should avoid messing with content on other windows. In this case, and for `wm_test_opengl_deprecation_warning`, this problem just goes away if we just show these warnings on the main window and not a child. That is the intent anyway, that these be prominent warnings on the main window. It is just an unintended bug that these show on the wrong window in the above circumstances. With that corrected this error can't occur.

Harley Acheson referenced a pull request that will close this issue

2024-03-05 21:14:38 +01:00

Fix #118765: Show Startup Popup Warning on Main Window #119096

Harley Acheson referenced this issue from a commit

2024-03-05 21:16:46 +01:00

Fix #118765: Show Startup Popup Warning on Main Window

Harley Acheson closed this issue

2024-03-05 21:16:49 +01:00

Blender Bot added

Status

Resolved

and removed