Proposal: add a view transform for Khronos PBR Neutral Tone Mapper #118824

Closed
opened 2024-02-27 23:29:23 +01:00 by Emmett-Lalish · 6 comments
Contributor

@JulienDuroure recommended I submit a PR (I already have a working modified OCIO config), but I only seem to have permission to file an issue so far - and I'm likewise lacking some permissions on devtalk. Please let me know if there's a more appropriate forum for this discussion. FYI @brecht and @sergey, since I see your names under color management.

I developed a new tone mapping function, on behalf of Khronos, specifically to address the color accuracy needs of 3D e-commerce: getting PBR base colors to show through faithfully in the output render under grayscale lighting, without saturation loss, hue skews, or visual artifacts. It now has the official name Khronos PBR Neutral Tone Mapper, or PBR Neutral for short. For details, please see my writeup.

This is in no way a competitor to AgX or other filmic tone mappers; think of it instead as an improvement for anyone who currently disables tone mapping, what I believe is referred to as the Standard view transform in Blender. The addition of a PBR Neutral view transform would allow artists to easily see their PBR models in a color-neutral way without blown-out highlights, that can exactly match common end-point renderers that have adopted this new standard, e.g. Three.js and Filament.

Thank you for your consideration!

@JulienDuroure recommended I submit a PR (I already have a working modified [OCIO config](https://modelviewer.dev/examples/tone-mapping#ocio)), but I only seem to have permission to file an issue so far - and I'm likewise lacking some permissions on devtalk. Please let me know if there's a more appropriate forum for this discussion. FYI @brecht and @sergey, since I see your names under color management. I developed a new tone mapping function, on behalf of Khronos, specifically to address the color accuracy needs of 3D e-commerce: getting PBR base colors to show through faithfully in the output render under grayscale lighting, without saturation loss, hue skews, or visual artifacts. It now has the official name Khronos PBR Neutral Tone Mapper, or PBR Neutral for short. For details, please see my [writeup](https://modelviewer.dev/examples/tone-mapping). This is in no way a competitor to AgX or other filmic tone mappers; think of it instead as an improvement for anyone who currently disables tone mapping, what I believe is referred to as the Standard view transform in Blender. The addition of a PBR Neutral view transform would allow artists to easily see their PBR models in a color-neutral way without blown-out highlights, that can exactly match common end-point renderers that have adopted this new standard, e.g. [Three.js](https://github.com/mrdoob/three.js/pull/27668) and [Filament](https://github.com/google/filament/pull/7597). Thank you for your consideration!
Emmett-Lalish added the
Type
To Do
label 2024-02-27 23:29:23 +01:00
Iliya Katushenock added this to the Video Sequencer project 2024-02-28 06:42:01 +01:00

recommended I submit a PR ... but I only seem to have permission to file an issue so far

Hi, please, follow this instructions: https://developer.blender.org/docs/handbook/contributing/

> recommended I submit a PR ... but I only seem to have permission to file an issue so far Hi, please, follow this instructions: https://developer.blender.org/docs/handbook/contributing/

@Emmett-Lalish That is a very nice write-up! I still only quickly skimmed through it though. I did some quick tests, and the mapper does produce interesting and more neutral results. Think it would be very nice to give it a push forward and move it to an actual PR, as it will simplify review and tests.

It would also be very nice to make the LUT reproducible. I see the CommerceToneMapping in the article, is it what you used to generate pbrNeutral.cube ? Is there some handy easy-ish-to-use script for it? :)

@Emmett-Lalish That is a very nice write-up! I still only quickly skimmed through it though. I did some quick tests, and the mapper does produce interesting and more neutral results. Think it would be very nice to give it a push forward and move it to an actual PR, as it will simplify review and tests. It would also be very nice to make the LUT reproducible. I see the `CommerceToneMapping` in the article, is it what you used to generate `pbrNeutral.cube` ? Is there some handy easy-ish-to-use script for it? :)

I've bumped your trust level on devtalk.

Creating a fork and pull request should be possible with these steps:
https://developer.blender.org/docs/handbook/contributing/pull_requests/

I've bumped your trust level on devtalk. Creating a fork and pull request should be possible with these steps: https://developer.blender.org/docs/handbook/contributing/pull_requests/
Author
Contributor

Thanks all! I'll go ahead and start a devtalk thread and a PR. @Sergey, yes the LUT is reproducible; simply run this script.

Thanks all! I'll go ahead and start a devtalk thread and a PR. @Sergey, yes the LUT is reproducible; simply run this [script](https://github.com/google/model-viewer/blob/master/packages/modelviewer.dev/examples/lut-writer.mjs).

@Emmett-Lalish Ah, lovely! Looking forward PR from you!

@Emmett-Lalish Ah, lovely! Looking forward PR from you!
Author
Contributor

Done! Please let me know if there's anywhere I should put or reference my LUT generation script. Likewise please point me to any documentation you'd like to see updated (does that happen in the same PR, or is that a different repo?).

Done! Please let me know if there's anywhere I should put or reference my LUT generation script. Likewise please point me to any documentation you'd like to see updated (does that happen in the same PR, or is that a different repo?).
Blender Bot added the
Status
Resolved
label 2024-03-18 12:18:26 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#118824
No description provided.