pinned armature bone collection panel grayed out #119402

New Issue

moe-derky · 2024-03-13T00:02:04+01:00

moe-derky commented

2024-03-13 00:02:04 +01:00

System Information
Operating system: windows 11
Graphics card: RTX 4070

Blender Version
Broken: in 4.1 beta
Worked: in 4.0 and below
Short description of error
when an armature properties tab (object or data) gets pinned. the bone collection panel behaves normally until another object is selected like in the images below.
Exact steps for others to reproduce the error
-create an armature
-pin its properties
-select another object

**System Information** Operating system: windows 11 Graphics card: RTX 4070 **Blender Version** Broken: in 4.1 beta Worked: in 4.0 and below **Short description of error** when an armature properties tab (object or data) gets pinned. the bone collection panel behaves normally until another object is selected like in the images below. **Exact steps for others to reproduce the error** -create an armature -pin its properties -select another object

Screenshot 2024-03-13 014851.png

34 KiB

Screenshot 2024-03-13 014826.png

75 KiB

moe-derky added the

labels 2024-03-13 00:02:05 +01:00

Pratik Borhade commented

2024-03-13 06:37:26 +01:00

Hi, thanks for the report. Can confirm. This is related to new tree-view structure. GPv3 layers panel also giving same results.
cc @JulianEisel @dr.sybren

Hi, thanks for the report. Can confirm. This is related to new tree-view structure. GPv3 layers panel also giving same results. cc @JulianEisel @dr.sybren

Pratik Borhade added

and removed

labels 2024-03-13 06:37:55 +01:00

Pratik Borhade commented

2024-03-13 06:38:29 +01:00

This is not a regression but breaks the use of Pin property so raising the priority for attention.

This is not a regression but breaks the use of `Pin` property so raising the priority for attention.

Pratik Borhade commented

2024-03-13 07:42:19 +01:00

If active object is not armature then panel and bone collection rows are not drawn. I'm not sure what would be the replacement of CTX_data_active_object. Can we get object data from pinid?

If active object is not `armature` then panel and bone collection rows are not drawn. I'm not sure what would be the replacement of `CTX_data_active_object`. Can we get object data from pinid?

Pratik Borhade commented

2024-03-13 09:37:36 +01:00

I thought following change might work but it's not:

diff --git a/source/blender/editors/interface/interface_template_grease_pencil_layer_tree.cc b/source/blender/editors/interface/interface_template_grease_pencil_layer_tree.cc
index d4acbd2c305..3f7cbe98abd 100644
--- a/source/blender/editors/interface/interface_template_grease_pencil_layer_tree.cc
+++ b/source/blender/editors/interface/interface_template_grease_pencil_layer_tree.cc
@@ -16,6 +16,7 @@
 #include "UI_interface.hh"
 #include "UI_tree_view.hh"

+#include "DNA_space_types.h"
 #include "RNA_access.hh"
 #include "RNA_prototypes.h"

@@ -397,9 +398,16 @@ void LayerTreeView::build_tree()
 void uiTemplateGreasePencilLayerTree(uiLayout *layout, bContext *C)
 {
   using namespace blender;
-
+  ScrArea *area = CTX_wm_area(C);
   Object *object = CTX_data_active_object(C);
   if (!object || object->type != OB_GREASE_PENCIL) {
+    if (area->spacetype == SPACE_PROPERTIES) {
+      SpaceProperties *sbuts = static_cast<SpaceProperties *>(area->spacedata.first);
+      object = reinterpret_cast<Object *>(sbuts->pinid);
+    }
+  }
+
+  if (object->type != OB_GREASE_PENCIL) {
     return;
   }

I thought following change might work but it's not: ``` diff --git a/source/blender/editors/interface/interface_template_grease_pencil_layer_tree.cc b/source/blender/editors/interface/interface_template_grease_pencil_layer_tree.cc index d4acbd2c305..3f7cbe98abd 100644 --- a/source/blender/editors/interface/interface_template_grease_pencil_layer_tree.cc +++ b/source/blender/editors/interface/interface_template_grease_pencil_layer_tree.cc @@ -16,6 +16,7 @@ #include "UI_interface.hh" #include "UI_tree_view.hh" +#include "DNA_space_types.h" #include "RNA_access.hh" #include "RNA_prototypes.h" @@ -397,9 +398,16 @@ void LayerTreeView::build_tree() void uiTemplateGreasePencilLayerTree(uiLayout *layout, bContext *C) { using namespace blender; - + ScrArea *area = CTX_wm_area(C); Object *object = CTX_data_active_object(C); if (!object || object->type != OB_GREASE_PENCIL) { + if (area->spacetype == SPACE_PROPERTIES) { + SpaceProperties *sbuts = static_cast<SpaceProperties *>(area->spacedata.first); + object = reinterpret_cast<Object *>(sbuts->pinid); + } + } + + if (object->type != OB_GREASE_PENCIL) { return; } ```

Brecht Van Lommel commented

2024-03-13 12:45:33 +01:00

The template should take an object argument, not get it from the context.

In general, API functions should rely on context as little as possible. It makes their behavior unpredictable and leads to these kinds of subtle mismatches.

The template should take an object argument, not get it from the context. In general, API functions should rely on context as little as possible. It makes their behavior unpredictable and leads to these kinds of subtle mismatches.

Brecht Van Lommel commented

2024-03-13 15:57:39 +01:00

For 4.1 it's not ideal to change the API at this point though, so it could just use ED_object_active_context instead of CTX_data_active_object. The same is done in for example the modifiers template.

For 4.1 it's not ideal to change the API at this point though, so it could just use `ED_object_active_context` instead of `CTX_data_active_object`. The same is done in for example the modifiers template.

Brecht Van Lommel referenced a pull request that will close this issue

2024-03-13 18:02:17 +01:00

Fix #119402: Bone collections layers fail with pinned object or armature #119434

Hans Goudey added

and removed

labels 2024-03-13 18:09:32 +01:00

Sybren A. Stüvel self-assigned this 2024-03-19 15:07:44 +01:00

Sybren A. Stüvel added this to the 4.1 milestone 2024-03-19 15:07:47 +01:00