Auto Smooth versioning modifiers appearing on Append #119447

New Issue

Demeter Dzadik · 2024-03-14T03:16:32+01:00

Demeter Dzadik commented

2024-03-14 03:16:32 +01:00

Blender Version
Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-03-12 22:12, hash: 443ea628c5c8
Worked: I think this wasn't happening on the previous buildbot 4.2 build, so, the one from 13 March.

Short description of error
Some objects of our character keeps getting new Auto Smooth modifiers added to it whenever they are appended to another file.

Exact steps for others to reproduce the error

File: have_you_heard_of_our_lord_and_savior_auto_smooth.blend
The file was opened and saved with latest Blender, although these objects were originally created before the Auto Smooth changes.
Append or copy paste the objects to another file.
Auto Smooth modifiers appear, as if the objects came from a version of blender pre-auto smooth rework.

This is currently breaking our pipeline so an urgent fix would be nice.

**Blender Version** Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-03-12 22:12, hash: `443ea628c5c8` Worked: I think this wasn't happening on the previous buildbot 4.2 build, so, the one from 13 March. **Short description of error** Some objects of our character keeps getting new Auto Smooth modifiers added to it whenever they are appended to another file. **Exact steps for others to reproduce the error** - File: [have_you_heard_of_our_lord_and_savior_auto_smooth.blend](/attachments/6614f26e-a4eb-489d-8d9a-752894849c03) - The file was opened and saved with latest Blender, although these objects were originally created before the Auto Smooth changes. - Append or copy paste the objects to another file. - Auto Smooth modifiers appear, as if the objects came from a version of blender pre-auto smooth rework. This is currently breaking our pipeline so an urgent fix would be nice.

have_you_heard_of_our_lord_and_savior_auto_smooth.blend

11 MiB

Demeter Dzadik added the

labels 2024-03-14 03:16:33 +01:00

Demeter Dzadik referenced this issue from a commit

2024-03-14 03:18:19 +01:00

Asset Pipeline: Add an assert that's triggered by shennanigans.

Pratik Borhade commented

2024-03-14 04:13:14 +01:00

Hi, auto smooth versioning code for link/append is added in 3c3f1e6d62

Hi, auto smooth versioning code for link/append is added in 3c3f1e6d62e2dadb9cc3aa230033647d441b0a7b

Hans Goudey self-assigned this 2024-03-14 04:15:54 +01:00

Hans Goudey commented

2024-03-14 04:16:52 +01:00

I'll work on this tomorrow morning. If someone else gets to it first that's okay though of course.

Pratik Borhade added

and removed

labels 2024-03-14 04:25:19 +01:00

Pratik Borhade commented

2024-03-14 05:45:43 +01:00

I'll check. I think we can get the library file version from lapp_context then skip the versioning if > 400

Pratik Borhade referenced a pull request that will close this issue

2024-03-14 06:27:08 +01:00

Fix #119447: Auto Smooth versioning modifiers appearing on Append #119449

Pratik Borhade commented

2024-03-14 06:41:49 +01:00

I'm not sure how this situation has occurred. AFAICS, we're already clearing ME_AUTOSMOOTH_LEGACY flag from the mesh when file with old autosmooth is loaded and saved in 4.1/4.2.

If I open your file in 4.0 then auto smooth toggle is enabled. Maybe !119449 is not required

I'm not sure how this situation has occurred. AFAICS, we're already clearing `ME_AUTOSMOOTH_LEGACY` flag from the mesh when file with `old autosmooth` is loaded and saved in 4.1/4.2. If I open your file in 4.0 then `auto smooth` toggle is enabled. Maybe !119449 is not required

~~Hans Goudey referenced this issue 2024-03-14 15:44:34 +01:00~~

Fix #119455: Auto smooth versioning on append applies to existing IDs #119467

Bastien Montagne commented

2024-03-14 15:48:48 +01:00

@Mets do you have the version of this file before opening & saving in recent Blender? What we need to understand here is why the conversion of these meshes from legacy auto-smooth to modifier did not happen...

To be clear, given current state of data, the behavior of the append code is correct and totally expected.

@Mets do you have the version of this file before opening & saving in recent Blender? What we need to understand here is why the conversion of these meshes from legacy auto-smooth to modifier did not happen... To be clear, given current state of data, the behavior of the append code is correct and totally expected.

Demeter Dzadik commented

2024-03-14 16:38:14 +01:00

Yep, I have versions going back to Nov 17, each version being saved with some blender version that was latest nightly build at that time.
But for the life of me I can't find the date of the original autosmooth versioning commit, and its date... ;_; plz help

Yep, I have versions going back to Nov 17, each version being saved with some blender version that was latest nightly build at that time. But for the life of me I can't find the date of the original autosmooth versioning commit, and its date... ;_; plz help

Hans Goudey commented

2024-03-14 16:45:37 +01:00

89e3ba4e25 was the original commit introducing the versioning (October 20)
b0cb58ca0e fixed the versioning to clear the auto smooth setting from versioned objects (November 26)

If the versioning to 4.1 happened between those two commits, the new modifier wouldn't have been added but the old "hidden" auto smooth flag would still be set. That's how we would have got into this situation.

I still think it's better to be safe and not process existing objects like is done in #119467.

- 89e3ba4e25c9ff921b2584c294cbc38c3d344c34 was the original commit introducing the versioning (October 20) - b0cb58ca0e7ba925ab22355e140064965213d2e1 fixed the versioning to clear the auto smooth setting from versioned objects (November 26) If the versioning to 4.1 happened between those two commits, the new modifier wouldn't have been added but the old "hidden" auto smooth flag would still be set. That's how we would have got into this situation. I still think it's better to be safe and not process existing objects like is done in #119467.

Bastien Montagne commented

2024-03-15 04:11:21 +01:00

Let's use this task as central info point?

Known issues so far

Some Mesh IDs may still have their AUTOSMOOTH flag set, even though some of the Object IDs using them may have been converted and already have the expected modifier instead.
There are at least two ways to reach this situation: some in-dev versions of Blender would not clear the autosmooth flag after conversion, and some objects using linked meshes from other library.
In case of a mesh being used by more than one object, only the first object using it will get the new modifier at conversion.
In link/append case, the code will add a new nodetree every time a new link/append operation is performed on data that needs conversion.
NodeTree is always created as local data, so linked objects will end up using a local nodetree for their new modifier. This is likely the worst issue currently in term of sanity and consistency of the whole data-base.

Proposed solutions

#2 is trivial to fix (see !119471), but imho the best way to address it is to systematically clear the AUTOSMOOTH flag on all meshes after running conversion. This will also solve (most of) #1 issues (some linking-related scenarii are not solvable at all imho, but think they are rare enough in practice, that we can accept the 'loss of autosmooth data' for them).

#3 IMHO should not be too hard to solve? Code could simply lookup in existing nodetrees one that would match (based on name, or whast is in the node tree, and its library), before creating a new one?

#4 is (relatively) trivial to fix now in main, using the new BKE_id_new_in_lib functions. In 4.1, I can only think of creating a local nodetree, assigning the library to it, and re-running the uniquename/sorting code (BKE_id_new_name_validate) on it to ensure it ends up where it should and does have a unique name in the library namespace.

Let's use this task as central info point? ### Known issues so far 1. Some Mesh IDs may still have their `AUTOSMOOTH` flag set, even though some of the Object IDs using them may have been converted and already have the expected modifier instead. _There are at least two ways to reach this situation: some in-dev versions of Blender would not clear the autosmooth flag after conversion, and some objects using linked meshes from other library._ 2. In case of a mesh being used by more than one object, only the first object using it will get the new modifier at conversion. 3. In link/append case, the code will add a new nodetree every time a new link/append operation is performed on data that needs conversion. 4. NodeTree is always created as local data, so linked objects will end up using a local nodetree for their new modifier. This is likely the worst issue currently in term of sanity and consistency of the whole data-base. ### Proposed solutions #2 is trivial to fix (see !119471), but imho the best way to address it is to systematically clear the `AUTOSMOOTH` flag on all meshes after running conversion. This will also solve (most of) #1 issues (_some linking-related scenarii are not solvable at all imho, but think they are rare enough in practice, that we can accept the 'loss of autosmooth data' for them_). #3 IMHO should not be _too_ hard to solve? Code could simply lookup in existing nodetrees one that would match (based on name, or whast is in the node tree, and its library), before creating a new one? #4 is (relatively) trivial to fix now in `main`, using the new `BKE_id_new_in_lib` functions. In 4.1, I can only think of creating a local nodetree, assigning the library to it, and re-running the uniquename/sorting code (`BKE_id_new_name_validate`) on it to ensure it ends up where it should and does have a unique name in the library namespace.

👍 1

Hans Goudey commented

2024-03-15 04:51:37 +01:00

Thanks so much for writing that all down. I agree with your points and it sounds like a good plan. I'll work on implementing this tomorrow morning.

👍 1

Hans Goudey referenced this issue

2024-03-15 17:45:44 +01:00

Fix #119455: Auto smooth versioning on append applies to existing IDs #119467

Hans Goudey referenced this issue

2024-03-15 21:07:44 +01:00

Fix: Various issues with auto smooth versioning #119539

Hans Goudey referenced this issue from a commit

2024-03-18 20:15:46 +01:00

Fix: Various issues with auto smooth versioning

Hans Goudey commented

2024-03-18 21:46:34 +01:00

5bfe6ad8f8

5bfe6ad8f8ce5b6b7fcfdaa011ff1e9d7c75f429

Hans Goudey closed this issue

2024-03-18 21:46:38 +01:00

Hans Goudey commented

2024-03-18 21:47:48 +01:00

Just to clarify, in this case the modifier will be added again to these objects since the flag wasn't cleared properly by the initial versioning and the modifiers were removed in the meantime. After that everything should work properly though.

Blender Bot added

and removed

labels 2024-03-18 21:47:52 +01:00

Sign in to join this conversation.