VSE: HDR support in preview regions #119462

New Issue

Sergey Sharybin · 2024-03-14T14:31:55+01:00

Sergey Sharybin commented

2024-03-14 14:31:55 +01:00

The preview regions of video sequencer do not support HDR display, forcing the content to be clipped despite the state of the High Dynamic Range option in the scene's color management settings. These regions are to follow the same rules w.r.t HDR as Render Result in the Image Editor or Compositor backdrop.

Part of the reason why it is happening is because the image buffer is rendered to an overlay framebuffer (sequencer_draw_preview() which uses GPU_viewport_framebuffer_overlay_get()) which is backed up by GPU_SRGB8_A8 texture, which causes clipping.

The reason for such render choice is because it makes it easy to render image buffer, which could be in a display space, even if it is a float buffer.

One immediate idea could be to render the sequencer preview to viewport's color_render_tx (which would require having framebuffer for it, similar to GPU_viewport_framebuffer_overlay_get, but GPU_viewport_framebuffer_render_get). However, it is not immediately clear how to deal with image buffers whose data is not in the linear space.

Attached an HDR EXR image and the scene which uses it. The goal is to make the preview region to give the same look as F12 render.

The preview regions of video sequencer do not support HDR display, forcing the content to be clipped despite the state of the `High Dynamic Range` option in the scene's color management settings. These regions are to follow the same rules w.r.t HDR as Render Result in the Image Editor or Compositor backdrop. Part of the reason why it is happening is because the image buffer is rendered to an overlay framebuffer (`sequencer_draw_preview()` which uses `GPU_viewport_framebuffer_overlay_get()`) which is backed up by `GPU_SRGB8_A8` texture, which causes clipping. The reason for such render choice is because it makes it easy to render image buffer, which could be in a display space, even if it is a float buffer. One immediate idea could be to render the sequencer preview to viewport's `color_render_tx` (which would require having framebuffer for it, similar to `GPU_viewport_framebuffer_overlay_get`, but `GPU_viewport_framebuffer_render_get`). However, it is not immediately clear how to deal with image buffers whose data is not in the linear space. Attached an HDR EXR image and the scene which uses it. The goal is to make the preview region to give the same look as F12 render.

vse_hdr.blend

668 KiB

hdr.exr

20 MiB

👍 2 🎉 2

Sergey Sharybin added the

Type

To Do

label 2024-03-14 14:31:55 +01:00

Sergey Sharybin added this to the Video Sequencer project 2024-03-14 14:31:58 +01:00

Jeroen Bakker commented

2024-03-14 14:48:05 +01:00

The draw manager recreates the frame buffers based on the textures.
See DRW_view_data_default_lists_from_viewport. But I think we should add the GPU_viewport_framebuffer_render_get as that is easier tobe reused across multiple redraws

The draw manager recreates the frame buffers based on the textures. See `DRW_view_data_default_lists_from_viewport`. But I think we should add the `GPU_viewport_framebuffer_render_get` as that is easier tobe reused across multiple redraws

Aras Pranckevicius self-assigned this 2024-04-24 12:34:15 +02:00

Aras Pranckevicius commented

2024-04-24 12:34:33 +02:00

I can try to make this happen. Perhaps because I don't know yet how deep the rabbit hole goes :)

🎉 2

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

VSE: HDR support in preview regions #119462