Compositor: expose interpolation method for transform nodes #119592

Open
opened 2024-03-17 14:26:11 +01:00 by Habib Gahbiche · 6 comments
Member

The goal is to expose the interpolation parameter (Nearest, Bilinear or Bicubic) to user for the following nodes:

  • Transform (currently only available for rotation)
  • Translate (#119603)
  • Scale
  • Displace
  • Corner pin
  • Lens distortion

UI should be similar to the transform node, so simply add dropdown menu with available interpolation methods:
Transform

The goal is to expose the interpolation parameter (Nearest, Bilinear or Bicubic) to user for the following nodes: - Transform (currently only available for rotation) - Translate (https://projects.blender.org/blender/blender/pulls/119603) - Scale - Displace - Corner pin - Lens distortion UI should be similar to the transform node, so simply add dropdown menu with available interpolation methods: <img src="/attachments/1e0e8211-b7a9-432b-bc25-6e6b4fe26bcb" alt="Transform" width="200"/>
Habib Gahbiche added the
Type
To Do
label 2024-03-17 14:26:11 +01:00
Habib Gahbiche added this to the Compositing project 2024-03-17 14:28:43 +01:00
Habib Gahbiche self-assigned this 2024-03-23 14:56:27 +01:00
Habib Gahbiche added the
Meta
Good First Issue
label 2024-03-24 12:10:51 +01:00
Habib Gahbiche removed their assignment 2024-03-24 12:11:12 +01:00

I'd like to claim this as my first issue!

I'd like to claim this as my first issue!
Author
Member

@Noah-Pinales Good to know! I think once #119603 is merged, the rest should be more straightforward. But you can assume that read_elem_sampled() is implemented correctly so that you can start :)

@Noah-Pinales Good to know! I think once #119603 is merged, the rest should be more straightforward. But you can assume that `read_elem_sampled()` is implemented correctly so that you can start :)

@zazizizou I've gotten it working with the Scale node, should I create individual pull requests for each node or one pull request for all nodes? I plan to tackle the other nodes tomorrow, now that I understand what exactly needs changing for this feature.

@zazizizou I've gotten it working with the Scale node, should I create individual pull requests for each node or one pull request for all nodes? I plan to tackle the other nodes tomorrow, now that I understand what exactly needs changing for this feature.

I've created a pull request for the Scale node, #119902

I've created a pull request for the Scale node, #119902

Created another pull request, this time for the Displace node, #119908

Both of these are labelled as WIP for now, as I would like to wait for #119603 to be merged, so I can utilize any feedback that request gets in my own pull requests. In addition to this, I would like to utilize the CMPNodeInterpolation added there, instead of using hard-coded integers.

Created another pull request, this time for the Displace node, #119908 Both of these are labelled as WIP for now, as I would like to wait for #119603 to be merged, so I can utilize any feedback that request gets in my own pull requests. In addition to this, I would like to utilize the `CMPNodeInterpolation` added there, instead of using hard-coded integers.

Hello,

I'm looking for my first issue, is it possible to help on this one ? May be on Corner Pin node or Lens Distortion ?

Hello, I'm looking for my first issue, is it possible to help on this one ? May be on Corner Pin node or Lens Distortion ?
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#119592
No description provided.