Colorramp elements are not updated when changed via layout.prop() #119648

New Issue

Open

opened 2024-03-19 07:25:10 +01:00 by ugorek · 6 comments

ugorek commented

2024-03-19 07:25:10 +01:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1650/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 546.33

Blender Version
Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-03-16 19:16, hash: 6768ded89586
Worked: never?

Short description of error
An element's position changed using a property via api does not update the order of elements.

Exact steps for others to reproduce the error

Copy script and run.
Use the new panel to change position.

import bpy

class Panel(bpy.types.Panel):
    bl_idname = 'Panel_PT_Panel'
    bl_label = "Panel"
    bl_space_type = 'NODE_EDITOR'
    bl_region_type = 'UI'
    def draw(self, context):
        col = self.layout.column(align=True)
        tree = context.space_data.edit_tree
        aNd = tree.nodes.active
        if aNd:
            if aNd.type=='VALTORGB':
                for el in aNd.color_ramp.elements:
                    row = col.row(align=True)
                    row.prop(el,'color', text="")
                    row.prop(el,'position', text="")
            else:
                col.label(text=aNd.bl_idname)

bpy.utils.register_class(Panel)

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1650/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 546.33 **Blender Version** Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-03-16 19:16, hash: `6768ded89586` Worked: never? **Short description of error** An element's position changed using a property via api does not update the order of elements. ![2024-03-19_13.17.44.gif](/attachments/6b517132-7803-43b6-9036-e6b130c289a7) **Exact steps for others to reproduce the error** 1. Copy script and run. 2. Use the new panel to change position. ``` import bpy class Panel(bpy.types.Panel): bl_idname = 'Panel_PT_Panel' bl_label = "Panel" bl_space_type = 'NODE_EDITOR' bl_region_type = 'UI' def draw(self, context): col = self.layout.column(align=True) tree = context.space_data.edit_tree aNd = tree.nodes.active if aNd: if aNd.type=='VALTORGB': for el in aNd.color_ramp.elements: row = col.row(align=True) row.prop(el,'color', text="") row.prop(el,'position', text="") else: col.label(text=aNd.bl_idname) bpy.utils.register_class(Panel) ```

2024-03-19_13.17.44.gif

989 KiB

ugorek added the

labels 2024-03-19 07:25:11 +01:00

Philipp Oeser commented

2024-03-19 11:16:45 +01:00

Member

Can confirm, will have a quick look

Can confirm, will have a quick look

Philipp Oeser added

Nodes & Physics

and removed

labels 2024-03-19 11:17:16 +01:00

Philipp Oeser commented

2024-03-19 11:37:38 +01:00

Member

Hm, not sure if there is a nice way to solve this.

In code, colorband_update_cb switches button pointers around when going across another stop.
You can also see this in your gif (color stops changing order there, going up and down).

Sorting could take place I assume (using BKE_colorband_update_sort), not sure though how the buttons would correctly update in the panel (meaning the currently dragged slider would need to change order, too... sounds hairy...)

Hm, not sure if there is a nice way to solve this. In code, `colorband_update_cb` switches button pointers around when going across another stop. You can also see this in your gif (color stops changing order there, going up and down). Sorting could take place I assume (using `BKE_colorband_update_sort`), not sure though how the buttons would correctly update in the panel (meaning the currently dragged slider would need to change order, too... sounds hairy...)

Shubham Daule commented

2024-03-19 12:18:32 +01:00

Hi, I am new to blender development. I can reproduce this issue, and would like to work on it. This issue looks easy enough to be a Good First Issue. Can I proceed with this issue?

Hi, I am new to blender development. I can reproduce this issue, and would like to work on it. This issue looks easy enough to be a Good First Issue. Can I proceed with this issue?

Philipp Oeser commented

2024-03-19 13:42:40 +01:00

Member

Not really sure if this is a good first issue (due to my comments above), but of course, you could give it a try

The thing would have to be done in rna_ColorRamp_update

Not really sure if this is a good first issue (due to my comments above), but of course, you could give it a try The thing would have to be done in `rna_ColorRamp_update`

ugorek commented

2024-03-19 16:32:55 +01:00

Author

P. s.

I thought that if I changed the position "explicitly" through the api, the order would be updated, but this did not happen.

import functools

def Timer(nd):
    nd.color_ramp.elements[0].position = nd.color_ramp.elements[0].position

class Panel(bpy.types.Panel):
    ...
    def draw(self, context):
        ...
        bpy.app.timers.register(functools.partial(Timer, aNd))

P. p.s.

meaning the currently dragged slider would need to change order, too...

Personally, I had no problems when the changeable slider moved to a new place. I used this for my sorting needs, and it’s very comfortable.

P. s. I thought that if I changed the position "explicitly" through the api, the order would be updated, but this did not happen. ```py import functools def Timer(nd): nd.color_ramp.elements[0].position = nd.color_ramp.elements[0].position class Panel(bpy.types.Panel): ... def draw(self, context): ... bpy.app.timers.register(functools.partial(Timer, aNd)) ``` P. p.s. > meaning the currently dragged slider would need to change order, too... Personally, I had no problems when the changeable slider moved to a new place. I used this for my sorting needs, and it’s very comfortable. ![2023-11-17_04.38.12.gif](/attachments/9d5f410b-acf3-4abe-ba1b-65d017c91f0f)

2023-11-17_04.38.12.gif

391 KiB

Shubham Daule commented

2024-03-19 19:02:45 +01:00

Not really sure if this is a good first issue (due to my comments above), but of course, you could give it a try

The thing would have to be done in rna_ColorRamp_update

I didn't saw your comment as I didn't refresh the page. Though I would like to give this a try any ways. Thanks for the reference.

> Not really sure if this is a good first issue (due to my comments above), but of course, you could give it a try > > The thing would have to be done in `rna_ColorRamp_update` I didn't saw your comment as I didn't refresh the page. Though I would like to give this a try any ways. Thanks for the reference.

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#119648

No description provided.