GPv3 Build modifier cyclical strokes weird behaviour with first few points #119714

New Issue

Aleš Jelovčan · 2024-03-20T19:22:19+01:00

Aleš Jelovčan commented

2024-03-20 19:22:19 +01:00

System Information
Operating system: Windows-10-10.0.22631-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 4090 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 537.32

Blender Version
Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-03-20 14:19, hash: 6d3ac72a290d
Worked: /

Short description of error
Cyclical strokes produce some weird results with only a few points drawn

Exact steps for others to reproduce the error
Add cyclical stroke (in GPv2 use circle tool and then convert)
Add build modifier and check frames 1-3 with initial values

**System Information** Operating system: Windows-10-10.0.22631-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 4090 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 537.32 **Blender Version** Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-03-20 14:19, hash: `6d3ac72a290d` Worked: / **Short description of error** Cyclical strokes produce some weird results with only a few points drawn ![image](/attachments/904f4dc2-46ef-4a4b-bdb1-965537394d2f) **Exact steps for others to reproduce the error** Add cyclical stroke (in GPv2 use circle tool and then convert) Add build modifier and check frames 1-3 with initial values

image.png

164 KiB

build_cyclic.blend

1.0 MiB

Aleš Jelovčan added the

labels 2024-03-20 19:22:20 +01:00

YimingWu was assigned by Aleš Jelovčan

2024-03-20 19:22:20 +01:00

Pratik Borhade commented

2024-03-21 06:42:10 +01:00

Thanks for the report. Can confirm.

Pratik Borhade added

and removed

labels 2024-03-21 06:42:22 +01:00

YimingWu commented

2024-03-21 07:52:16 +01:00

It seems to be a drawing issue. I tried to print out positions and other attributes and it was correct.

But if I manually construct a 1/2 point cyclic stroke, it will not show this artefact. So something must be going on here.

It seems to be a drawing issue. I tried to print out positions and other attributes and it was correct. But if I manually construct a 1/2 point cyclic stroke, it will not show this artefact. So something must be going on here.

YimingWu commented

2024-03-21 08:05:20 +01:00

Looks like cyclic stroke drawing is only handled with if (is_cyclic && points.size() >= 3) { (in source/blender/draw/intern/draw_cache_impl_grease_pencil.cc line 626), this would indeed cause such artefact. Let me try make a PR to fix it. Apparently the check for points.size() >= 3 is not needed here.

Looks like cyclic stroke drawing is only handled with `if (is_cyclic && points.size() >= 3) {` (in `source/blender/draw/intern/draw_cache_impl_grease_pencil.cc` line 626), this would indeed cause such artefact. Let me try make a PR to fix it. Apparently the check for ` points.size() >= 3` is not needed here.

YimingWu referenced a pull request that will close this issue

2024-03-21 08:11:10 +01:00

Fix #119714: GPv3: Remove cyclic stroke point count limit #119727

YimingWu referenced this issue from a commit

2024-03-21 09:04:33 +01:00

Fix #119714: GPv3: Remove cyclic stroke point count limit

YimingWu closed this issue

2024-03-21 09:04:34 +01:00

Blender Bot added

Status

Resolved

and removed