Unable to copy Hook modifiers via API #119905

New Issue

Closed

opened 2024-03-26 06:30:59 +01:00 by Y.T-LAW · 2 comments

Y.T-LAW commented

2024-03-26 06:30:59 +01:00

System Information

Operating system: Windows-10-10.0.22631-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 551.61

Blender Version
Broken: version: 3.6.1, branch: blender-v3.6-release, commit date: 2023-07-17 12:50, hash: 8bda729ef4dc
Worked: (newest version of Blender that worked as expected)

Short description of error
[Please fill out a short description of the error here]

Exact steps for others to reproduce the error

Successfully copy the Boolean modifier according to the following script:

# Based on factory startup
import bpy

cube = bpy.data.objects["Cube"]
bpy.ops.mesh.primitive_plane_add()
plane = bpy.context.object

md = cube.modifiers.new("", "BOOLEAN")
with bpy.context.temp_override(object=cube, selected_objects=[plane]):
    bpy.ops.object.modifier_copy_to_selected(modifier=md.name)

But fails on Hook modifier

# Based on factory startup
import bpy

cube = bpy.data.objects["Cube"]
bpy.ops.mesh.primitive_plane_add()
plane = bpy.context.object

md = cube.modifiers.new("", "HOOK") # only changed here
with bpy.context.temp_override(object=cube, selected_objects=[plane]):
    bpy.ops.object.modifier_copy_to_selected(modifier=md.name)

I tested all 57 modifiers and 4 failed:

HOOK
MESH_TO_VOLUME
VOLUME_DISPLACE
COLLISION

**System Information** Operating system: Windows-10-10.0.22631-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2080 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 551.61 **Blender Version** Broken: version: 3.6.1, branch: blender-v3.6-release, commit date: 2023-07-17 12:50, hash: `8bda729ef4dc` Worked: (newest version of Blender that worked as expected) **Short description of error** [Please fill out a short description of the error here] **Exact steps for others to reproduce the error** Successfully copy the Boolean modifier according to the following script: ```Python # Based on factory startup import bpy cube = bpy.data.objects["Cube"] bpy.ops.mesh.primitive_plane_add() plane = bpy.context.object md = cube.modifiers.new("", "BOOLEAN") with bpy.context.temp_override(object=cube, selected_objects=[plane]): bpy.ops.object.modifier_copy_to_selected(modifier=md.name) ``` But fails on Hook modifier ```Python # Based on factory startup import bpy cube = bpy.data.objects["Cube"] bpy.ops.mesh.primitive_plane_add() plane = bpy.context.object md = cube.modifiers.new("", "HOOK") # only changed here with bpy.context.temp_override(object=cube, selected_objects=[plane]): bpy.ops.object.modifier_copy_to_selected(modifier=md.name) ``` I tested all 57 modifiers and 4 failed: ``` HOOK MESH_TO_VOLUME VOLUME_DISPLACE COLLISION ```

Y.T-LAW added the

labels 2024-03-26 06:31:00 +01:00

Iliya Katushenock added the

labels 2024-03-26 06:53:49 +01:00

Philipp Oeser commented

2024-03-26 12:45:58 +01:00

Member

Can confirm, will have a look...

Can confirm, will have a look...

Philipp Oeser added

and removed

labels 2024-03-26 12:46:07 +01:00

Philipp Oeser commented

2024-03-26 13:42:25 +01:00

Member

Checked code and BKE_object_copy_modifier / object_modifier_type_copy_check explicitly exclude eModifierType_Hook & eModifierType_Collision see d92a6f140d and bc95c249a7

Assumption here is that this was excluded due to the special data in those modifiers that have very little chance to be copied over to a "reasonable" state (e.g. Hook is storing index arrays of vertices which might make very little sense on a different mesh)

VOLUME_DISPLACE & MESH_TO_VOLUME would only make sense (and it works then) when both participating objects are actually volumes

So where does this leave us?
For the two (non-working) mesh modifiers: these are explicitly disabled in code (probably for good reasons). It might be possible to make these work in some situations, this would then be considered a request for improved behavior though (and not a bug).
For the two volume modifiers: these actually work (when used on volumes).

Afraid we have to close this then (but of course feel free to comment again if this is a misunderstanding or if issues persist).

Checked code and `BKE_object_copy_modifier` / `object_modifier_type_copy_check` explicitly exclude `eModifierType_Hook` & `eModifierType_Collision` see d92a6f140d0b and bc95c249a765 Assumption here is that this was excluded due to the special data in those modifiers that have very little chance to be copied over to a "reasonable" state (e.g. `Hook` is storing index arrays of vertices which might make very little sense on a different mesh) `VOLUME_DISPLACE` & `MESH_TO_VOLUME` would only make sense (and it works then) when both participating objects are actually volumes So where does this leave us? For the two (non-working) mesh modifiers: these are explicitly disabled in code (probably for good reasons). It might be possible to make these work in some situations, this would then be considered a request for improved behavior though (and not a bug). For the two volume modifiers: these actually work (when used on volumes). Afraid we have to close this then (but of course feel free to comment again if this is a misunderstanding or if issues persist).

Philipp Oeser closed this issue

2024-03-26 13:42:29 +01:00

Blender Bot added

and removed

labels 2024-03-26 13:43:56 +01:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#119905

No description provided.