Geometry Nodes: automatic connection doesn't work for Geometry if first input is Menu #119923

New Issue

Open

opened 2024-03-26 17:04:35 +01:00 by Nika Kutsniashvili · 7 comments

Nika Kutsniashvili commented

2024-03-26 17:04:35 +01:00

Contributor

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1650/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 551.23

Blender Version
Broken: version: 4.1.0 Release Candidate, branch: blender-v4.1-release, commit date: 2024-03-22 19:59, hash: 64bfe491645f
Worked: (newest version of Blender that worked as expected)

Short description of error
Hard to describe in words but video does a good job

Dropping node on a Geometry line doesn't automatically connect the input if Menu input is above geometry

Exact steps for others to reproduce the error

Create node group with Menu and Geometry inputs
Drop the group in between two geometry nodes, like Grid and Transform Geometry

**System Information** Operating system: Windows-10-10.0.19043-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1650/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 551.23 **Blender Version** Broken: version: 4.1.0 Release Candidate, branch: blender-v4.1-release, commit date: 2024-03-22 19:59, hash: `64bfe491645f` Worked: (newest version of Blender that worked as expected) **Short description of error** Hard to describe in words but video does a good job <video src="https://i.imgur.com/kvKVwLk.mp4" controls></video> Dropping node on a Geometry line doesn't automatically connect the input if Menu input is above geometry **Exact steps for others to reproduce the error** 1. Create node group with Menu and Geometry inputs 2. Drop the group in between two geometry nodes, like Grid and Transform Geometry

Nika Kutsniashvili added the

labels 2024-03-26 17:04:36 +01:00

Iliya Katushenock commented

2024-03-26 17:11:51 +01:00

Member

I think this kind issue there for any other types of sockets\

I think this kind issue there for any other types of sockets\

Iliya Katushenock added the

Nodes & Physics

labels 2024-03-26 17:11:58 +01:00

Germano Cavalcante commented

2024-03-26 19:40:00 +01:00

Member

I can confirm that auto Node Attachment does not connect compatible types if it has an input of the type Menu above.
Other non-Menu input types allow connection.

Attached a .blend file demonstrating the issue.

I can confirm that auto `Node Attachment` does not connect compatible types if it has an input of the type Menu above. Other non-Menu input types allow connection. Attached a .blend file demonstrating the issue.

node_attachment_menu__bug.blend

922 KiB

Germano Cavalcante added

Nodes & Physics

and removed

Nodes & Physics

labels 2024-03-26 19:40:22 +01:00

Pratik Borhade commented

2024-03-28 10:06:59 +01:00

Member

SOCK_MENU and SOCK_GEOMETRY has same priority 6. And hence wrong socket (menu) is returned to connect in existing link: https://projects.blender.org/blender/blender/src/branch/main/source/blender/editors/space_node/node_relationships.cc#L2276-L2281

`SOCK_MENU` and `SOCK_GEOMETRY` has same priority 6. And hence wrong socket (menu) is returned to connect in existing link: https://projects.blender.org/blender/blender/src/branch/main/source/blender/editors/space_node/node_relationships.cc#L2276-L2281

Pratik Borhade commented

2024-03-28 10:12:20 +01:00

Member

We can avoid this by replacing the existing logic of socket priority with e11d3073a9 (Did this during !116550)
@JacquesLucke hi, make sense to change this? Otherwise similar issues will keep happening :)

We can avoid this by replacing the existing logic of socket priority with e11d3073a902b5f375b7e1a4278be43ae9046d76 (Did this during !116550) @JacquesLucke hi, make sense to change this? Otherwise similar issues will keep happening :)

Jacques Lucke commented

2024-04-01 19:44:07 +02:00

Member

Something like this should work indeed. However, to make the fix less intrusive, it may be best to just filter out sockets that can't be linked instead of making the same socket type the highest priority. Also see bNodeTreeType::validate_link.

Something like this should work indeed. However, to make the fix less intrusive, it may be best to just filter out sockets that can't be linked instead of making the same socket type the highest priority. Also see `bNodeTreeType::validate_link`.

Pratik Borhade commented

2024-04-02 12:43:19 +02:00

Member

it may be best to just filter out sockets that can't be linked

I think this is already done (i.e. not generating link) in node_insert_on_link_flags once we get in/out sockets from get_main_socket.

> it may be best to just filter out sockets that can't be linked I think this is already done (i.e. not generating link) in `node_insert_on_link_flags` once we get in/out sockets from `get_main_socket`.

Jacques Lucke commented

2024-04-02 16:18:43 +02:00

Member

I see, maybe that check should just be moved into get_main_socket then?

I see, maybe that check should just be moved into `get_main_socket` then?

Pratik Borhade self-assigned this 2024-04-10 08:09:14 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

5 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#119923

No description provided.