Duplicate unused Face selection color #119953

New Issue

Ludvik Koutny · 2024-03-27T09:25:35+01:00

Ludvik Koutny commented

2024-03-27 09:25:35 +01:00

System Information
Operating system: Windows-10-10.0.22631-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 551.76

Blender Version
Broken: version: 4.1.0, branch: blender-v4.1-release, commit date: 2024-03-25 20:42, hash: 40a5e739e270
Worked: (newest version of Blender that worked as expected)

Short description of error
In Blender 4.1, new ThemeView3D.face_mode_select property was added instead of using existing ThemeView3D.face_select property. The ThemeView3D.face_select property is still present, but does not do anything anymore, aside from breaking existing themes by renaming the property but keeping the old unused one. Same issue applies to Edge Selection vs Edge Mode Selection.

Almost all of the non-default themes shipped with Blender are broken by this change too.

To add to the confusion, in UV Editor, this buggy behavior is inverted: ThemeImageEditor.face_select property is what affects the color of the selected faces, while ThemeImageEditor.face_mode_select property is also present, but does not control anything anywhere in the UI.

Exact steps for others to reproduce the error

Open Theme settings in User Preferences.
Navigate to 3D Viewport section.
Customize Face Selection color.

Result: The Face Selection color swatch does nothing. There is nothing in the entire UI affected by this color.
Expected: The Face Selection and Edge Selection color swatches get removed OR they get used to control something.

Open Theme settings in User Preferences.
Navigate to Image/UV Editor section.
Customize Face Mode Selection color.

Result: The Face Mode Selection color swatch does nothing. There is nothing in the entire UI affected by this color.
Expected: The Face Mode Selection swatch gets removed OR is used to control something.

**System Information** Operating system: Windows-10-10.0.22631-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 551.76 **Blender Version** Broken: version: 4.1.0, branch: blender-v4.1-release, commit date: 2024-03-25 20:42, hash: `40a5e739e270` Worked: (newest version of Blender that worked as expected) **Short description of error** In Blender 4.1, new ThemeView3D.face_mode_select property was added instead of using existing ThemeView3D.face_select property. The ThemeView3D.face_select property is still present, but does not do anything anymore, aside from breaking existing themes by renaming the property but keeping the old unused one. Same issue applies to Edge Selection vs Edge Mode Selection. Almost all of the non-default themes shipped with Blender are broken by this change too. To add to the confusion, in UV Editor, this buggy behavior is inverted: ThemeImageEditor.face_select property is what affects the color of the selected faces, while ThemeImageEditor.face_mode_select property is also present, but does not control anything anywhere in the UI. **Exact steps for others to reproduce the error** 1. Open Theme settings in User Preferences. 2. Navigate to 3D Viewport section. 3. Customize Face Selection color. Result: The Face Selection color swatch does nothing. There is nothing in the entire UI affected by this color. Expected: The Face Selection and Edge Selection color swatches get removed OR they get used to control something. ----------------------------- 1. Open Theme settings in User Preferences. 2. Navigate to Image/UV Editor section. 3. Customize Face Mode Selection color. Result: The Face Mode Selection color swatch does nothing. There is nothing in the entire UI affected by this color. Expected: The Face Mode Selection swatch gets removed OR is used to control something.

Ludvik Koutny added the

labels 2024-03-27 09:25:36 +01:00

Nika Kutsniashvili commented

2024-03-27 09:29:40 +01:00

Edge Selection and Face Selection are still in use, and they set color of the edge/face when you're not in Edge/Face selection. Edge Selection sets the color for edges when you're in Vertex and Face select modes, and Edge Mode Selection sets color for edges when you're in Edge selection mode.

Same applies to faces.

Edge Selection and Face Selection are still in use, and they set color of the edge/face when you're not in Edge/Face selection. Edge Selection sets the color for edges when you're in Vertex and Face select modes, and Edge Mode Selection sets color for edges when you're in Edge selection mode. Same applies to faces.

👍 1

Ludvik Koutny commented

2024-03-27 09:35:32 +01:00

Edge Selection and Face Selection are still in use, and they set color of the edge/face when you're not in Edge/Face selection. Edge Selection sets the color for edges when you're in Vertex and Face select modes, and Edge Mode Selection sets color for edges when you're in Edge selection mode.

Same applies to faces.

I probably spent more time on customizing Blender themes than anyone else since I wrote addon to simplify the process. If I can't figure this out, how do you expect average user to? Why on earth would you not just reuse the existing face color property and add a new one? Blender's theme customization is already hell as it, why make already borderline impossible theme customization truly impossible?

> Edge Selection and Face Selection are still in use, and they set color of the edge/face when you're not in Edge/Face selection. Edge Selection sets the color for edges when you're in Vertex and Face select modes, and Edge Mode Selection sets color for edges when you're in Edge selection mode. > > Same applies to faces. I probably spent more time on customizing Blender themes than anyone else since I wrote addon to simplify the process. If I can't figure this out, how do you expect average user to? Why on earth would you not just reuse the existing face color property and add a new one? Blender's theme customization is already hell as it, why make already borderline impossible theme customization truly impossible?

Pratik Borhade commented

2024-03-27 09:46:31 +01:00

Hi, thanks for the report. Yes, can confirm. Having two similar properties in themes can be confusing, checking further.

Pratik Borhade added

and removed

labels 2024-03-27 09:46:50 +01:00

Pratik Borhade commented

2024-03-27 10:00:15 +01:00

New edge/face_select_mode was added in dfd1b63cc7

Edge Selection and Face Selection are still in use, and they set color of the edge/face when you're not in Edge/Face selection.

Right but it adds more confusion instead 😅: https://projects.blender.org/blender/blender/src/branch/main/source/blender/draw/engines/overlay/shaders/overlay_edit_mesh_common_lib.glsl#L59

This is not a bug though but would like to hear from @Gilberto.R about the need of separate theme properties.

New `edge/face_select_mode` was added in dfd1b63cc7930d0028aae1f90bf68ee70bc46ef1 > Edge Selection and Face Selection are still in use, and they set color of the edge/face when you're not in Edge/Face selection. Right but it adds more confusion instead 😅: https://projects.blender.org/blender/blender/src/branch/main/source/blender/draw/engines/overlay/shaders/overlay_edit_mesh_common_lib.glsl#L59 This is not a bug though but would like to hear from @Gilberto.R about the need of separate theme properties.

Ludvik Koutny commented

2024-03-27 10:18:11 +01:00

New edge/face_select_mode was added in dfd1b63cc7

Edge Selection and Face Selection are still in use, and they set color of the edge/face when you're not in Edge/Face selection.

Right but it adds more confusion instead 😅: https://projects.blender.org/blender/blender/src/branch/main/source/blender/draw/engines/overlay/shaders/overlay_edit_mesh_common_lib.glsl#L59

This is not a bug though but would like to hear from @Gilberto.R about the need of separate theme properties.

Does the Face Mode Selection vs Face Selection do anything in the UV Editor though? I changed Face Mode Selection in the UV Editor to vivid pink so I can see where it shows up, but it doesn't seem to affect any of the modes.

If the goal was to make edges/faces more visible in certain modes, then this should not add a new color, but instead just derive existing color and modify it (boost value and reduce saturation to make it brighter).

> New `edge/face_select_mode` was added in dfd1b63cc7930d0028aae1f90bf68ee70bc46ef1 > > Edge Selection and Face Selection are still in use, and they set color of the edge/face when you're not in Edge/Face selection. > > Right but it adds more confusion instead 😅: https://projects.blender.org/blender/blender/src/branch/main/source/blender/draw/engines/overlay/shaders/overlay_edit_mesh_common_lib.glsl#L59 > > This is not a bug though but would like to hear from @Gilberto.R about the need of separate theme properties. Does the Face Mode Selection vs Face Selection do anything in the UV Editor though? I changed Face Mode Selection in the UV Editor to vivid pink so I can see where it shows up, but it doesn't seem to affect any of the modes. If the goal was to make edges/faces more visible in certain modes, then this should not add a new color, but instead just derive existing color and modify it (boost value and reduce saturation to make it brighter).

Pratik Borhade commented

2024-03-27 10:27:45 +01:00

Does the Face Mode Selection vs Face Selection do anything in the UV Editor though?

colorFaceModeSelect is unused in UV editor.

Selected faces will be drawn with colorFaceSelect ("face selection")
Non-selected face with colorFace ("Face")
Active face with colorEditMeshActive ("Active vertex/edge/face")

see:https://projects.blender.org/blender/blender/src/branch/main/source/blender/draw/engines/overlay/shaders/overlay_edit_uv_faces_vert.glsl#L15-L16

> Does the Face Mode Selection vs Face Selection do anything in the UV Editor though? `colorFaceModeSelect` is unused in UV editor. - Selected faces will be drawn with `colorFaceSelect` ("face selection") - Non-selected face with `colorFace` ("Face") - Active face with `colorEditMeshActive` ("Active vertex/edge/face") see:https://projects.blender.org/blender/blender/src/branch/main/source/blender/draw/engines/overlay/shaders/overlay_edit_uv_faces_vert.glsl#L15-L16

Pratik Borhade commented

2024-03-27 10:31:03 +01:00

colorFaceModeSelect is unused in UV editor.

Can be removed from UV editor category in similar way: !119649

> `colorFaceModeSelect` is unused in UV editor. Can be removed from UV editor category in similar way: !119649

Gilberto Rodrigues commented

2024-03-27 18:43:44 +01:00

@Rawalanche Sorry for the confusion. This is not a bug. As it was said, now there are different edge/face selection color depending on selection mode. I know adding more theme entries may not be ideal, but there are a couple of reasons for this. My first implementation did automatically calculate hue shift but this was not good for some themes. And having a different entry allows for more customization(e.g. maya theme). The discussion happened here: #111431 .
Indeed I haven't yet implemented the selection mode color change in the UV editor, so the entries could be removed from there.
If you have a custom theme that it's mesh selection colors are not orange, there will be a color mismatch on edge/face select mode, which is a sign for you to update your theme and further customize it for the new color on each mode, as the new entries will by default get the default color. Sorry for the extra work. The user may want a different color on each selection mode or the same color on all modes, or only color in respective mode.

@Rawalanche Sorry for the confusion. This is not a bug. As it was said, now there are different edge/face selection color depending on selection mode. I know adding more theme entries may not be ideal, but there are a couple of reasons for this. My first implementation did automatically calculate hue shift but this was not good for some themes. And having a different entry allows for more customization(e.g. maya theme). The discussion happened here: https://projects.blender.org/blender/blender/pulls/111431 . Indeed I haven't yet implemented the selection mode color change in the UV editor, so the entries could be removed from there. If you have a custom theme that it's mesh selection colors are not orange, there will be a color mismatch on edge/face select mode, which is a sign for you to update your theme and further customize it for the new color on each mode, as the new entries will by default get the default color. Sorry for the extra work. The user may want a different color on each selection mode or the same color on all modes, or only color in respective mode.

Ludvik Koutny commented

2024-03-27 19:55:28 +01:00

@Rawalanche Sorry for the confusion. This is not a bug. As it was said, now there are different edge/face selection color depending on selection mode. I know adding more theme entries may not be ideal, but there are a couple of reasons for this. My first implementation did automatically calculate hue shift but this was not good for some themes. And having a different entry allows for more customization(e.g. maya theme). The discussion happened here: #111431 .
Indeed I haven't yet implemented the selection mode color change in the UV editor, so the entries could be removed from there.
If you have a custom theme that it's mesh selection colors are not orange, there will be a color mismatch on edge/face select mode, which is a sign for you to update your theme and further customize it for the new color on each mode, as the new entries will by default get the default color. Sorry for the extra work. The user may want a different color on each selection mode or the same color on all modes, or only color in respective mode.

Of course it didn't work if the solution you came up with is hue shift. But why didn't you explore more proper solution rather than adding 2000th color to the theme settings? Using the Face Selection color just with increased value and decreased saturation would achieve same effect, but would not introduce yet another color setting, would make theme setup simpler, and would not break existing themes bundled with Blender.

> @Rawalanche Sorry for the confusion. This is not a bug. As it was said, now there are different edge/face selection color depending on selection mode. I know adding more theme entries may not be ideal, but there are a couple of reasons for this. My first implementation did automatically calculate hue shift but this was not good for some themes. And having a different entry allows for more customization(e.g. maya theme). The discussion happened here: https://projects.blender.org/blender/blender/pulls/111431 . > Indeed I haven't yet implemented the selection mode color change in the UV editor, so the entries could be removed from there. > If you have a custom theme that it's mesh selection colors are not orange, there will be a color mismatch on edge/face select mode, which is a sign for you to update your theme and further customize it for the new color on each mode, as the new entries will by default get the default color. Sorry for the extra work. The user may want a different color on each selection mode or the same color on all modes, or only color in respective mode. Of course it didn't work if the solution you came up with is hue shift. But why didn't you explore more proper solution rather than adding 2000th color to the theme settings? Using the Face Selection color just with increased value and decreased saturation would achieve same effect, but would not introduce yet another color setting, would make theme setup simpler, and would not break existing themes bundled with Blender.

Gilberto Rodrigues commented

2024-03-27 22:12:15 +01:00

@Rawalanche FYI I just wanted to do a one liner to make the Edge Highlight toggle on by default, but they wanted me to remove the toggle and implement a way to differentiate between the selection modes. They came up with the hue shift idea and I tried it and it worked very well, so we moved forward with it. I actually did explore changing the saturation, but it made face selection visibility worse depending on matcap and studiolight, because the selection color wouldn't look as strong, or the mode change would look too subtle. Also, the user may want to have the same selection color on all modes, so doing saturation change would not please everyone, and something like just changing saturation wouldn't work for theme like current Maya theme. I have updated all themes bundled with Blender, so you should have no issues with them.