Crash with Geometry Nodes and Bake node #119958
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#119958
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: Radeon RX 5500 XT ATI Technologies Inc. 4.6.0 Core Profile Context 23.12.1.231124
Blender Version
Broken: version: 4.1.0, branch: blender-v4.1-release, commit date: 2024-03-25 20:42, hash:
40a5e739e270
Worked: Never.
Short description of error
You can try to Clear and Bake multiple time.
=> Blender crashes
Originally found by @TobiasKummerOvermindStudios
Crash with Geometry Nodes and Bake nodeto Regression: Crash with Geometry Nodes and Bake nodeRegression: Crash with Geometry Nodes and Bake nodeto Crash with Geometry Nodes and Bake nodeI can't reproduce this here.
You need to re-click a lot of time.
asan nabs this one pretty easily.
I wasn't able to reproduce it yet, but my ASAN setup is also broken right now for unknown reasons. Can someone try reproducing it with
-t 1
and-t 2
?I was able to reproduce it using -t 1
but it seems weird because it is looking like a race condition (that I don't think should happen with 1 thread)
I am using valgrind to reproduce (I am assuming that its helps to reproduce because its slow things down and make a race condition more likely to happen) but if for some reason its problematic to use valgrind please let me know.
from the valgrind output it looks like
preprocess_geometry_node_tree_for_evaluation in node_runtime.cc is called multiple times
and the geometry_nodes_lazy_function_graph_info that was created in node_runtime.cc line 24
is rested by node_runtime.cc line 23
while being used by another thread
again seems like it should be impossible while using -t 1 but...
another option is that it is just one thread but someplace keeps the geometry_nodes_lazy_function_graph_info by pointer and then call
preprocess_geometry_node_tree_for_evaluation again before using the saved pointer
Just noticed that it may actually still use more than one thread here even when passing
-t 1
, because the job system uses threads independently from tbb (also seeWM_jobs_start
).Might still be useful to get another asan report with fewer threads.
You could also try making it so that
start_bake_job
is called withBakeRequestsMode::Sync
.given the last asan dump was kinda noisy, -t1 asan attached below., my build is a few days old though (28th)
where can I read about ASAN? I tried googling it but did not find anything relevant.
after changing the code to always use BakeRequestsMode::Sync I wasn't able to reproudce the crash.
if no one will solve this I will try to look into it a bit more later.
ASAN means "Address Sanitizer". We have some docs about it here and here.
mesh_free_data
freeing but leaving the now dangling pointer inmesh->runtime
seems to be somewhat inviting this class of bugs.fixing that, moves the problem to a new spot
The problem seems to be that the WM_set_locked_interface(job->wm, true); happens inside the thread and then the main thread may check the lock while the thread is in the middle of changing it. I think that the check happen for the animation but didn't found where.
I have a fix, to which branch should I open a pull request?.
Fixes should be against the
main
branch. :)