Video Editor Keyframes Not Clearing Until Another Depsgraph Update #119998

Open
opened 2024-03-28 03:42:52 +01:00 by Jordan-Henshaw · 2 comments

System Information
Operating system: macOS-13.6.3-x86_64-i386-64bit 64 Bits
Graphics card: Metal API Intel(R) Iris(TM) Plus Graphics 1.2

Blender Version
Broken: version: 4.1.0, branch: blender-v4.1-release, commit date: 2024-03-25 20:42, hash: 40a5e739e270 (AS WELL AS 4.0)
Worked: I know it worked on 2.79 but that's probably not helpful

Short description of error
Basically all video editor animatable properties on the side N tab for strips do not clear until I manually update the dependency graph by changing some other property/attribute. They try to clear, the Clear Keyframes button definitely did something, but it glitches back and forth and can't seem to decide if the keyframe is still there or not. After provoking a depsgraph update, the glitching stops and it does exactly what you would expect it to do.

Exact steps for others to reproduce the error

  1. Animate any property on something like a color strip. Make a rectangle rotate for example.
  2. Right click the property and hit Clear Keyframe so that green/yellow property field becomes grey.
  3. Scrub through and playback and you will see it glitching out trying to figure out where it's supposed to be. It should be completely stationary but will glitch between the correct position and the old animation positions. If rotating something, an unexpected white rectangle will stay drawn around the correct orientation but the black part (if using a black color strip) will glitch back and forth.
  4. Now make any change to the dependency graph (like change the strip's channel or save or anything like that) and the issue will clear.

This appears to be happening for basically all video editor keyframes on the side N panel, for many different strip types and not just Transform stuff. Tested on 4.0 and a virgin 4.1.

**System Information** Operating system: macOS-13.6.3-x86_64-i386-64bit 64 Bits Graphics card: Metal API Intel(R) Iris(TM) Plus Graphics 1.2 **Blender Version** Broken: version: 4.1.0, branch: blender-v4.1-release, commit date: 2024-03-25 20:42, hash: `40a5e739e270` (AS WELL AS 4.0) Worked: I know it worked on 2.79 but that's probably not helpful **Short description of error** Basically all video editor animatable properties on the side N tab for strips do not clear until I manually update the dependency graph by changing some other property/attribute. They try to clear, the Clear Keyframes button definitely did something, but it glitches back and forth and can't seem to decide if the keyframe is still there or not. After provoking a depsgraph update, the glitching stops and it does exactly what you would expect it to do. **Exact steps for others to reproduce the error** 1. Animate any property on something like a color strip. Make a rectangle rotate for example. 2. Right click the property and hit Clear Keyframe so that green/yellow property field becomes grey. 3. Scrub through and playback and you will see it glitching out trying to figure out where it's supposed to be. It should be completely stationary but will glitch between the correct position and the old animation positions. If rotating something, an unexpected white rectangle will stay drawn around the correct orientation but the black part (if using a black color strip) will glitch back and forth. 4. Now make any change to the dependency graph (like change the strip's channel or save or anything like that) and the issue will clear. This appears to be happening for basically all video editor keyframes on the side N panel, for many different strip types and not just Transform stuff. Tested on 4.0 and a virgin 4.1.
Jordan-Henshaw added the
Priority
Normal
Type
Report
Status
Needs Triage
labels 2024-03-28 03:42:53 +01:00
Member

It looks very much like that the VSE frame cache hasn't been cleared when clearing key frame.

@iss Is this your realm?

It looks very much like that the VSE frame cache hasn't been cleared when clearing key frame. @iss Is this your realm?
YimingWu added
Module
VFX & Video
Status
Confirmed
Interest
Video Sequencer
and removed
Status
Needs Triage
labels 2024-03-28 04:50:16 +01:00

This issue is outlined in #90041. I guess I will set this to a bug and see if this could be fixed. Graph editor seems to be able to call rna update functions, not sure why this is not possible when adding/clearing keys in side panel.

Technically this would be animation module responsibility, but will check this from VSE standpoint mainly, since it is mostly affected due to extensive caching.

This issue is outlined in https://projects.blender.org/blender/blender/issues/90041. I guess I will set this to a bug and see if this could be fixed. Graph editor seems to be able to call rna update functions, not sure why this is not possible when adding/clearing keys in side panel. Technically this would be animation module responsibility, but will check this from VSE standpoint mainly, since it is mostly affected due to extensive caching.
Richard Antalik added
Type
Bug
and removed
Type
Report
labels 2024-03-28 17:44:23 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#119998
No description provided.