Regression: Copy to selected on addons properties crach Blender #119999

New Issue

Closed

opened 2024-03-28 03:49:38 +01:00 by Milan-Hrabovsky · 12 comments

Milan-Hrabovsky commented

2024-03-28 03:49:38 +01:00

System Information
Operating system: Windows 11 Pro
Graphics card: Nvidia RTX 3080

Blender Version
Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-03-08 00:32, hash: 6dffc162c7b9
Worked: version: 4.2.0 Alpha, branch: main, commit date: 2024-02-27 00:02, hash: cfb60c98be7d

Caused by: 6adf5adb7f

Short description of error
When I try to copy attribute value to selected, Blender crash. For the default Blender properties, it is working.
I have tested it, my friend too and has the same problem.
Alt + Click works without any problems

Exact steps for others to reproduce the error
Not, crashing blender.

**System Information** Operating system: Windows 11 Pro Graphics card: Nvidia RTX 3080 **Blender Version** Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-03-08 00:32, hash: `6dffc162c7b9` Worked: version: 4.2.0 Alpha, branch: main, commit date: 2024-02-27 00:02, hash: `cfb60c98be7d` Caused by: 6adf5adb7fc57bf1db726be7709ae0faf267ae01 **Short description of error** When I try to copy attribute value to selected, Blender crash. For the default Blender properties, it is working. I have tested it, my friend too and has the same problem. Alt + Click works without any problems **Exact steps for others to reproduce the error** Not, crashing blender.

Milan-Hrabovsky added the

labels 2024-03-28 03:49:38 +01:00

YimingWu commented

2024-03-28 04:36:00 +01:00

Member

Hi, there's not enough information to determine what exactly is going wrong here. Could you try upload the crash log? Also please give us a test file that can replicate the issue. Thanks!

Hi, there's not enough information to determine what exactly is going wrong here. Could you try upload the [crash log](https://docs.blender.org/manual/en/latest/troubleshooting/crash.html#windows)? Also please give us a test file that can replicate the issue. Thanks!

YimingWu added

Needs Information from User

and removed

labels 2024-03-28 04:36:10 +01:00

Milan-Hrabovsky commented

2024-03-28 14:23:33 +01:00

Author

Hi, here is an example, crash log and video. In test file, u can find aa script, which register simple property for the test.
Thank You.

Hi, here is an example, crash log and video. In test file, u can find aa script, which register simple property for the test. Thank You.

test_file.crash.txt

59 KiB

2024-03-28 14-20-02.mkv

2.9 MiB

test_file.blend

894 KiB

Kristian commented

2024-04-17 15:33:18 +02:00

Seems like this issue still persists in Blender 4.1.1.

Seems like this issue still persists in Blender 4.1.1.

Iliya Katushenock added the

label 2024-04-18 14:58:43 +02:00

Iliya Katushenock changed title from ~~Copy to selected on addons properties crach Blender~~ to Regression: Copy to selected on addons properties crach Blender

2024-04-18 20:29:45 +02:00

Iliya Katushenock added

and removed

Needs Information from User

labels 2024-04-18 20:29:58 +02:00

Iliya Katushenock added this to the 4.2 LTS milestone 2024-04-18 20:30:02 +02:00

Iliya Katushenock removed this from the 4.2 LTS milestone 2024-04-18 20:30:27 +02:00

Iliya Katushenock commented

2024-04-18 20:30:54 +02:00

Member

@mont29 /

Bastien Montagne commented

2024-04-19 10:34:26 +02:00

Owner

I cannot reproduce any crash in neither 4.2 (main) nor 4.1 branches with debug builds + ASAN...

And @mod_moder please stop adding the override tag to everything, this is getting ridiculous.

I cannot reproduce any crash in neither 4.2 (main) nor 4.1 branches with debug builds + ASAN... And @mod_moder please stop adding the override tag to everything, this is getting ridiculous.

Bastien Montagne removed the

label 2024-04-19 10:34:35 +02:00

Bastien Montagne commented

2024-04-19 11:06:18 +02:00

Owner

Can confirm crash in release builds though... hate these :(

Can confirm crash in release builds though... hate these :(

Bastien Montagne added

and removed

labels 2024-04-19 11:06:36 +02:00

Kristian commented

2024-04-19 11:06:46 +02:00

Hey @mont29, thank you for taking a look. I am not really sure if I am able to explain it better than previous messages, but I have attached a couple more videos in hope that it might help 😅

Hey @mont29, thank you for taking a look. I am not really sure if I am able to explain it better than previous messages, but I have attached a couple more videos in hope that it might help 😅

Desktop 2024.04.19 - 10.54.46.01.mp4

22 MiB

Desktop 2024.04.19 - 11.00.50.02.mp4

16 MiB

Kristian commented

2024-04-19 11:07:43 +02:00

Oh commented almost at the same time, well 🙈

Oh commented almost at the same time, well 🙈

Philipp Oeser commented

2024-04-19 11:38:57 +02:00

Member

@mont29 : apparently prop_src_type != prop_dst_type where prop_src_type is PROP_INT and prop_dst_type is PROP_BOOLEAN

1  rna_property_override_apply_default              rna_rna.cc                     2553  0x1f70109 
2  rna_property_override_operation_apply            rna_access_compare_override.cc 622   0x1dab773 
3  RNA_property_copy                                rna_access_compare_override.cc 260   0x1daa94d 
4  copy_to_selected_button                          interface_ops.cc               1519  0x224da88 
5  copy_to_selected_button_exec                     interface_ops.cc               1540  0x224db86 
6  wm_operator_invoke                               wm_event_system.cc             1555  0x14cec95 
7  wm_operator_call_internal                        wm_event_system.cc             1778  0x14cf44d 
8  WM_operator_name_call_ptr                        wm_event_system.cc             1792  0x14cf4ee 
9  WM_operator_name_call_ptr_with_depends_on_cursor wm_event_system.cc             1982  0x14cfae7 
10 ui_apply_but_funcs_after                         interface_handlers.cc          1023  0x2206eb2 
11 ui_popup_handler                                 interface_handlers.cc          11774 0x2224bb6 
12 wm_handler_ui_call                               wm_event_system.cc             827   0x14cce45 
13 wm_handlers_do_intern                            wm_event_system.cc             3319  0x14d4768 
14 wm_handlers_do                                   wm_event_system.cc             3438  0x14d4e1e 
15 wm_event_do_handlers                             wm_event_system.cc             4065  0x14d7074 
16 WM_main                                          wm.cc                          635   0x14c37e6 
17 main                                             creator.cc                     586   0x71208b

@mont29 : apparently `prop_src_type != prop_dst_type` where prop_src_type is `PROP_INT` and prop_dst_type is `PROP_BOOLEAN` ``` 1 rna_property_override_apply_default rna_rna.cc 2553 0x1f70109 2 rna_property_override_operation_apply rna_access_compare_override.cc 622 0x1dab773 3 RNA_property_copy rna_access_compare_override.cc 260 0x1daa94d 4 copy_to_selected_button interface_ops.cc 1519 0x224da88 5 copy_to_selected_button_exec interface_ops.cc 1540 0x224db86 6 wm_operator_invoke wm_event_system.cc 1555 0x14cec95 7 wm_operator_call_internal wm_event_system.cc 1778 0x14cf44d 8 WM_operator_name_call_ptr wm_event_system.cc 1792 0x14cf4ee 9 WM_operator_name_call_ptr_with_depends_on_cursor wm_event_system.cc 1982 0x14cfae7 10 ui_apply_but_funcs_after interface_handlers.cc 1023 0x2206eb2 11 ui_popup_handler interface_handlers.cc 11774 0x2224bb6 12 wm_handler_ui_call wm_event_system.cc 827 0x14cce45 13 wm_handlers_do_intern wm_event_system.cc 3319 0x14d4768 14 wm_handlers_do wm_event_system.cc 3438 0x14d4e1e 15 wm_event_do_handlers wm_event_system.cc 4065 0x14d7074 16 WM_main wm.cc 635 0x14c37e6 17 main creator.cc 586 0x71208b ```

Bastien Montagne commented

2024-04-19 11:41:06 +02:00

Owner

@lichtwerk yes, that is the trigger of the issue - but first need to fix the crash (code assumed liboverride data was available at that point, which is not the case obviously when using 'regular' RNA copy feature).

Once this is done, we can figure out why the property types are different here :(

@lichtwerk yes, that is the trigger of the issue - but first need to fix the crash (code assumed liboverride data was available at that point, which is not the case obviously when using 'regular' RNA copy feature). Once this is done, we can figure out why the property types are different here :(

Philipp Oeser commented

2024-04-19 11:46:18 +02:00

Member

@lichtwerk yes, that is the trigger of the issue - but first need to fix the crash (code assumed liboverride data was available at that point, which is not the case obviously when using 'regular' RNA copy feature).

Once this is done, we can figure out why the property types are different here :(

Ah yep, prop_storage was NULL...

> @lichtwerk yes, that is the trigger of the issue - but first need to fix the crash (code assumed liboverride data was available at that point, which is not the case obviously when using 'regular' RNA copy feature). > > Once this is done, we can figure out why the property types are different here :( Ah yep, `prop_storage` was NULL...

Bastien Montagne referenced this issue from a commit

2024-04-19 12:04:14 +02:00

Fix #119999: Regression: Copy to selected on addons properties crash Blender.

Bastien Montagne closed this issue

2024-04-19 12:04:15 +02:00

Blender Bot added

and removed

labels 2024-04-19 12:04:18 +02:00

Bastien Montagne commented

2024-04-19 12:05:22 +02:00

Owner

Crash should be fixed by 8b1154a854.

However, the actual issue here (that two properties that should have exactly the same type are detected as of different type) remains under investigation.

Crash should be fixed by 8b1154a854. However, the actual issue here (that two properties that should have exactly the same type are detected as of different type) remains under investigation.

Bastien Montagne reopened this issue

2024-04-19 12:05:26 +02:00

Blender Bot added

and removed

labels 2024-04-19 12:06:13 +02:00

Bastien Montagne referenced this issue from a commit

2024-04-19 15:52:30 +02:00

Fix #119999: RNA copy failure due to improper handling of unset dynamic RNA properties.

Bastien Montagne closed this issue

2024-04-19 15:52:31 +02:00

Blender Bot added

and removed

labels 2024-04-19 15:52:33 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

6 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#119999

No description provided.