blender
/
blender
134
398
Fork 579
Code Issues 6.3k Pull Requests 754 Projects 19 Wiki Activity

multiple duplication AutoSmooth modifier #120030

New Issue
Open
opened 2024-03-28 19:24:22 +01:00 by Sergey Bogatchev · 12 comments
Sergey Bogatchev commented 2024-03-28 19:24:22 +01:00
Copy Link

System Information
Operating system: Windows-10-10.0.17763-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 536.23

Blender Version
Broken: version: 4.1.0, branch: blender-v4.1-release, commit date: 2024-03-25 20:42, hash: 40a5e739e270
Worked: 4.0.2
Short description of error
multiple duplication AutoSmooth modifier on linked localized objects saved in 4.0.2 / 3.6

Exact steps for others to reproduce the error

  • Open blender 4.0.2. Add cube. Sade smooth cube. Save file.
  • Open blender 4.1 Link object cube. Make Local cube. Save file. Open it file. See dublicating autosmooth every file opening and save.
**System Information** Operating system: Windows-10-10.0.17763-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 536.23 **Blender Version** Broken: version: 4.1.0, branch: blender-v4.1-release, commit date: 2024-03-25 20:42, hash: `40a5e739e270` Worked: 4.0.2 **Short description of error** multiple duplication AutoSmooth modifier on linked localized objects saved in 4.0.2 / 3.6 **Exact steps for others to reproduce the error** - Open blender 4.0.2. Add cube. Sade smooth cube. Save file. - Open blender 4.1 Link object cube. Make Local cube. Save file. Open it file. See dublicating autosmooth every file opening and save.
Sergey Bogatchev added the
Type
Report
Priority
Normal
Status
Needs Triage
 labels 2024-03-28 19:24:23 +01:00
Richard Antalik commented 2024-03-28 20:00:56 +01:00
Member
Copy Link

I don't think I can reproduce this issue. Do you identify this bug by cube shading/appearance?

I don't think I can reproduce this issue. Do you identify this bug by cube shading/appearance?
Sergey Bogatchev commented 2024-03-28 20:06:55 +01:00
Author
Copy Link

I don't think I can reproduce this issue. Do you identify this bug by cube shading/appearance?

> I don't think I can reproduce this issue. Do you identify this bug by cube shading/appearance?
untitled.jpg
36 KiB
untitled.jpg
Sergey Bogatchev commented 2024-03-28 20:13:20 +01:00
Author
Copy Link

Open in blender 4.1.0 test.blend file. Select cube. Make Local cube. Save file. Reopen test file. look at the number of modifiers....

Open in blender 4.1.0 test.blend file. Select cube. Make Local cube. Save file. Reopen test file. look at the number of modifiers....
lib.blend
108 KiB
test.blend
109 KiB
Richard Antalik commented 2024-03-28 21:24:27 +01:00
Member
Copy Link

I see now I think, I was confused by the auto smooth thing, because now this is done with modifiers and I could not see the auto smooth anywhere... Turns out this is added by versioning code. So it looks like, that you set auto smooth in 4.0 and then use this file in 4.1.

In any case, can reproduce.

I see now I think, I was confused by the auto smooth thing, because now this is done with modifiers and I could not see the auto smooth anywhere... Turns out this is added by versioning code. So it looks like, that you set auto smooth in 4.0 and then use this file in 4.1. In any case, can reproduce.
Richard Antalik commented 2024-03-28 21:38:00 +01:00
Member
Copy Link

I have looked at the code quite quickly, I see, that flag is cleared in versioning, but not sure how this could be resolved if original file is not modifies when linking. Perhaps checking existing modifiers. That said, seems like Modelling module issue to me, so will assign report there.

I have looked at the code quite quickly, I see, that flag is cleared in versioning, but not sure how this could be resolved if original file is not modifies when linking. Perhaps checking existing modifiers. That said, seems like Modelling module issue to me, so will assign report there.
Richard Antalik added
Module
Modeling
Priority
High
Status
Confirmed
 and removed
Priority
Normal
Status
Needs Triage
 labels 2024-03-28 21:38:39 +01:00
Richard Antalik added the
Interest
Geometry Nodes
 label 2024-03-28 22:05:12 +01:00
Pratik Borhade commented 2024-03-29 06:42:04 +01:00
Member
Copy Link

Can confirm when object is local but mesh data is still linked.
cc @HooglyBoogly

Can confirm when object is local but mesh data is still linked. cc @HooglyBoogly
Hans Goudey self-assigned this 2024-04-03 01:57:52 +02:00
Hans Goudey commented 2024-04-03 19:17:54 +02:00
Member
Copy Link

Hmm, I can confirm this issue too. The problem is when the object is made local after the versioning runs. Then the object will be local but still reference the linked data-block from the library file. However, the node group added by versioning isn't really from the library, so we get this error: 1 linked data-blocks are missing.

Maybe there is a way to pack the versioning node group into the file so it isn't re-read from the library file incorrectly? @mont29, do you have an idea here?

Hmm, I can confirm this issue too. The problem is when the object is made local after the versioning runs. Then the object will be local but still reference the linked data-block from the library file. However, the node group added by versioning isn't *really* from the library, so we get this error: `1 linked data-blocks are missing`. Maybe there is a way to pack the versioning node group into the file so it isn't re-read from the library file incorrectly? @mont29, do you have an idea here?
Hans Goudey commented 2024-04-03 19:28:13 +02:00
Member
Copy Link

If we can get the modifier to load properly, the following might be necessary to avoid duplicates still:

diff --git a/source/blender/blenkernel/intern/mesh_legacy_convert.cc b/source/blender/blenkernel/intern/mesh_legacy_convert.cc
index d38a612c52f..619cc00189e 100644
--- a/source/blender/blenkernel/intern/mesh_legacy_convert.cc
+++ b/source/blender/blenkernel/intern/mesh_legacy_convert.cc
@@ -2431,6 +2431,15 @@ void BKE_main_mesh_legacy_convert_auto_smooth(Main &bmain)
           BLI_insertlinkbefore(&object->modifiers, object->modifiers.last, new_md);
         }
       }
+      if (md->type == eModifierType_Nodes) {
+        NodesModifierData *nmd = reinterpret_cast<NodesModifierData *>(md);
+        if (nmd->node_group && is_auto_smooth_node_tree(*nmd->node_group)) {
+          /* This object has already been processed by versioning. If the mesh is linked from
+           * another file its auto-smooth flag may not be cleared, so this check is necessary to
+           * avoid adding a duplicate modifier. */
+          has_custom_normals = true;
+        }
+      }
     }
 
     /* Some modifiers always generate custom normals which disabled sharp edge tagging, making
If we can get the modifier to load properly, the following might be necessary to avoid duplicates still: ```diff diff --git a/source/blender/blenkernel/intern/mesh_legacy_convert.cc b/source/blender/blenkernel/intern/mesh_legacy_convert.cc index d38a612c52f..619cc00189e 100644 --- a/source/blender/blenkernel/intern/mesh_legacy_convert.cc +++ b/source/blender/blenkernel/intern/mesh_legacy_convert.cc @@ -2431,6 +2431,15 @@ void BKE_main_mesh_legacy_convert_auto_smooth(Main &bmain) BLI_insertlinkbefore(&object->modifiers, object->modifiers.last, new_md); } } + if (md->type == eModifierType_Nodes) { + NodesModifierData *nmd = reinterpret_cast<NodesModifierData *>(md); + if (nmd->node_group && is_auto_smooth_node_tree(*nmd->node_group)) { + /* This object has already been processed by versioning. If the mesh is linked from + * another file its auto-smooth flag may not be cleared, so this check is necessary to + * avoid adding a duplicate modifier. */ + has_custom_normals = true; + } + } } /* Some modifiers always generate custom normals which disabled sharp edge tagging, making ```
Hans Goudey commented 2024-04-03 19:29:09 +02:00
Member
Copy Link

One hacky workaround might be checking for a modifier with the name "Auto Smooth" with a node group with LIB_TAG_MISSING.

One hacky workaround might be checking for a modifier with the name "Auto Smooth" with a node group with `LIB_TAG_MISSING`.
Bastien Montagne commented 2024-04-04 01:33:59 +02:00
Owner
Copy Link

These kind of situations are indeed the cost of moving data from one ID type to another,,, There will always be corner-cases that cannot be handled nicely, if at all.

Here I can't think of any better idea than the hack suggested by @HooglyBoogly above, Though it may also backfire in some even more intricate cases, I think it's still a 'reasonable' one. :|

These kind of situations are indeed the cost of moving data from one ID type to another,,, There will always be corner-cases that cannot be handled nicely, if at all. Here I can't think of any better idea than the hack suggested by @HooglyBoogly above, Though it may also backfire in some even more intricate cases, I think it's still a 'reasonable' one. :|
Hans Goudey commented 2024-04-04 18:26:38 +02:00
Member
Copy Link

I think it's best to call this a known issue. I resolved part of the problem in 7ba8fc1768, but anything else is going to be too hacky.

The workaround in this case is to make both the object and the node group local, not just the object.

I think it's best to call this a known issue. I resolved part of the problem in 7ba8fc17682f510df60fa726e66dde353a8d4322, but anything else is going to be too hacky. --- The workaround in this case is to make *both* the object and the node group local, not just the object.
Hans Goudey added
Priority
Normal
Type
Known Issue
 and removed
Priority
High
Type
Report
 labels 2024-04-04 18:26:50 +02:00
Sergey Bogatchev commented 2024-04-09 20:28:57 +02:00
Author
Copy Link

corrections are not visible in the list of candidates...

corrections are not visible in the list of candidates...
👍 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
brush-assets-project
universal-scene-description
fix-121021
blender-v4.1-release
blender-v3.3-release
blender-v3.6-release
blender-v3.6-temp_wmoss_animrig_public
temp-sculpt-dyntopo
gpencil-next
anim/animation-id-113594
blender-v4.0-release
blender-projects-basics
bridge-curves
sculpt-blender
asset-browser-frontend-split
asset-shelf
tmp-usd-python-mtl
tmp-usd-3.6
blender-v3.5-release
blender-v2.93-release
realtime-clock
sculpt-dev
bevelv2
xr-dev
v4.1.1
v3.6.11
v3.3.18
v4.1.0
v3.3.17
v3.6.10
v3.6.9
v3.3.16
v3.6.8
v3.6.7
v3.3.14
v4.0.2
v4.0.1
v4.0.0
v3.6.5
v3.3.12
v3.6.4
v3.6.3
v3.3.11
v3.6.2
v3.3.10
v3.6.1
v3.3.9
v3.6.0
v3.3.8
v3.3.7
v2.93.18
v3.5.1
v3.3.6
v2.93.17
v3.5.0
v2.93.16
v3.3.5
v3.3.4
v2.93.15
v2.93.14
v3.3.3
v2.93.13
v2.93.12
v3.4.1
v3.3.2
v3.4.0
v3.3.1
v2.93.11
v3.3.0
v3.2.2
v2.93.10
v3.2.1
v3.2.0
v2.83.20
v2.93.9
v3.1.2
v3.1.1
v3.1.0
v2.83.19
v2.93.8
v3.0.1
v2.93.7
v3.0.0
v2.93.6
v2.93.5
v2.83.18
v2.93.4
v2.93.3
v2.83.17
v2.93.2
v2.93.1
v2.83.16
v2.93.0
v2.83.15
v2.83.14
v2.83.13
v2.92.0
v2.83.12
v2.91.2
v2.83.10
v2.91.0
v2.83.9
v2.83.8
v2.83.7
v2.90.1
v2.83.6.1
v2.83.6
v2.90.0
v2.83.5
v2.83.4
v2.83.3
v2.83.2
v2.83.1
v2.83
v2.82a
v2.82
v2.81a
v2.81
v2.80
v2.80-rc3
v2.80-rc2
v2.80-rc1
v2.79b
v2.79a
v2.79
v2.79-rc2
v2.79-rc1
v2.78c
v2.78b
v2.78a
v2.78
v2.78-rc2
v2.78-rc1
v2.77a
v2.77
v2.77-rc2
v2.77-rc1
v2.76b
v2.76a
v2.76
v2.76-rc3
v2.76-rc2
v2.76-rc1
v2.75a
v2.75
v2.75-rc2
v2.75-rc1
v2.74
v2.74-rc4
v2.74-rc3
v2.74-rc2
v2.74-rc1
v2.73a
v2.73
v2.73-rc1
v2.72b
2.72b
v2.72a
v2.72
v2.72-rc1
v2.71
v2.71-rc2
v2.71-rc1
v2.70a
v2.70
v2.70-rc2
v2.70-rc
v2.69
v2.68a
v2.68
v2.67b
v2.67a
v2.67
v2.66a
v2.66
v2.65a
v2.65
v2.64a
v2.64
v2.63a
v2.63
v2.61
v2.60a
v2.60
v2.59
v2.58a
v2.58
v2.57b
v2.57a
v2.57
v2.56a
v2.56
v2.55
v2.54
v2.53
v2.52
v2.51
v2.50
v2.49b
v2.49a
v2.49
v2.48a
v2.48
v2.47
v2.46
v2.45
v2.44
v2.43
v2.42a
v2.42
v2.41
v2.40
v2.37a
v2.37
v2.36
v2.35a
v2.35
v2.34
v2.33a
v2.33
v2.32
v2.31a
v2.31
v2.30
v2.28c
v2.28a
v2.28
v2.27
v2.26
v2.25
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Hans Goudey
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#120030
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?