Regression: Vertices and faces extruded with Solidify no longer snap. #120104

New Issue

Closed

opened 2024-03-31 04:04:23 +02:00 by hoya choe · 9 comments

hoya choe commented

2024-03-31 04:04:23 +02:00

System Information
Operating system: Windows 11 , MacBook pro 13
Graphics card: 4090RTX , Mac M2

Blender Version
4.1

Short description of error
Vertices and faces extruded with Solidify no longer snap.
Faces that are extruded from the Solidify of the object to be snapped will be snapped, but faces and vertices that will be extruded from the Solidify of the object to be snapped will not be snapped.

video
https://drive.google.com/file/d/1kAdkkXhlqAxJJuNDToQ0umxrApHR2W-w/view?usp=drive_link

Exact steps for others to reproduce the error

Press A key Delete All Obj.
Shift+A , Add Plane.
Add Solidify modifier Set more Thickness , like 0.6m.
Shift +D Duplicate Obj on top.
Set Snap to Face and On Snap.
G key move and snap. and you can't not snap the extruded with Solidify.

Faces that are extruded from the Solidify of the object to be snapped will be snapped, but faces and vertices that will be extruded from the Solidify of the object to be snapped will not be snapped.

**System Information** Operating system: Windows 11 , MacBook pro 13 Graphics card: 4090RTX , Mac M2 **Blender Version** 4.1 **Short description of error** Vertices and faces extruded with Solidify no longer snap. Faces that are extruded from the Solidify of the object to be snapped will be snapped, but faces and vertices that will be extruded from the Solidify of the object to be snapped will not be snapped. video https://drive.google.com/file/d/1kAdkkXhlqAxJJuNDToQ0umxrApHR2W-w/view?usp=drive_link ![Untitled](/attachments/e664527a-6504-416c-8271-34283bcc79e1) **Exact steps for others to reproduce the error** 1. Press A key Delete All Obj. 2. Shift+A , Add Plane. 3. Add Solidify modifier Set more Thickness , like 0.6m. 4. Shift +D Duplicate Obj on top. 6. Set Snap to Face and On Snap. 7. G key move and snap. and you can't not snap the extruded with Solidify. Faces that are extruded from the Solidify of the object to be snapped will be snapped, but faces and vertices that will be extruded from the Solidify of the object to be snapped will not be snapped.

Untitled.jpg

302 KiB

hoya choe added the

labels 2024-03-31 04:04:24 +02:00

Iliya Katushenock added the

labels 2024-03-31 14:34:21 +02:00

Iliya Katushenock changed title from ~~Vertices and faces extruded with Solidify no longer snap.~~ to Regression: Vertices and faces extruded with Solidify no longer snap.

2024-03-31 14:34:36 +02:00

YimingWu commented

2024-04-01 07:40:56 +02:00

Member

Not sure if you meant that in 4.1+ snap will not pick the closest point from extruded geometries, which indeed seem to be the case, but now you can also use B key to select snap base so you can choose whatever point you want on the source object as the snap target point.

@mano-wii is this a bug?

Not sure if you meant that in 4.1+ snap will not pick the closest point from extruded geometries, which indeed seem to be the case, but now you can also use `B` key to select snap base so you can choose whatever point you want on the source object as the snap target point. @mano-wii is this a bug?

YimingWu added

Needs Info from Developers

and removed

labels 2024-04-01 07:41:15 +02:00

hoya choe commented

2024-04-01 08:00:35 +02:00

Author

video 2
https://drive.google.com/file/d/1eHq45j9UnD5_JWlHlniRL-k4r-SbKRqA/view?usp=drive_link

Snap does not work on geometry with Solidify as well as other modifiers.
Snap does not work when using Generate and Deform modifiers as well as Solidify

sorry im using Google Translator

video 2 https://drive.google.com/file/d/1eHq45j9UnD5_JWlHlniRL-k4r-SbKRqA/view?usp=drive_link Snap does not work on geometry with Solidify as well as other modifiers. Snap does not work when using Generate and Deform modifiers as well as Solidify sorry im using Google Translator

YimingWu commented

2024-04-01 08:28:10 +02:00

Member

Humm yeah now I do believe this is a bug since I don't believe this behaviour should change even when select base feature is available here

Humm yeah now I do believe this is a bug since I don't believe this behaviour should change even when select base feature is available here

YimingWu added

and removed

Needs Info from Developers

labels 2024-04-01 08:28:38 +02:00

hoya choe commented

2024-04-01 08:33:59 +02:00

Author

wow G and B key is work . thanks~~
But before, i could just snap object with modifier directly . Will this be changed to pressing the B key in a future version?

wow G and B key is work . thanks~~ But before, i could just snap object with modifier directly . Will this be changed to pressing the B key in a future version?

YimingWu commented

2024-04-01 09:02:26 +02:00

Member

Will this be changed to pressing the B key in a future version?

I don't think this is the intention since it's gonna be a lot more inconvenient especially when modifiers could change the geometry a lot

> Will this be changed to pressing the B key in a future version? I don't think this is the intention since it's gonna be a lot more inconvenient especially when modifiers could change the geometry a lot

Pratik Borhade commented

2024-04-01 11:17:16 +02:00

Member

Broke between f20e38d42216 - fd212e3f6ca8

Broke between `f20e38d42216 - fd212e3f6ca8`

Alaska commented

2024-04-01 13:23:45 +02:00

Member

Bisecting points to 1cbd0f5a85 as the culprit commit. CC @HooglyBoogly

Bisecting points to 1cbd0f5a8583a898ebba45723847d1e5fb3d03a1 as the culprit commit. CC @HooglyBoogly

Germano Cavalcante commented

2024-04-01 16:38:49 +02:00

Member

One solution is to get the bounds of the evaluated object.
This wasn't necessary before, but it seems more expected.

diff --git a/source/blender/editors/transform/transform_snap.cc b/source/blender/editors/transform/transform_snap.cc
index 90bf9299fa2..ef7b74b845f 100644
--- a/source/blender/editors/transform/transform_snap.cc
+++ b/source/blender/editors/transform/transform_snap.cc
@@ -40,6 +40,8 @@
 
 #include "SEQ_sequencer.hh"
 
+#include "DEG_depsgraph_query.hh"
+
 #include "MEM_guardedalloc.h"
 
 #include "transform.hh"
@@ -1422,7 +1424,7 @@ static void snap_source_closest_fn(TransInfo *t)
           std::optional<blender::Bounds<blender::float3>> bounds;
 
           if ((t->options & CTX_OBMODE_XFORM_OBDATA) == 0) {
-            bounds = BKE_object_boundbox_get(td->ob);
+            bounds = BKE_object_boundbox_get(DEG_get_evaluated_object(t->depsgraph, td->ob));
           }
 
           /* Use bound-box if possible. */

I'll leave it to @HooglyBoogly

One solution is to get the bounds of the evaluated object. This wasn't necessary before, but it seems more expected. ```diff diff --git a/source/blender/editors/transform/transform_snap.cc b/source/blender/editors/transform/transform_snap.cc index 90bf9299fa2..ef7b74b845f 100644 --- a/source/blender/editors/transform/transform_snap.cc +++ b/source/blender/editors/transform/transform_snap.cc @@ -40,6 +40,8 @@ #include "SEQ_sequencer.hh" +#include "DEG_depsgraph_query.hh" + #include "MEM_guardedalloc.h" #include "transform.hh" @@ -1422,7 +1424,7 @@ static void snap_source_closest_fn(TransInfo *t) std::optional<blender::Bounds<blender::float3>> bounds; if ((t->options & CTX_OBMODE_XFORM_OBDATA) == 0) { - bounds = BKE_object_boundbox_get(td->ob); + bounds = BKE_object_boundbox_get(DEG_get_evaluated_object(t->depsgraph, td->ob)); } /* Use bound-box if possible. */ ``` I'll leave it to @HooglyBoogly

Hans Goudey commented

2024-04-01 16:59:02 +02:00

Member

Thanks for the investigation @mano-wii

Thanks for the investigation @mano-wii

Hans Goudey referenced this issue from a commit

2024-04-01 17:02:07 +02:00

Fix #120104: Snap ignores evaluated geometry bounds

Hans Goudey closed this issue

2024-04-01 17:02:09 +02:00

Blender Bot added

and removed

labels 2024-04-01 17:02:10 +02:00

Hans Goudey added

and removed

labels 2024-04-01 17:10:15 +02:00

YimingWu referenced this issue

2024-04-04 10:08:49 +02:00

Can't snap with self vertex #120239

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

6 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#120104

No description provided.