blender/blender

Invert Visible doesn't invert Face Sets properly in Sculpt Mode #120144

New Issue

Closed

opened 2024-04-01 15:09:52 +02:00 by Tolkfan · 4 comments

Tolkfan commented

2024-04-01 15:09:52 +02:00

System Information
Operating system: Windows 10
Graphics card: Nvidia

Blender Version
Broken: 4.1
Worked: 4.0

Short description of error

The Invert Visible operator in 4.1 doesn't invert Face Sets properly. I think the problem is that it's now inverting vertices instead of faces.

It's named Invert Visible in the Sculpt menu in both 4.0 and 4.1, but the operators are different. For 4.0 it's bpy.ops.sculpt.face_set_invert_visibility(), for 4.1 it's bpy.ops.paint.visibility_invert() and the old one is removed completely.

Exact steps for others to reproduce the error

subdivide the cube a few times
paint a few face sets
hide one of the face sets (H)
invert the visibility (Sculpt > Invert Visible)

**System Information** Operating system: Windows 10 Graphics card: Nvidia **Blender Version** Broken: 4.1 Worked: 4.0 **Short description of error** The `Invert Visible` operator in 4.1 doesn't invert Face Sets properly. I think the problem is that it's now inverting vertices instead of faces. <video src="/attachments/5c029453-84e7-4c53-a6a2-b4aed1741372" title="BlenderInvert.mp4" controls></video> It's named `Invert Visible` in the Sculpt menu in both 4.0 and 4.1, but the operators are different. For 4.0 it's `bpy.ops.sculpt.face_set_invert_visibility()`, for 4.1 it's `bpy.ops.paint.visibility_invert()` and the old one is removed completely. **Exact steps for others to reproduce the error** - subdivide the cube a few times - paint a few face sets - hide one of the face sets (H) - invert the visibility (Sculpt > Invert Visible)

invert_menu.jpg

34 KiB

BlenderInvert.mp4

824 KiB

Tolkfan added the

labels 2024-04-01 15:09:53 +02:00

Tolkfan changed title from ~~Invert Visibility doesn't invert Face Sets properly in Sculpt Mode~~ to Invert Visible doesn't invert Face Sets properly in Sculpt Mode

2024-04-01 15:11:40 +02:00

Iliya Katushenock added the

Sculpt, Paint & Texture

label 2024-04-01 15:11:44 +02:00

Pratik Borhade commented

2024-04-02 05:53:27 +02:00

Member

Hi, thanks for the report. Can confirm

Hi, thanks for the report. Can confirm

Pratik Borhade added

Sculpt, Paint & Texture

and removed

Sculpt, Paint & Texture

labels 2024-04-02 05:53:45 +02:00

Pratik Borhade commented

2024-04-02 06:04:57 +02:00

Member

BTW, the old operator is replaced in 53418fc3a1
@HooglyBoogly ^

BTW, the old operator is replaced in 53418fc3a1e5579b989cd7830d82766c762493df @HooglyBoogly ^

Pratik Borhade commented

2024-04-02 06:49:40 +02:00

Member

I think it's best to go with .hide_poly instead of hide_verts. corner vertices of hidden face sets are not 1/true/hidden (which is expected) so inverting them hides these corner vertices, that's why the small region of face sets is visible.

I think it's best to go with `.hide_poly` instead of `hide_verts`. corner vertices of hidden face sets are not `1/true/hidden` (which is expected) so inverting them hides these corner vertices, that's why the small region of face sets is visible.

Pratik Borhade commented

2024-04-02 08:04:02 +02:00

Member

Should fix this:

diff --git a/source/blender/editors/sculpt_paint/paint_hide.cc b/source/blender/editors/sculpt_paint/paint_hide.cc
index 3b18edb19ac..699902dbe3f 100644
--- a/source/blender/editors/sculpt_paint/paint_hide.cc
+++ b/source/blender/editors/sculpt_paint/paint_hide.cc
@@ -609,24 +609,27 @@ void PAINT_OT_hide_show_all(wmOperatorType *ot)

 static void invert_visibility_mesh(Object &object, const Span<PBVHNode *> nodes)
 {
+  PBVH &pbvh = *object.sculpt->pbvh;
   Mesh &mesh = *static_cast<Mesh *>(object.data);
   bke::MutableAttributeAccessor attributes = mesh.attributes_for_write();
-  bke::SpanAttributeWriter<bool> hide_vert = attributes.lookup_or_add_for_write_span<bool>(
-      ".hide_vert", bke::AttrDomain::Point);
+  bke::SpanAttributeWriter<bool> hide_poly = attributes.lookup_or_add_for_write_span<bool>(
+      ".hide_poly", bke::AttrDomain::Face);

   threading::parallel_for(nodes.index_range(), 1, [&](const IndexRange range) {
     for (PBVHNode *node : nodes.slice(range)) {
-      undo::push_node(&object, node, undo::Type::HideVert);
-      for (const int vert : BKE_pbvh_node_get_unique_vert_indices(node)) {
-        hide_vert.span[vert] = !hide_vert.span[vert];
+      undo::push_node(&object, node, undo::Type::HideFace);
+      Vector<int> faces;
+      bke::pbvh::node_face_indices_calc_mesh(pbvh, *node, faces);
+      for (const int face : faces) {
+        hide_poly.span[face] = !hide_poly.span[face];
       }
       BKE_pbvh_node_mark_update_visibility(node);
-      bke::pbvh::node_update_visibility_mesh(hide_vert.span, *node);
+      //bke::pbvh::node_update_visibility_mesh(hide_poly.span, *node);
     }
   });

-  hide_vert.finish();
-  bke::mesh_hide_vert_flush(mesh);
+  hide_poly.finish();
+  bke::mesh_hide_face_flush(mesh);

Should fix this: ``` diff --git a/source/blender/editors/sculpt_paint/paint_hide.cc b/source/blender/editors/sculpt_paint/paint_hide.cc index 3b18edb19ac..699902dbe3f 100644 --- a/source/blender/editors/sculpt_paint/paint_hide.cc +++ b/source/blender/editors/sculpt_paint/paint_hide.cc @@ -609,24 +609,27 @@ void PAINT_OT_hide_show_all(wmOperatorType *ot) static void invert_visibility_mesh(Object &object, const Span<PBVHNode *> nodes) { + PBVH &pbvh = *object.sculpt->pbvh; Mesh &mesh = *static_cast<Mesh *>(object.data); bke::MutableAttributeAccessor attributes = mesh.attributes_for_write(); - bke::SpanAttributeWriter<bool> hide_vert = attributes.lookup_or_add_for_write_span<bool>( - ".hide_vert", bke::AttrDomain::Point); + bke::SpanAttributeWriter<bool> hide_poly = attributes.lookup_or_add_for_write_span<bool>( + ".hide_poly", bke::AttrDomain::Face); threading::parallel_for(nodes.index_range(), 1, [&](const IndexRange range) { for (PBVHNode *node : nodes.slice(range)) { - undo::push_node(&object, node, undo::Type::HideVert); - for (const int vert : BKE_pbvh_node_get_unique_vert_indices(node)) { - hide_vert.span[vert] = !hide_vert.span[vert]; + undo::push_node(&object, node, undo::Type::HideFace); + Vector<int> faces; + bke::pbvh::node_face_indices_calc_mesh(pbvh, *node, faces); + for (const int face : faces) { + hide_poly.span[face] = !hide_poly.span[face]; } BKE_pbvh_node_mark_update_visibility(node); - bke::pbvh::node_update_visibility_mesh(hide_vert.span, *node); + //bke::pbvh::node_update_visibility_mesh(hide_poly.span, *node); } }); - hide_vert.finish(); - bke::mesh_hide_vert_flush(mesh); + hide_poly.finish(); + bke::mesh_hide_face_flush(mesh); ```

Pratik Borhade referenced a pull request that will close this issue

2024-04-02 08:29:38 +02:00

Fix #120144: Invert Visible doesn't invert Face Sets properly #120160

Pratik Borhade self-assigned this 2024-04-02 08:30:22 +02:00

Pratik Borhade referenced this issue from a commit

2024-04-09 12:51:04 +02:00

Fix #120144: Invert Visible doesn't invert Face Sets properly

Pratik Borhade closed this issue

2024-04-09 12:51:05 +02:00

Pratik Borhade referenced this issue

2024-04-09 12:52:23 +02:00

4.1: Candidates for corrective releases #119631

Blender Bot added

and removed

labels 2024-04-09 12:52:25 +02:00

Thomas Dinges referenced this issue from a commit

2024-04-09 16:11:48 +02:00

Fix #120144: Invert Visible doesn't invert Face Sets properly

Sign in to join this conversation.

No Label

Animation & Rigging

Automated Testing

Blender Asset Bundle

Code Documentation

Dependency Graph

Development Management

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Viewport & EEVEE

Virtual Reality

Asset Browser Project

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Viewport & EEVEE

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#120144

No description provided.