Undo has unpredictable results. #120251

Closed
opened 2024-04-04 12:51:38 +02:00 by HotKnife · 7 comments

System Information
Operating system: Windows-10-10.0.22631-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 4090/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 528.24

Blender Version
Broken: version: 4.1.0, branch: blender-v4.1-release, commit date: 2024-03-25 20:42, hash: 40a5e739e270
Worked: (newest version of Blender that worked as expected)

Short description of error
Undo system ignores any Hair actions. Doesn't undo the adding of hairs or any of the actions taken within the the Hair system - such as adding hairs etc, and pressing undo once hair actions are complete, undoes any action taken before 'entering' the hair grooming system. For example Unwrapping an object then adding hair and doing some grooming - Ctrl Z will undo the unwrap. This is not the expected behaviour.

Exact steps for others to reproduce the error

  1. unwrap the cube to a new Unwrap state.
  2. Add empty hair
  3. Add a few Hairs with Add Hair.
  4. Switch to Object mode.
  5. Press Ctrl Z

The undo system ignores any of the hair actions and undo's the unwrap.

**System Information** Operating system: Windows-10-10.0.22631-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 4090/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 528.24 **Blender Version** Broken: version: 4.1.0, branch: blender-v4.1-release, commit date: 2024-03-25 20:42, hash: `40a5e739e270` Worked: (newest version of Blender that worked as expected) **Short description of error** Undo system ignores any Hair actions. Doesn't undo the adding of hairs or any of the actions taken within the the Hair system - such as adding hairs etc, and pressing undo once hair actions are complete, undoes any action taken before 'entering' the hair grooming system. For example Unwrapping an object then adding hair and doing some grooming - Ctrl Z will undo the unwrap. This is not the expected behaviour. <video src="https://projects.blender.org/attachments/c4bbc3ba-bce0-4265-8e78-0bf67a2a1cdc" controls></video> **Exact steps for others to reproduce the error** 1. unwrap the cube to a new Unwrap state. 2. Add empty hair 3. Add a few Hairs with Add Hair. 4. Switch to Object mode. 5. Press Ctrl Z The undo system ignores any of the hair actions and undo's the unwrap.
HotKnife added the
Status
Needs Triage
Severity
Normal
Type
Report
labels 2024-04-04 12:51:38 +02:00

I can't reproduce this issue.

I can't reproduce this issue.
Author

Hi - thanks for getting back so quickly. Video attached. @37s I press Ctrl Z and the unwrapping is undone - notice that the fur stays.
Which I don't expect as a behaviour.
Upon looking further - if I toggle Global Undo in pref' to On - it behaves correctly - so maybe this the issue.

Hi - thanks for getting back so quickly. Video attached. @37s I press Ctrl Z and the unwrapping is undone - notice that the fur stays. Which I don't expect as a behaviour. Upon looking further - if I toggle Global Undo in pref' to On - it behaves correctly - so maybe this the issue.

Ok I was about to do a quick rant cause it just happened and I couldn't reproduce it at will, but it turns out I can. With global undo on.
Screenshot_20240404_204732.jpg

I am editing a curve with that setup, if I am in edit mode and change the radius then press undo, that change is ignored. Instead it undoes the last curve shape change I did. If I go in object mode and I change the radius then the radius is reverted with undo.

I also noticed this with the Shader Editor but I can't remember which mode caused it.

Ok I was about to do a quick rant cause it just happened and I couldn't reproduce it at will, but it turns out I can. With global undo on. ![Screenshot_20240404_204732.jpg](/attachments/33f58583-4751-400f-a064-068167cd78d7) I am editing a curve with that setup, if I am in edit mode and change the radius then press undo, that change is ignored. Instead it undoes the last curve shape change I did. If I go in object mode and I change the radius then the radius is reverted with undo. I also noticed this with the Shader Editor but I can't remember which mode caused it.

For me, this problem would be more expected to happen with global undo OFF.

Just to check if that is the case, @HotKnife, can you try with Factory Settings?

Go to File → Defaults → Load Factory Settings and then see if you still can reproduce this issue.

For me, this problem would be more expected to happen with global undo OFF. Just to check if that is the case, @HotKnife, can you try with Factory Settings? Go to File → Defaults → Load Factory Settings and then see if you still can reproduce this issue.
Germano Cavalcante added
Status
Needs Information from User
and removed
Status
Needs Triage
labels 2024-04-04 21:05:09 +02:00

For me, this problem would be more expected to happen with global undo OFF.

Just to check if that is the case, @HotKnife, can you try with Factory Settings?

Go to File → Defaults → Load Factory Settings and then see if you still can reproduce this issue.

My particular example with the curve and geometry nodes also happens with factory settings and global undo. I'm curious to see what HotKnife says for his example.

I added a blend file in case you want to test it. Just move the curve points a few times, edit the radius a few times then ctrl + z

> For me, this problem would be more expected to happen with global undo OFF. > > Just to check if that is the case, @HotKnife, can you try with Factory Settings? > > Go to File → Defaults → Load Factory Settings and then see if you still can reproduce this issue. My particular example with the curve and geometry nodes also happens with factory settings and global undo. I'm curious to see what HotKnife says for his example. I added a blend file in case you want to test it. Just move the curve points a few times, edit the radius a few times then ctrl + z
Author

Hi - with Factory Settings - It doesn't reproduce.
If I then turn Global Undo OFF. Restart B' - the problem reproduces.

Switching to Weight Painting also provides odd results.

  1. Cube.
  2. Switch to Weight Paint.
  3. Ctrl Z
    Result : Mode changes to Edit Mesh mode & all Weight painting is gone. (this is with Global Undo OFF)
Hi - with Factory Settings - It doesn't reproduce. If I then turn Global Undo OFF. Restart B' - the problem reproduces. Switching to Weight Painting also provides odd results. 1. Cube. 2. Switch to Weight Paint. 3. Ctrl Z Result : Mode changes to Edit Mesh mode & all Weight painting is gone. (this is with Global Undo OFF)
Member

Hi, looks like curve sculpt mode actions are written in memfile. With global undo turned off, this behavior is expected (no undo steps are generated)
Not a bug, closing.

Hi, looks like curve sculpt mode actions are written in memfile. With global undo turned off, this behavior is expected (no undo steps are generated) Not a bug, closing.
Blender Bot added
Status
Archived
and removed
Status
Needs Information from User
labels 2024-05-10 11:14:24 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#120251
No description provided.