GPv3: Make new strokes selected after operators (copy/paste etc.) #120291

New Issue

Lukas Tönne · 2024-04-05T11:14:34+02:00

Lukas Tönne commented

2024-04-05 11:14:34 +02:00

Paste operator and others deselect everything before creating new strokes, but don't make newly added strokes selected.

Lukas Tönne added the

Type

To Do

label 2024-04-05 11:14:34 +02:00

Lukas Tönne added this to the Grease Pencil project 2024-04-05 11:14:36 +02:00

Pratik Borhade commented

2024-04-05 12:22:35 +02:00

I can confirm. From a quick look, this seems to happen when the all the strokes (from a drawing) are selected for copy/pasting. I think .selection attribute is removed when everything is selected?

I can confirm. From a quick look, this seems to happen when the all the strokes (from a drawing) are selected for copy/pasting. I think `.selection` attribute is removed when everything is selected?

Sietse Brouwer commented

2024-04-05 21:37:30 +02:00

@PratikPB2123 You are completely right. That's the mistake I made in the copy/paste code: I assumed there was always a .selection attribute already on the strokes at the clipboard (since you copy selected strokes), so no need to set the attribute again when pasting. But that is not the case when all strokes are selected. Because of that slightly odd and easy to forget 'When there is no selection attribute, everything is selected' optimization.

@PratikPB2123 You are completely right. That's the mistake I made in the copy/paste code: I assumed there was always a `.selection` attribute already on the strokes at the clipboard (since you copy _selected_ strokes), so no need to set the attribute again when pasting. But that is not the case when all strokes are selected. Because of that slightly odd and easy to forget 'When there is no selection attribute, everything is selected' optimization.

Pratik Borhade commented

2024-04-07 11:07:23 +02:00

@SietseB hi, so do we have to handle this .selection attribute case in paste operator? Maybe just fill the range with the help of pasted_curves_range (this is for strokes, we can create similar for points) after joining geometry?

@SietseB hi, so do we have to handle this `.selection` attribute case in paste operator? Maybe just fill the range with the help of `pasted_curves_range` (this is for strokes, we can create similar for points) after joining geometry?

Pratik Borhade commented

2024-04-07 11:30:37 +02:00

Another issue I spotted about "selection". When paste operator is called, only the ".selection" attribute array of active drawing is set to false: https://projects.blender.org/blender/blender/src/branch/main/source/blender/editors/grease_pencil/intern/grease_pencil_edit.cc#L2242-L2247
I expect it to be false for all the drawing at current scene frame.

Another issue I spotted about "selection". When paste operator is called, only the ".selection" attribute array of active drawing is set to false: https://projects.blender.org/blender/blender/src/branch/main/source/blender/editors/grease_pencil/intern/grease_pencil_edit.cc#L2242-L2247 I expect it to be false for all the drawing at current scene frame.

Pratik Borhade commented

2024-04-07 11:51:10 +02:00

BTW, fix for above problem: !120363

Sietse Brouwer commented

2024-04-09 00:00:10 +02:00

@PratikPB2123 Making the pasted strokes selected, is probably easiest to set the .selection state of the strokes/points on the clipboard, before joining the geometries. Then you don't have to worry about ranges at all.
Something like:

bke::GSpanAttributeWriter selection_in_clipboard = ed::curves::ensure_selection_attribute(
    clipboard.curves, selection_domain, CD_PROP_BOOL);
ed::curves::fill_selection_true(selection_in_clipboard.span);
selection_in_clipboard.finish();

@PratikPB2123 Making the pasted strokes selected, is probably easiest to set the `.selection` state of the strokes/points on the clipboard, before joining the geometries. Then you don't have to worry about ranges at all. Something like: ```cpp bke::GSpanAttributeWriter selection_in_clipboard = ed::curves::ensure_selection_attribute( clipboard.curves, selection_domain, CD_PROP_BOOL); ed::curves::fill_selection_true(selection_in_clipboard.span); selection_in_clipboard.finish(); ```

Pratik Borhade commented

2024-04-12 14:09:26 +02:00

Hi, this indeed worked but "after joining geometries".
fill_selection_true is not required because ensure_selection_attribute itself will create a new array filled with 01 if attribute does not exists.

Can you make a PR? 🙂

Hi, this indeed worked but "after joining geometries". `fill_selection_true` is not required because `ensure_selection_attribute` itself will create a new array filled with `01` if attribute does not exists. Can you make a PR? 🙂

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

GPv3: Make new strokes selected after operators (copy/paste etc.) #120291