GPv3: Copy & paste sets stroke hardness to zero if not initialized #120297

New Issue

Lukas Tönne · 2024-04-05T13:18:25+02:00

Lukas Tönne commented

2024-04-05 13:18:25 +02:00

Blender Version
Broken: 4.2
Worked: -

Short description of error
Copying the default stroke into a GPv3 object with existing strokes sets the pasted stroke hardness to zero.

Exact steps for others to reproduce the error

Add a default "Stroke" grease pencil object. This has no hardness attribute, but uses the default of 1.0.
Add an empty grease pencil object and draw some strokes in it. This writes a value of 1.0 to the hardness attribute.
Copy & paste the stroke from the 1st into the 2nd object. The copied stroke is very thin, with a hardness of 0.0.

The reason is that 1.0 is the implicit default value for hardness, but the join_geometries method does not know this. When copying into the 2nd object it chooses a default value of 0.0 for the hardness attribute of the copied stroke.

Solution for now can be to check for known non-zero-default attributes like hardness before pasting, and then initialize the pasted stroke attributes explicitly.

**Blender Version** Broken: 4.2 Worked: - **Short description of error** Copying the default stroke into a GPv3 object with existing strokes sets the pasted stroke hardness to zero. **Exact steps for others to reproduce the error** 1. Add a default "Stroke" grease pencil object. This has no `hardness` attribute, but uses the default of 1.0. 2. Add an empty grease pencil object and draw some strokes in it. This writes a value of 1.0 to the hardness attribute. 3. Copy & paste the stroke from the 1st into the 2nd object. The copied stroke is very thin, with a hardness of 0.0. The reason is that 1.0 is the implicit default value for hardness, but the `join_geometries` method does not know this. When copying into the 2nd object it chooses a default value of 0.0 for the hardness attribute of the copied stroke. Solution for now can be to check for known non-zero-default attributes like hardness before pasting, and then initialize the pasted stroke attributes explicitly. ![image](/attachments/8d2d5043-12c6-4c37-aaf9-3b2d1856ed77)

image.png

230 KiB

Lukas Tönne added the

labels 2024-04-05 13:18:26 +02:00

Lukas Tönne added this to the Grease Pencil project 2024-04-05 13:18:28 +02:00

Pratik Borhade commented