Regression: Eyedropper on Colour Ramp flag crash to desktop #120302

New Issue

Closed

opened 2024-04-05 14:44:29 +02:00 by Erindale · 4 comments

Erindale commented

2024-04-05 14:44:29 +02:00

System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3080/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 551.86

Blender Version
Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-02-23 23:00, hash: 06d3627c4398
Worked: version: 4.2.0 Alpha, branch: main, commit date: 2024-02-09 09:37, hash: e20b2d2fb947

caused by c5d855b497

Short description of error
When hovering cursor over a colour ramp flag in both geo nodes and shaders and pressing E (for eyedropper) blender will crash to desktop

Exact steps for others to reproduce the error
Happens even in a completely new file with just a disconnected color ramp node.

**System Information** Operating system: Windows-10-10.0.22000-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3080/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 551.86 **Blender Version** Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-02-23 23:00, hash: `06d3627c4398` Worked: version: 4.2.0 Alpha, branch: main, commit date: 2024-02-09 09:37, hash: `e20b2d2fb947` caused by c5d855b497fdacaa7f38f630c3d10e9e65e4f27e **Short description of error** When hovering cursor over a colour ramp flag in both geo nodes and shaders and pressing E (for eyedropper) blender will crash to desktop **Exact steps for others to reproduce the error** Happens even in a completely new file with just a disconnected color ramp node.

Erindale added the

labels 2024-04-05 14:44:30 +02:00

Iliya Katushenock added the

label 2024-04-05 14:46:49 +02:00

Iliya Katushenock changed title from ~~Eyedropper on Colour Ramp flag crash to desktop~~ to Regression: Eyedropper on Colour Ramp flag crash to desktop

2024-04-05 15:06:57 +02:00

Iliya Katushenock added this to the 4.2 LTS milestone 2024-04-05 15:15:12 +02:00

Iliya Katushenock added

and removed

labels 2024-04-05 15:15:22 +02:00

Iliya Katushenock commented

2024-04-05 15:15:58 +02:00

Member

Not sure if this feature was correct before, but now its crash.

Not sure if this feature was correct before, but now its crash.

Harley Acheson commented

2024-04-05 18:06:33 +02:00

Member

I can make it not crash, but I'm a bit confused about the "flag" part of "hovering cursor over a colour ramp flag".

What I mean is that there doesn't appear to be functionality for hovering over a "color stop" (house-shaped thing), pressing "E" to change that stop's color. It appears to treat hovering over any part of the ramp the same, not treating the stops differently.

So pressing "E" is no different from selecting "Eyedropper" from the "˅" menu. With that though you can basically get two things. You can click on a single color and you will then have a ramp containing only a single color stop with that color. Or you can drag over a range of colors and it will replace your existing ramp with a new one containing multiple stops for the colors in the range that you dragged over.

So I can fix this so that it doesn't crash and you get the intended behavior, but it might not be the behavior you are expecting.

I can make it not crash, but I'm a bit confused about the "flag" part of "hovering cursor over a colour ramp flag". What I mean is that there doesn't appear to be functionality for hovering over a "color stop" (house-shaped thing), pressing "E" to change that stop's color. It appears to treat hovering over any part of the ramp the same, not treating the stops differently. So pressing "E" is no different from selecting "Eyedropper" from the "˅" menu. With that though you can basically get two things. You can click on a single color and you will then have a ramp containing only a single color stop with that color. Or you can drag over a range of colors and it will replace your existing ramp with a new one containing multiple stops for the colors in the range that you dragged over. So I can fix this so that it doesn't crash and you get the intended behavior, but it might not be the behavior you are expecting.

Ray molenkamp commented

2024-04-05 18:25:27 +02:00

Member

caused by c5d855b497 eyedropper_colorband_init wasn't updated for the change from UI_but_funcN_set to UI_but_func_set in colorband_buttons_layout so it's now null dereffing but->func_argN

caused by c5d855b497fdacaa7f38f630c3d10e9e65e4f27e `eyedropper_colorband_init` wasn't updated for the change from `UI_but_funcN_set` to `UI_but_func_set` in `colorband_buttons_layout` so it's now null dereffing `but->func_argN`

Harley Acheson referenced a pull request that will close this issue

2024-04-05 20:37:28 +02:00

Fix #120302: Crash Using Eyedropper on Color Ramp #120323

Philipp Oeser commented

2024-04-08 09:08:31 +02:00

Member

caused by c5d855b497 eyedropper_colorband_init wasn't updated for the change from UI_but_funcN_set to UI_but_func_set in colorband_buttons_layout so it's now null dereffing but->func_argN

CC @HooglyBoogly

> caused by c5d855b497fdacaa7f38f630c3d10e9e65e4f27e `eyedropper_colorband_init` wasn't updated for the change from `UI_but_funcN_set` to `UI_but_func_set` in `colorband_buttons_layout` so it's now null dereffing `but->func_argN` CC @HooglyBoogly

Hans Goudey referenced this issue from a commit

2024-04-17 18:53:02 +02:00

Fix #120302: Color Ramp eyedropper update crash

Hans Goudey closed this issue

2024-04-17 18:53:03 +02:00

Blender Bot added

and removed

labels 2024-04-17 18:53:06 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

5 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#120302

No description provided.