VSE: Clip Strip UI not updated to 2.79+, is missing data-block selector and is missing documentation #120357

Closed
opened 2024-04-07 09:47:59 +02:00 by tintwotin · 6 comments

System Information
Operating system: Windows-10-10.0.22631-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 551.61

Blender Version
Broken: version: 4.1.0 Alpha, branch: main, commit date: 2024-01-11 00:18, hash: d0359d066db9
Worked: (newest version of Blender that worked as expected)

Short description of error
The Clip Strip properties are not placed into a strip type specific sub panel like all other VSE strip types.

Ex. Scene Strip:
image

Currently, the Clip Strip properties are placed in the Video sub-panel:
image
Users will never find these options in the Video panel, since strip type specific properties are placed in the first sub panel for that strip type.

  • The words "Tracker" and "Distortion" are not placed in a 2.79+ way.
  • This design makes it look like Reverse Frames is a part of "Distortion", which it isn't.

So, the expected position of the Clip Strip properties would be in a Clip Strip dedicated sub panel placed as the first panel like ex. the Scene strip properties.

To be in consistency with ex. the Mask strip, a data-block selector could be considered added to the panel:
image

The Mask strip is also exposing the original frame range. The Clip strip could also expose these values, but in the Time panel in consistency with the Scene strip, it should be exposed in the Time panel:
image

Also, the Clip Strip properties are missing documentation:
image
https://docs.blender.org/manual/en/4.1/video_editing/edit/montage/strips/clip.html

The options are not self explained, since nothing happens when checkmarking these options. In order for them to do anything, the user will have to figure how to set up the Movie Clip editor, accordingly. The documentation could/should guide the users to where to find information to how to use these functions successfully.

**System Information** Operating system: Windows-10-10.0.22631-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 551.61 **Blender Version** Broken: version: 4.1.0 Alpha, branch: main, commit date: 2024-01-11 00:18, hash: `d0359d066db9` Worked: (newest version of Blender that worked as expected) **Short description of error** The Clip Strip properties are not placed into a strip type specific sub panel like all other VSE strip types. Ex. Scene Strip: ![image](/attachments/2812e62f-6d70-451e-b979-e46bff36d904) Currently, the Clip Strip properties are placed in the Video sub-panel: ![image](/attachments/d9a0d9a5-f071-45ad-8a96-4193048d07de) Users will never find these options in the Video panel, since strip type specific properties are placed in the first sub panel for that strip type. - The words "Tracker" and "Distortion" are not placed in a 2.79+ way. - This design makes it look like Reverse Frames is a part of "Distortion", which it isn't. So, the expected position of the Clip Strip properties would be in a Clip Strip dedicated sub panel placed as the first panel like ex. the Scene strip properties. To be in consistency with ex. the Mask strip, a data-block selector could be considered added to the panel: ![image](/attachments/d20467a7-ba68-410d-85b4-feed2eff90df) The Mask strip is also exposing the original frame range. The Clip strip could also expose these values, but in the Time panel in consistency with the Scene strip, it should be exposed in the Time panel: ![image](/attachments/6e77cf55-b560-45f9-a510-17f613e63323) Also, the Clip Strip properties are missing documentation: ![image](/attachments/6bed3ee8-0422-4729-9b09-1f9a7e8879d9) https://docs.blender.org/manual/en/4.1/video_editing/edit/montage/strips/clip.html The options are not self explained, since nothing happens when checkmarking these options. In order for them to do anything, the user will have to figure how to set up the Movie Clip editor, accordingly. The documentation could/should guide the users to where to find information to how to use these functions successfully.
tintwotin added the
Type
Report
Status
Needs Triage
Priority
Normal
labels 2024-04-07 09:48:00 +02:00

Also, the Clip Strip properties are missing documentation:
image
https://docs.blender.org/manual/en/4.1/video_editing/edit/montage/strips/clip.html

Please, send such things in related repositories: https://projects.blender.org/blender/blender-manual/issues

> Also, the Clip Strip properties are missing documentation: > image > https://docs.blender.org/manual/en/4.1/video_editing/edit/montage/strips/clip.html Please, send such things in related repositories: https://projects.blender.org/blender/blender-manual/issues
Iliya Katushenock added the
Interest
VFX & Video
Interest
Video Sequencer
labels 2024-04-07 13:18:38 +02:00
Author

@mod_moder This whole thing looks more than anything like an incomplete implementation in all areas, which has gone out of sight and out of mind. And as such, it can be seen as one full implementation task to complete it.

@mod_moder This whole thing looks more than anything like an incomplete implementation in all areas, which has gone out of sight and out of mind. And as such, it can be seen as one full implementation task to complete it.
Member

I'm sorry but I don't think I actually understood the problem... Here's what I see from the UI based on the report:

  • User can edit a clip in the clip editor.
  • User adds the edited clip to VSE.
  • User can choose to use the stabilized version or undistorted version of the clip with that particular strip in the vse.

If that's the case I don't really see much of a problem, maybe the UI needs a bit more clarification, like it should not be "Stablize 2D Clip", but "Use Stabilized Version". cc @pablovazquez

I'm sorry but I don't think I actually understood the problem... Here's what I see from the UI based on the report: - User can edit a clip in the clip editor. - User adds the edited clip to VSE. - User can choose to use the stabilized version or undistorted version of the clip with that particular strip in the vse. If that's the case I don't really see much of a problem, maybe the UI needs a bit more clarification, like it should not be "Stablize 2D Clip", but "Use Stabilized Version". cc @pablovazquez
YimingWu added the
Interest
User Interface
label 2024-04-08 04:57:07 +02:00
Member

Hi, I think @tintwotin expects the clip strip properties in dedicated panel instead of placing them inside "video" panel. Might make sense.
Forwarding to devs for the decision.

Hi, I think @tintwotin expects the clip strip properties in dedicated panel instead of placing them inside "video" panel. Might make sense. Forwarding to devs for the decision.
Author

Just to make it clear:

Movie Clip strip properties should have a sub panel on top like all other strip types, and it should include a data-block selector. All things, to make it in consistency with all other strip types.
image

Also, it should have the original range exposed in the Time panel(in consistency with ex. Scene strip types):
image

NB. MovieClipSequence is missing the "clip" data-block property.

class SEQUENCER_PT_movie_clip(SequencerButtonsPanel, Panel):
    bl_label = "Movie Clip"
    bl_options = {'DEFAULT_CLOSED'}
    bl_category = "Strip"

    @classmethod
    def poll(cls, context):
        if not cls.has_sequencer(context):
            return False

        strip = context.active_sequence_strip
        if not strip:
            return False

        return strip.type =='MOVIECLIP'
        
    def draw(self, context):
        layout = self.layout
        layout.use_property_split = True
        layout.use_property_decorate = False
        
        strip = context.active_sequence_strip

        layout.active = not strip.mute

        if strip.type == 'MOVIECLIP':
            # Data-block selector can't be implemented bc MovieClipSequence is missing the "clip" data-block property. 
            col = layout.column(heading="Use")
            col.prop(strip, "stabilize2d", text="2D Stabilized Clip")
            col.prop(strip, "undistort", text="Undestorted Clip")

Just to make it clear: Movie Clip strip properties should have a sub panel on top like all other strip types, and it should include a data-block selector. All things, to make it in consistency with all other strip types. ![image](/attachments/36149aaf-38e4-44ea-8f7d-5010f0dbbd7c) Also, it should have the original range exposed in the Time panel(in consistency with ex. Scene strip types): ![image](/attachments/7125f8c1-36f5-4581-ad88-f9e2d11c0b6d) NB. MovieClipSequence is missing the "clip" data-block property. ``` class SEQUENCER_PT_movie_clip(SequencerButtonsPanel, Panel): bl_label = "Movie Clip" bl_options = {'DEFAULT_CLOSED'} bl_category = "Strip" @classmethod def poll(cls, context): if not cls.has_sequencer(context): return False strip = context.active_sequence_strip if not strip: return False return strip.type =='MOVIECLIP' def draw(self, context): layout = self.layout layout.use_property_split = True layout.use_property_decorate = False strip = context.active_sequence_strip layout.active = not strip.mute if strip.type == 'MOVIECLIP': # Data-block selector can't be implemented bc MovieClipSequence is missing the "clip" data-block property. col = layout.column(heading="Use") col.prop(strip, "stabilize2d", text="2D Stabilized Clip") col.prop(strip, "undistort", text="Undestorted Clip") ```

Implemented in 6079b16d52, closing.

Implemented in 6079b16d5200a213804b084b083ac44bfdf9eb41, closing.
Blender Bot added
Status
Archived
and removed
Status
Needs Info from Developers
labels 2024-06-14 18:02:49 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#120357
No description provided.