blender
/
blender
133
398
Fork 579
Code Issues 6.3k Pull Requests 747 Projects 19 Wiki Activity

VSE: Clip Strip UI not updated to 2.79+, is missing data-block selector and is missing documentation #120357

New Issue
Open
opened 2024-04-07 09:47:59 +02:00 by tintwotin · 5 comments
tintwotin commented 2024-04-07 09:47:59 +02:00
Copy Link

System Information
Operating system: Windows-10-10.0.22631-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 551.61

Blender Version
Broken: version: 4.1.0 Alpha, branch: main, commit date: 2024-01-11 00:18, hash: d0359d066db9
Worked: (newest version of Blender that worked as expected)

Short description of error
The Clip Strip properties are not placed into a strip type specific sub panel like all other VSE strip types.

Ex. Scene Strip:
image

Currently, the Clip Strip properties are placed in the Video sub-panel:
image
Users will never find these options in the Video panel, since strip type specific properties are placed in the first sub panel for that strip type.

  • The words "Tracker" and "Distortion" are not placed in a 2.79+ way.
  • This design makes it look like Reverse Frames is a part of "Distortion", which it isn't.

So, the expected position of the Clip Strip properties would be in a Clip Strip dedicated sub panel placed as the first panel like ex. the Scene strip properties.

To be in consistency with ex. the Mask strip, a data-block selector could be considered added to the panel:
image

The Mask strip is also exposing the original frame range. The Clip strip could also expose these values, but in the Time panel in consistency with the Scene strip, it should be exposed in the Time panel:
image

Also, the Clip Strip properties are missing documentation:
image
https://docs.blender.org/manual/en/4.1/video_editing/edit/montage/strips/clip.html

The options are not self explained, since nothing happens when checkmarking these options. In order for them to do anything, the user will have to figure how to set up the Movie Clip editor, accordingly. The documentation could/should guide the users to where to find information to how to use these functions successfully.

**System Information** Operating system: Windows-10-10.0.22631-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 551.61 **Blender Version** Broken: version: 4.1.0 Alpha, branch: main, commit date: 2024-01-11 00:18, hash: `d0359d066db9` Worked: (newest version of Blender that worked as expected) **Short description of error** The Clip Strip properties are not placed into a strip type specific sub panel like all other VSE strip types. Ex. Scene Strip: ![image](/attachments/2812e62f-6d70-451e-b979-e46bff36d904) Currently, the Clip Strip properties are placed in the Video sub-panel: ![image](/attachments/d9a0d9a5-f071-45ad-8a96-4193048d07de) Users will never find these options in the Video panel, since strip type specific properties are placed in the first sub panel for that strip type. - The words "Tracker" and "Distortion" are not placed in a 2.79+ way. - This design makes it look like Reverse Frames is a part of "Distortion", which it isn't. So, the expected position of the Clip Strip properties would be in a Clip Strip dedicated sub panel placed as the first panel like ex. the Scene strip properties. To be in consistency with ex. the Mask strip, a data-block selector could be considered added to the panel: ![image](/attachments/d20467a7-ba68-410d-85b4-feed2eff90df) The Mask strip is also exposing the original frame range. The Clip strip could also expose these values, but in the Time panel in consistency with the Scene strip, it should be exposed in the Time panel: ![image](/attachments/6e77cf55-b560-45f9-a510-17f613e63323) Also, the Clip Strip properties are missing documentation: ![image](/attachments/6bed3ee8-0422-4729-9b09-1f9a7e8879d9) https://docs.blender.org/manual/en/4.1/video_editing/edit/montage/strips/clip.html The options are not self explained, since nothing happens when checkmarking these options. In order for them to do anything, the user will have to figure how to set up the Movie Clip editor, accordingly. The documentation could/should guide the users to where to find information to how to use these functions successfully.
image.png
4.8 KiB
image.png
8.6 KiB
image.png
11 KiB
image.png
10 KiB
image.png
7.0 KiB
tintwotin added the
Type
Report
Status
Needs Triage
Priority
Normal
 labels 2024-04-07 09:48:00 +02:00
Iliya Katushenock commented 2024-04-07 13:18:27 +02:00
Member
Copy Link

Also, the Clip Strip properties are missing documentation:
image
https://docs.blender.org/manual/en/4.1/video_editing/edit/montage/strips/clip.html

Please, send such things in related repositories: https://projects.blender.org/blender/blender-manual/issues

> Also, the Clip Strip properties are missing documentation: > image > https://docs.blender.org/manual/en/4.1/video_editing/edit/montage/strips/clip.html Please, send such things in related repositories: https://projects.blender.org/blender/blender-manual/issues
Iliya Katushenock added the
Interest
VFX & Video
Interest
Video Sequencer
 labels 2024-04-07 13:18:38 +02:00
tintwotin commented 2024-04-07 17:38:22 +02:00
Author
Copy Link

@mod_moder This whole thing looks more than anything like an incomplete implementation in all areas, which has gone out of sight and out of mind. And as such, it can be seen as one full implementation task to complete it.

@mod_moder This whole thing looks more than anything like an incomplete implementation in all areas, which has gone out of sight and out of mind. And as such, it can be seen as one full implementation task to complete it.
YimingWu commented 2024-04-08 04:56:54 +02:00
Member
Copy Link

I'm sorry but I don't think I actually understood the problem... Here's what I see from the UI based on the report:

  • User can edit a clip in the clip editor.
  • User adds the edited clip to VSE.
  • User can choose to use the stabilized version or undistorted version of the clip with that particular strip in the vse.

If that's the case I don't really see much of a problem, maybe the UI needs a bit more clarification, like it should not be "Stablize 2D Clip", but "Use Stabilized Version". cc @pablovazquez

I'm sorry but I don't think I actually understood the problem... Here's what I see from the UI based on the report: - User can edit a clip in the clip editor. - User adds the edited clip to VSE. - User can choose to use the stabilized version or undistorted version of the clip with that particular strip in the vse. If that's the case I don't really see much of a problem, maybe the UI needs a bit more clarification, like it should not be "Stablize 2D Clip", but "Use Stabilized Version". cc @pablovazquez
YimingWu added the
Interest
User Interface
 label 2024-04-08 04:57:07 +02:00
Pratik Borhade commented 2024-04-08 06:47:55 +02:00
Member
Copy Link

Hi, I think @tintwotin expects the clip strip properties in dedicated panel instead of placing them inside "video" panel. Might make sense.
Forwarding to devs for the decision.

Hi, I think @tintwotin expects the clip strip properties in dedicated panel instead of placing them inside "video" panel. Might make sense. Forwarding to devs for the decision.
tintwotin commented 2024-04-08 10:00:40 +02:00
Author
Copy Link

Just to make it clear:

Movie Clip strip properties should have a sub panel on top like all other strip types, and it should include a data-block selector. All things, to make it in consistency with all other strip types.
image

Also, it should have the original range exposed in the Time panel(in consistency with ex. Scene strip types):
image

NB. MovieClipSequence is missing the "clip" data-block property.

class SEQUENCER_PT_movie_clip(SequencerButtonsPanel, Panel):
    bl_label = "Movie Clip"
    bl_options = {'DEFAULT_CLOSED'}
    bl_category = "Strip"

    @classmethod
    def poll(cls, context):
        if not cls.has_sequencer(context):
            return False

        strip = context.active_sequence_strip
        if not strip:
            return False

        return strip.type =='MOVIECLIP'
        
    def draw(self, context):
        layout = self.layout
        layout.use_property_split = True
        layout.use_property_decorate = False
        
        strip = context.active_sequence_strip

        layout.active = not strip.mute

        if strip.type == 'MOVIECLIP':
            # Data-block selector can't be implemented bc MovieClipSequence is missing the "clip" data-block property. 
            col = layout.column(heading="Use")
            col.prop(strip, "stabilize2d", text="2D Stabilized Clip")
            col.prop(strip, "undistort", text="Undestorted Clip")
Just to make it clear: Movie Clip strip properties should have a sub panel on top like all other strip types, and it should include a data-block selector. All things, to make it in consistency with all other strip types. ![image](/attachments/36149aaf-38e4-44ea-8f7d-5010f0dbbd7c) Also, it should have the original range exposed in the Time panel(in consistency with ex. Scene strip types): ![image](/attachments/7125f8c1-36f5-4581-ad88-f9e2d11c0b6d) NB. MovieClipSequence is missing the "clip" data-block property. ``` class SEQUENCER_PT_movie_clip(SequencerButtonsPanel, Panel): bl_label = "Movie Clip" bl_options = {'DEFAULT_CLOSED'} bl_category = "Strip" @classmethod def poll(cls, context): if not cls.has_sequencer(context): return False strip = context.active_sequence_strip if not strip: return False return strip.type =='MOVIECLIP' def draw(self, context): layout = self.layout layout.use_property_split = True layout.use_property_decorate = False strip = context.active_sequence_strip layout.active = not strip.mute if strip.type == 'MOVIECLIP': # Data-block selector can't be implemented bc MovieClipSequence is missing the "clip" data-block property. col = layout.column(heading="Use") col.prop(strip, "stabilize2d", text="2D Stabilized Clip") col.prop(strip, "undistort", text="Undestorted Clip") ```
image.png
4.6 KiB
image.png
19 KiB
image.png
15 KiB
image.png
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
brush-assets-project
universal-scene-description
fix-121021
blender-v4.1-release
blender-v3.3-release
blender-v3.6-release
blender-v3.6-temp_wmoss_animrig_public
temp-sculpt-dyntopo
gpencil-next
anim/animation-id-113594
blender-v4.0-release
blender-projects-basics
bridge-curves
sculpt-blender
asset-browser-frontend-split
asset-shelf
tmp-usd-python-mtl
tmp-usd-3.6
blender-v3.5-release
blender-v2.93-release
realtime-clock
sculpt-dev
bevelv2
xr-dev
v4.1.1
v3.6.11
v3.3.18
v4.1.0
v3.3.17
v3.6.10
v3.6.9
v3.3.16
v3.6.8
v3.6.7
v3.3.14
v4.0.2
v4.0.1
v4.0.0
v3.6.5
v3.3.12
v3.6.4
v3.6.3
v3.3.11
v3.6.2
v3.3.10
v3.6.1
v3.3.9
v3.6.0
v3.3.8
v3.3.7
v2.93.18
v3.5.1
v3.3.6
v2.93.17
v3.5.0
v2.93.16
v3.3.5
v3.3.4
v2.93.15
v2.93.14
v3.3.3
v2.93.13
v2.93.12
v3.4.1
v3.3.2
v3.4.0
v3.3.1
v2.93.11
v3.3.0
v3.2.2
v2.93.10
v3.2.1
v3.2.0
v2.83.20
v2.93.9
v3.1.2
v3.1.1
v3.1.0
v2.83.19
v2.93.8
v3.0.1
v2.93.7
v3.0.0
v2.93.6
v2.93.5
v2.83.18
v2.93.4
v2.93.3
v2.83.17
v2.93.2
v2.93.1
v2.83.16
v2.93.0
v2.83.15
v2.83.14
v2.83.13
v2.92.0
v2.83.12
v2.91.2
v2.83.10
v2.91.0
v2.83.9
v2.83.8
v2.83.7
v2.90.1
v2.83.6.1
v2.83.6
v2.90.0
v2.83.5
v2.83.4
v2.83.3
v2.83.2
v2.83.1
v2.83
v2.82a
v2.82
v2.81a
v2.81
v2.80
v2.80-rc3
v2.80-rc2
v2.80-rc1
v2.79b
v2.79a
v2.79
v2.79-rc2
v2.79-rc1
v2.78c
v2.78b
v2.78a
v2.78
v2.78-rc2
v2.78-rc1
v2.77a
v2.77
v2.77-rc2
v2.77-rc1
v2.76b
v2.76a
v2.76
v2.76-rc3
v2.76-rc2
v2.76-rc1
v2.75a
v2.75
v2.75-rc2
v2.75-rc1
v2.74
v2.74-rc4
v2.74-rc3
v2.74-rc2
v2.74-rc1
v2.73a
v2.73
v2.73-rc1
v2.72b
2.72b
v2.72a
v2.72
v2.72-rc1
v2.71
v2.71-rc2
v2.71-rc1
v2.70a
v2.70
v2.70-rc2
v2.70-rc
v2.69
v2.68a
v2.68
v2.67b
v2.67a
v2.67
v2.66a
v2.66
v2.65a
v2.65
v2.64a
v2.64
v2.63a
v2.63
v2.61
v2.60a
v2.60
v2.59
v2.58a
v2.58
v2.57b
v2.57a
v2.57
v2.56a
v2.56
v2.55
v2.54
v2.53
v2.52
v2.51
v2.50
v2.49b
v2.49a
v2.49
v2.48a
v2.48
v2.47
v2.46
v2.45
v2.44
v2.43
v2.42a
v2.42
v2.41
v2.40
v2.37a
v2.37
v2.36
v2.35a
v2.35
v2.34
v2.33a
v2.33
v2.32
v2.31a
v2.31
v2.30
v2.28c
v2.28a
v2.28
v2.27
v2.26
v2.25
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#120357
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?