The "Show Retiming Keys" should not be exposed in the Time panel as it is unrelated. #120364
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#120364
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Windows-10-10.0.22631-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 551.61
Blender Version
Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-04-01 23:26, hash:
03d728e281aaWorked: (newest version of Blender that worked as expected)
Short description of error
The "Show Retiming Keys" should not be exposed in the Time panel, as it is unrelated. The Time panel is for time related strip properties, and not for what to display on the strips.
The Overlay Dropdown is for selecting what to expose in the Sequencer area, such as retiming keys, where it is already exposed:
Expected design: Keep the Time panel strictly for time value related properties, and therefore remove the "Show Retiming Keys" bool from the Time panel.
But "Show Retiming Keys" is a strip property, it controls whether to show the retiming key for that particular strip, while the option in the overlay controls globally whether all retiming keys are shown 🤔
It still doesn't belong in the Time panel. If it is a pr. strip setting, it should be implemented in consistency with how the display Waveform is implemented as a pr. strip setting:
Forwarding to @iss for the decision.
@tintwotin If I understand correctly, do you suggest to hide "show retiming keys" checkbox in sidebar if retiming overlay is disabled?
If it should be in consistency with the Sound strip, the Video sub-panel should be the topmost sub-panel, and the retime bool could be placed inside of that. If there are plans to expose more Retime options in the sidebar ex. key and interpolation properties in a list(like the Geaph Editor), Retime options sould go into a dedicated subpanel.
Btw. if there are no ambitions of reversing the trimmed frames and not the frames of the full source strip, the Reverse Frames option from the Video subpanel should be moved into the Source subpanel, so it'll be clear that it is for reversing the frames of the input source.
As it currently is very limited what is exposed in the API of the Retime properties, in this example only the Draw Retime is placed and then the frame position of the retime control points:
Code: https://gist.github.com/tin2tin/3f0afc8dede0b145a2553103a086ed32
@tintwotin I still think, that this is unnecessary. If something like this would be implemented, a list of keys like shape keys seems to be more appropriate. But then a key would have 1 single property.
The main thing is having retiming properties in a retiming subpanel:
You know what retime elements are lacking proper exposure and optional fine-grained editing. And with a dedicated subpanel, you'll have a place to expose these elements in consistency with any other property in Blender.