Animation/Drivers on Bone Collections created in 4.0 break in 4.1 #120447

New Issue

Frozen_Death_Knight · 2024-04-10T00:51:54+02:00

2024-04-10 00:51:54 +02:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 551.23

Blender Version
Broken: version: 4.1.0, branch: blender-v4.1-release, commit date: 2024-03-25 20:42, hash: 40a5e739e270
Worked: 4.0

Short description of error

I have an old rig in 4.0 that I opened in 4.1 when it got released. I noticed that the old 4.0 drivers that controlled the visibility of bone layers became broken in the new system. There are multiple issues with it:

The drivers work when opening the file in 4.1, but the purple driver highlights are no longer there.

4.0	4.1

You also can't edit the old drivers using Edit Driver, because it no longer exists.

4.0	4.1

Finally, the new hierarchy system by having a Bone Layer parenting system. It completely breaks the old drivers when dragging them into the hierarchy.

The old driver still exists when you unparent the old layer from the new 4.1 one.

Exact steps for others to reproduce the error

Create a Bone Layer with a driver that determines visibility in 4.0.
Open the file and check the lack of purple colour and the inability to use Edit Driver.
Add a new Bone Layer and parent the old layer to the new one.
Use the switch for toggling on and off the 4.0 Bone Layer. The driver is now broken.
Unparent the old Bone Layer. The driver should work again now.

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 551.23 **Blender Version** Broken: version: 4.1.0, branch: blender-v4.1-release, commit date: 2024-03-25 20:42, hash: `40a5e739e270` Worked: 4.0 **Short description of error** I have an old rig in 4.0 that I opened in 4.1 when it got released. I noticed that the old 4.0 drivers that controlled the visibility of bone layers became broken in the new system. There are multiple issues with it: 1) The drivers work when opening the file in 4.1, but the purple driver highlights are no longer there. | 4.0 | 4.1 | |-|-| | ![Skärmbild 2024-04-10 003602.png](/attachments/15e17e12-1d89-49ab-a844-4946908c5ff1) | ![Skärmbild 2024-04-10 003716.png](/attachments/831b4f16-7230-46ba-807f-41f6710ed95a) | 2) You also can't edit the old drivers using Edit Driver, because it no longer exists. | 4.0 | 4.1 | |-|-| | ![Skärmbild 2024-04-10 005010.png](/attachments/6546c2b6-1c46-4a65-a5e8-09d2086cd4d3) | ![Skärmbild 2024-04-10 003949.png](/attachments/11e16c35-d9e4-4e1d-a066-f674938869b8) | 3) Finally, the new hierarchy system by having a Bone Layer parenting system. It completely breaks the old drivers when dragging them into the hierarchy. ![Broken 4.0 Visibility Drivers 4.1 Bone Collections.gif](/attachments/e0f0e0e5-5917-4c96-950e-b326546db3ed) 4) The old driver still exists when you unparent the old layer from the new 4.1 one. **Exact steps for others to reproduce the error** 1) Create a Bone Layer with a driver that determines visibility in 4.0. 2) Open the file and check the lack of purple colour and the inability to use Edit Driver. 3) Add a new Bone Layer and parent the old layer to the new one. 4) Use the switch for toggling on and off the 4.0 Bone Layer. The driver is now broken. 5) Unparent the old Bone Layer. The driver should work again now.

Skärmbild 2024-04-10 003949.png

7.2 KiB

Skärmbild 2024-04-10 003716.png

40 KiB

Skärmbild 2024-04-10 005010.png

12 KiB

Skärmbild 2024-04-10 003602.png

35 KiB

Broken 4.0 Visibility Drivers 4.1 Bone Collections.gif

2.1 MiB

Frozen_Death_Knight added the

labels 2024-04-10 00:51:55 +02:00

Pratik Borhade commented

2024-04-10 04:48:23 +02:00

but the purple driver highlights are no longer there.

Hi, this has been fixed recently, see: !120298 / 129d5a1067

> but the purple driver highlights are no longer there. Hi, this has been fixed recently, see: !120298 / 129d5a106702b1d7328610b574da56c6e4e6f117

Pratik Borhade commented

2024-04-10 05:14:32 +02:00

You also can't edit the old drivers using Edit Driver, because it no longer exists.

Can confirm this. Require some versioning code to fix this.
cc @dr.sybren

> You also can't edit the old drivers using Edit Driver, because it no longer exists. Can confirm this. Require some versioning code to fix this. cc @dr.sybren

Pratik Borhade added

and removed

labels 2024-04-10 05:14:45 +02:00

Sybren A. Stüvel self-assigned this 2024-04-11 11:08:57 +02:00

Sybren A. Stüvel added this to the 4.1 milestone 2024-04-11 11:19:51 +02:00

Sybren A. Stüvel added

and removed

labels 2024-04-11 11:20:08 +02:00

Sybren A. Stüvel commented

2024-04-11 11:22:15 +02:00

You also can't edit the old drivers using Edit Driver, because it no longer exists.

I can't confirm this, as for me the drivers keep working and are also visible in the driver editor. Of course, since the property is now different (it uses .collections_all["name"] instead of .collections["name"]) you can't right-click and choose "Edit Driver", but the driver is still there and working, and still visible when you switch the editor to Drivers (Shift+F6):

Please confirm that this is indeed the case for you too, @Frozen_Death_Knight

In the mean time, I'll look into driver versioning code.

> You also can't edit the old drivers using Edit Driver, because it no longer exists. I can't confirm this, as for me the drivers keep working and are also visible in the driver editor. Of course, since the property is now different (it uses `.collections_all["name"]` instead of `.collections["name"]`) you can't right-click and choose "Edit Driver", but the driver is still there and working, and still visible when you switch the editor to Drivers (Shift+F6): ![Screenshot of Blender's driver editor](/attachments/94b02cc0-061f-4d4e-962e-af75495c3edd) Please confirm that this is indeed the case for you too, @Frozen_Death_Knight In the mean time, I'll look into driver versioning code.

image.png

186 KiB

Pratik Borhade commented

2024-04-11 11:35:34 +02:00

@dr.sybren hi, this happens when you open file from 4.0 in 4.1 (possibly drivers are not converted for the bone collection of new hierarchical structure)

Just open attached file in 4.0 (see driver is visible and can be edited from context menu)
Open same file in 4.1, context menu won't show "edit driver" option

@dr.sybren hi, this happens when you open file from 4.0 in 4.1 (possibly drivers are not converted for the bone collection of new hierarchical structure) - Just open attached file in 4.0 (see driver is visible and can be edited from context menu) - Open same file in 4.1, context menu won't show "edit driver" option

120447.blend

884 KiB

Pratik Borhade commented

2024-04-11 11:37:24 +02:00

Didn't see your edited message before posting 🙂

you can't right-click and choose "Edit Driver", but the driver is still there and working, and still visible when you switch the editor to Drivers (Shift+F6):

Yes, that's the case AFAICS

Didn't see your edited message before posting 🙂 > you can't right-click and choose "Edit Driver", but the driver is still there and working, and still visible when you switch the editor to Drivers (Shift+F6): Yes, that's the case AFAICS

👍 1

Sybren A. Stüvel changed title from ~~New Bone Collections system in 4.1 breaks visibility drivers from the old system (especially when put into an hierarchy)~~ to Drivers on Bone Collections created in 4.0 break in 4.1

2024-04-11 12:01:32 +02:00

Sybren A. Stüvel changed title from ~~Drivers on Bone Collections created in 4.0 break in 4.1~~ to Animation/Drivers on Bone Collections created in 4.0 break in 4.1

2024-04-11 12:11:16 +02:00

Sybren A. Stüvel referenced a pull request that will close this issue

2024-04-11 12:17:11 +02:00

Fix #120447: Anim/Drivers on Bone Collections created in 4.0 break in 4.1 #120514

Sybren A. Stüvel referenced this issue

2024-04-11 12:22:13 +02:00

4.1: Candidates for corrective releases #119631

Sybren A. Stüvel referenced this issue from a commit

2024-04-11 15:27:05 +02:00

Fix #120447: Anim/Drivers on Bone Collections created in 4.0 break in 4.1

Sybren A. Stüvel closed this issue

2024-04-11 15:27:06 +02:00