Blender crash when translating operator poll message #120759

New Issue

Damien Picard · 2024-04-18T02:15:23+02:00

Damien Picard commented

2024-04-18 02:15:23 +02:00

System Information
Operating system: Linux-6.5.0-27-generic-x86_64-with-glibc2.38 64 Bits, X11 UI
Graphics card: NVIDIA GeForce RTX 3060 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 545.29.06

Blender Version
Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-04-17 20:19, hash: 4666af64a6e4
Introduced in 5b9c176b68

Short description of error
When using a translated UI, hovering a disabled button a few times will result in a crash if it displays a poll message.

Exact steps for others to reproduce the error

Open the attached blend file and run the script to register an operator with a poll message
It appears in the View menu of the text editor
Hover it a few times, nothing happens
Set the translation to another language
Hover the button again, Blender crashes.

So I introduced this crash in 5b9c176b68 but only just discovered it. I’m not sure exactly why the memory gets corrupted, however not freeing the memory fixes the crash:

--- a/source/blender/blenkernel/intern/context.cc
+++ b/source/blender/blenkernel/intern/context.cc
@@ -1036,9 +1036,7 @@ const char *CTX_wm_operator_poll_msg_get(bContext *C, bool *r_free)
   bContextPollMsgDyn_Params *params = &C->wm.operator_poll_msg_dyn_params;
   if (params->get_fn != nullptr) {
     char *msg = params->get_fn(C, params->user_data);
-    if (msg != nullptr) {
-      *r_free = true;
-    }
+    *r_free = false;
     return msg;
   }

@mont29 Would this be the proper fix?

**System Information** Operating system: Linux-6.5.0-27-generic-x86_64-with-glibc2.38 64 Bits, X11 UI Graphics card: NVIDIA GeForce RTX 3060 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 545.29.06 **Blender Version** Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-04-17 20:19, hash: `4666af64a6e4` Introduced in 5b9c176b682c77545126a080c016c0b8b28ed0d5 **Short description of error** When using a translated UI, hovering a disabled button a few times will result in a crash if it displays a poll message. **Exact steps for others to reproduce the error** - Open the [attached blend file](/attachments/0c1dde18-3b0d-4143-a73c-1dc6051d1dc4) and run the script to register an operator with a poll message - It appears in the View menu of the text editor - Hover it a few times, nothing happens - Set the translation to another language - Hover the button again, Blender crashes. <video src="/attachments/52e9b327-ffd5-46ed-8c2b-3d74ee7a991e" title="blender_poll_message_translation_crash_.mp4" controls></video> ----- So I introduced this crash in 5b9c176b682c77545126a080c016c0b8b28ed0d5 but only just discovered it. I’m not sure exactly why the memory gets corrupted, however not freeing the memory fixes the crash: ```diff --- a/source/blender/blenkernel/intern/context.cc +++ b/source/blender/blenkernel/intern/context.cc @@ -1036,9 +1036,7 @@ const char *CTX_wm_operator_poll_msg_get(bContext *C, bool *r_free) bContextPollMsgDyn_Params *params = &C->wm.operator_poll_msg_dyn_params; if (params->get_fn != nullptr) { char *msg = params->get_fn(C, params->user_data); - if (msg != nullptr) { - *r_free = true; - } + *r_free = false; return msg; } ``` @mont29 Would this be the proper fix?

blender_poll_message_translation_crash.blend

89 KiB

blender_poll_message_translation_crash_.mp4

478 KiB

👀 1

Damien Picard added the