Empty Geonode Output Crashes When Connected to BSDF #120805

New Issue

sentharn · 2024-04-19T03:50:58+02:00

sentharn commented

2024-04-19 03:50:58 +02:00

System Information
Operating system: Windows-10-10.0.22631-SP0 64 Bits
Graphics card: Intel(R) Arc(TM) A770 Graphics Intel 4.6.0 - Build 31.0.101.5379

Blender Version
Broken: version: 4.1.1, branch: sentharn-custom, commit date: 2024-04-18 23:09, hash: efabad571b5e
Worked: (newest version of Blender that worked as expected)

Caused by 1cca960677

Short description of error
Connecting the attribute in this blend file to any of the inputs on Principled BSDF crashes it immediately.

Exact steps for others to reproduce the error
Connect the "UVs" group in the Shading editor to any of the Principled BSDF inputs.

This crash was originally reported to me by a user running Blender 4.1.1 on Linux with an NVidia GPU, so it is not a problem specific to my system. It has been verified by me.

It will only crash in Material Dev or Render Preview with Eevee renderer.

Freestyle is disabled. I don't know why Freestyle is showing up as the crash location. It may be a red herring.

Stacktrace:

	blender.exe!Freestyle::BlenderStrokeRenderer::RenderStrokeRep(Freestyle::StrokeRep * iStrokeRep) Line 422	C++
 	blender.exe!draw_update_uniforms(DRWShadingGroup * shgroup, DRWCommandsState * state, bool * use_tfeedback) Line 717	C++
 	blender.exe!draw_shgroup(DRWShadingGroup * shgroup, DRWState pass_state) Line 1025	C++
 	[Inline Frame] blender.exe!drw_draw_pass_ex(DRWPass * start_group, DRWShadingGroup * end_group, DRWShadingGroup *) Line 1217	C++
 	blender.exe!DRW_draw_pass(DRWPass * pass) Line 1258	C++
 	blender.exe!blender::draw::DRW_curves_update() Line 352	C++
 	blender.exe!DRW_draw_render_loop_ex(Depsgraph * depsgraph, RenderEngineType * engine_type, ARegion * region, View3D * v3d, GPUViewport * viewport, const bContext * evil_C) Line 1756	C++
 	blender.exe!DRW_draw_view(const bContext * C) Line 1630	C++
 	[Inline Frame] blender.exe!view3d_draw_view(const bContext *) Line 1580	C++
 	blender.exe!view3d_main_region_draw(const bContext * C, ARegion * region) Line 1617	C++
 	blender.exe!ED_region_do_draw(bContext * C, ARegion * region) Line 537	C++
 	blender.exe!wm_draw_window_offscreen(bContext * C, wmWindow * win, bool stereo) Line 1008	C++
 	blender.exe!wm_draw_window(bContext * C, wmWindow * win) Line 1177	C++
 	blender.exe!wm_draw_update(bContext * C) Line 1580	C++
 	blender.exe!WM_main(bContext * C) Line 636	C++
 	blender.exe!main(int argc, const char * * __formal) Line 578	C++
 	[External Code]

**System Information** Operating system: Windows-10-10.0.22631-SP0 64 Bits Graphics card: Intel(R) Arc(TM) A770 Graphics Intel 4.6.0 - Build 31.0.101.5379 **Blender Version** Broken: version: 4.1.1, branch: sentharn-custom, commit date: 2024-04-18 23:09, hash: `efabad571b5e` Worked: (newest version of Blender that worked as expected) Caused by 1cca96067781f569c6bced0c4f363d71781df092 **Short description of error** Connecting the attribute in this blend file to any of the inputs on Principled BSDF crashes it immediately. **Exact steps for others to reproduce the error** Connect the "UVs" group in the Shading editor to any of the Principled BSDF inputs. This crash was originally reported to me by a user running Blender 4.1.1 on Linux with an NVidia GPU, so it is not a problem specific to my system. It has been verified by me. It will only crash in Material Dev or Render Preview with Eevee renderer. Freestyle is disabled. I don't know why Freestyle is showing up as the crash location. It may be a red herring. Stacktrace: ``` blender.exe!Freestyle::BlenderStrokeRenderer::RenderStrokeRep(Freestyle::StrokeRep * iStrokeRep) Line 422 C++ blender.exe!draw_update_uniforms(DRWShadingGroup * shgroup, DRWCommandsState * state, bool * use_tfeedback) Line 717 C++ blender.exe!draw_shgroup(DRWShadingGroup * shgroup, DRWState pass_state) Line 1025 C++ [Inline Frame] blender.exe!drw_draw_pass_ex(DRWPass * start_group, DRWShadingGroup * end_group, DRWShadingGroup *) Line 1217 C++ blender.exe!DRW_draw_pass(DRWPass * pass) Line 1258 C++ blender.exe!blender::draw::DRW_curves_update() Line 352 C++ blender.exe!DRW_draw_render_loop_ex(Depsgraph * depsgraph, RenderEngineType * engine_type, ARegion * region, View3D * v3d, GPUViewport * viewport, const bContext * evil_C) Line 1756 C++ blender.exe!DRW_draw_view(const bContext * C) Line 1630 C++ [Inline Frame] blender.exe!view3d_draw_view(const bContext *) Line 1580 C++ blender.exe!view3d_main_region_draw(const bContext * C, ARegion * region) Line 1617 C++ blender.exe!ED_region_do_draw(bContext * C, ARegion * region) Line 537 C++ blender.exe!wm_draw_window_offscreen(bContext * C, wmWindow * win, bool stereo) Line 1008 C++ blender.exe!wm_draw_window(bContext * C, wmWindow * win) Line 1177 C++ blender.exe!wm_draw_update(bContext * C) Line 1580 C++ blender.exe!WM_main(bContext * C) Line 636 C++ blender.exe!main(int argc, const char * * __formal) Line 578 C++ [External Code] ```

UVCrash.blend

960 KiB

stacktrace1.jpg

212 KiB

sentharn added the

labels 2024-04-19 03:50:59 +02:00

YimingWu commented

2024-04-19 04:09:40 +02:00

Can confirm the crash on 4.1 and 4.2.

Apparently it doesn't crash in the freestyle code here, I'm not sure why it reported on yours as such.

Here's mine (I'm on linux)

GPU_vertbuf_bind_as_texture(blender::gpu::VertBuf * verts, int binding) (/home/yiming/Downloads/BlenderMain/blender/source/blender/gpu/intern/gpu_vertex_buffer.cc:341)
draw_update_uniforms(DRWShadingGroup * shgroup, DRWCommandsState * state, bool * use_tfeedback) (/home/yiming/Downloads/BlenderMain/blender/source/blender/draw/intern/draw_manager_exec.cc:716)
draw_shgroup(DRWShadingGroup * shgroup, DRWState pass_state) (/home/yiming/Downloads/BlenderMain/blender/source/blender/draw/intern/draw_manager_exec.cc:1023)
drw_draw_pass_ex(DRWPass * pass, DRWShadingGroup * start_group, DRWShadingGroup * end_group) (/home/yiming/Downloads/BlenderMain/blender/source/blender/draw/intern/draw_manager_exec.cc:1217)
DRW_draw_pass(DRWPass * pass) (/home/yiming/Downloads/BlenderMain/blender/source/blender/draw/intern/draw_manager_exec.cc:1258)
blender::draw::DRW_curves_update() (/home/yiming/Downloads/BlenderMain/blender/source/blender/draw/intern/draw_curves.cc:343)
DRW_draw_render_loop_ex(Depsgraph * depsgraph, RenderEngineType * engine_type, ARegion * region, View3D * v3d, GPUViewport * viewport, const bContext * evil_C) (/home/yiming/Downloads/BlenderMain/blender/source/blender/draw/intern/draw_manager_c.cc:1749)
DRW_draw_view(const bContext * C) (/home/yiming/Downloads/BlenderMain/blender/source/blender/draw/intern/draw_manager_c.cc:1625)
view3d_draw_view(const bContext * C, ARegion * region) (/home/yiming/Downloads/BlenderMain/blender/source/blender/editors/space_view3d/view3d_draw.cc:1571)
view3d_main_region_draw(const bContext * C, ARegion * region) (/home/yiming/Downloads/BlenderMain/blender/source/blender/editors/space_view3d/view3d_draw.cc:1606)
ED_region_do_draw(bContext * C, ARegion * region) (/home/yiming/Downloads/BlenderMain/blender/source/blender/editors/screen/area.cc:528)
wm_draw_window_offscreen(bContext * C, wmWindow * win, bool stereo) (/home/yiming/Downloads/BlenderMain/blender/source/blender/windowmanager/intern/wm_draw.cc:1006)
wm_draw_window(bContext * C, wmWindow * win) (/home/yiming/Downloads/BlenderMain/blender/source/blender/windowmanager/intern/wm_draw.cc:1173)
wm_draw_update(bContext * C) (/home/yiming/Downloads/BlenderMain/blender/source/blender/windowmanager/intern/wm_draw.cc:1576)
WM_main(bContext * C) (/home/yiming/Downloads/BlenderMain/blender/source/blender/windowmanager/intern/wm.cc:641)
main(int argc, const char ** argv) (/home/yiming/Downloads/BlenderMain/blender/source/creator/creator.cc:586)

Can confirm the crash on 4.1 and 4.2. Apparently it doesn't crash in the freestyle code here, I'm not sure why it reported on yours as such. Here's mine (I'm on linux) ``` GPU_vertbuf_bind_as_texture(blender::gpu::VertBuf * verts, int binding) (/home/yiming/Downloads/BlenderMain/blender/source/blender/gpu/intern/gpu_vertex_buffer.cc:341) draw_update_uniforms(DRWShadingGroup * shgroup, DRWCommandsState * state, bool * use_tfeedback) (/home/yiming/Downloads/BlenderMain/blender/source/blender/draw/intern/draw_manager_exec.cc:716) draw_shgroup(DRWShadingGroup * shgroup, DRWState pass_state) (/home/yiming/Downloads/BlenderMain/blender/source/blender/draw/intern/draw_manager_exec.cc:1023) drw_draw_pass_ex(DRWPass * pass, DRWShadingGroup * start_group, DRWShadingGroup * end_group) (/home/yiming/Downloads/BlenderMain/blender/source/blender/draw/intern/draw_manager_exec.cc:1217) DRW_draw_pass(DRWPass * pass) (/home/yiming/Downloads/BlenderMain/blender/source/blender/draw/intern/draw_manager_exec.cc:1258) blender::draw::DRW_curves_update() (/home/yiming/Downloads/BlenderMain/blender/source/blender/draw/intern/draw_curves.cc:343) DRW_draw_render_loop_ex(Depsgraph * depsgraph, RenderEngineType * engine_type, ARegion * region, View3D * v3d, GPUViewport * viewport, const bContext * evil_C) (/home/yiming/Downloads/BlenderMain/blender/source/blender/draw/intern/draw_manager_c.cc:1749) DRW_draw_view(const bContext * C) (/home/yiming/Downloads/BlenderMain/blender/source/blender/draw/intern/draw_manager_c.cc:1625) view3d_draw_view(const bContext * C, ARegion * region) (/home/yiming/Downloads/BlenderMain/blender/source/blender/editors/space_view3d/view3d_draw.cc:1571) view3d_main_region_draw(const bContext * C, ARegion * region) (/home/yiming/Downloads/BlenderMain/blender/source/blender/editors/space_view3d/view3d_draw.cc:1606) ED_region_do_draw(bContext * C, ARegion * region) (/home/yiming/Downloads/BlenderMain/blender/source/blender/editors/screen/area.cc:528) wm_draw_window_offscreen(bContext * C, wmWindow * win, bool stereo) (/home/yiming/Downloads/BlenderMain/blender/source/blender/windowmanager/intern/wm_draw.cc:1006) wm_draw_window(bContext * C, wmWindow * win) (/home/yiming/Downloads/BlenderMain/blender/source/blender/windowmanager/intern/wm_draw.cc:1173) wm_draw_update(bContext * C) (/home/yiming/Downloads/BlenderMain/blender/source/blender/windowmanager/intern/wm_draw.cc:1576) WM_main(bContext * C) (/home/yiming/Downloads/BlenderMain/blender/source/blender/windowmanager/intern/wm.cc:641) main(int argc, const char ** argv) (/home/yiming/Downloads/BlenderMain/blender/source/creator/creator.cc:586) ```

YimingWu added

and removed

labels 2024-04-19 04:09:59 +02:00

YimingWu commented

2024-04-19 04:18:53 +02:00

Looks like for the code to get into such state, drw_shgroup_uniform_create_ex is probably missing type DRW_UNIFORM_VERTEX_BUFFER_AS_TEXTURE and DRW_UNIFORM_VERTEX_BUFFER_AS_TEXTURE_REF?

The code around these places are somewhat old so I'm not sure where and how it changed. The problem could also be upstream where it's not identifying empty geometry correctly...

@fclem

Looks like for the code to get into such state, `drw_shgroup_uniform_create_ex` is probably missing type `DRW_UNIFORM_VERTEX_BUFFER_AS_TEXTURE` and `DRW_UNIFORM_VERTEX_BUFFER_AS_TEXTURE_REF`? The code around these places are somewhat old so I'm not sure where and how it changed. The problem could also be upstream where it's not identifying empty geometry correctly... @fclem

Philipp Oeser commented

2024-04-19 10:11:31 +02:00

It is a crash and a regression (no crash in 4.0.2), so definitely High priority

It is a crash **and** a regression (no crash in 4.0.2), so definitely High priority

Philipp Oeser added

and removed

labels 2024-04-19 10:11:42 +02:00

Philipp Oeser commented

2024-04-19 10:12:00 +02:00

will bisect

Philipp Oeser commented

2024-04-19 11:16:42 +02:00

Caused by 1cca960677

CC @JacquesLucke ^^

Note: it does not crash if i remove the socket from the GN output beforehand :

Caused by 1cca96067781f569c6bced0c4f363d71781df092 CC @JacquesLucke ^^ Note: it does not crash if i remove the socket from the GN output beforehand : ![image](/attachments/8f1a5324-4f2b-490b-91e1-f6d0f6915ed7)

image.png

157 KiB

Philipp Oeser added

and removed

labels 2024-04-19 11:17:13 +02:00

Jacques Lucke referenced this issue from a commit

2024-04-22 09:39:45 +02:00

Fix #120805: crash when using multiple curves attributes in shader