Vector scope would crash blender if Color Management > Gamma is set too low #120806

Open
opened 2024-04-19 03:52:41 +02:00 by YimingWu · 2 comments
Member

System Information
Operating system: Ubuntu 22.04
Graphics card: nVidia RTX 4070

Blender Version
Broken: 4.2 9cb3a17352
Worked: ?

Short description of error

Vector scope would crash blender if Color Management > Gamma is set too low

error in stdout:

OpenColorIO Error: ExponentTransform validation failed: Parameter 8.38861e+06 is greater than upper bound 100

Exact steps for others to reproduce the error

  • Render a default cube
  • Open image viewer and switch to the vector scope ui
  • Set Color Management > Gamma to 0
  • Crash

This is likely just missing a clamp somewhere when supplying the gamma value to OCIO... a gamma of 0 won't make any practical sense anyway, but blender should clamp it whenever applicable.

Maybe we should change the RNA of this property to have a narrower UI range too?

**System Information** Operating system: Ubuntu 22.04 Graphics card: nVidia RTX 4070 **Blender Version** Broken: 4.2 9cb3a17352bd7ed57df82f3 Worked: ? **Short description of error** Vector scope would crash blender if Color Management > Gamma is set too low error in stdout: ``` OpenColorIO Error: ExponentTransform validation failed: Parameter 8.38861e+06 is greater than upper bound 100 ``` **Exact steps for others to reproduce the error** - Render a default cube - Open image viewer and switch to the vector scope ui - Set Color Management > Gamma to 0 - Crash This is likely just missing a clamp somewhere when supplying the gamma value to OCIO... a gamma of 0 won't make any practical sense anyway, but blender should clamp it whenever applicable. Maybe we should change the RNA of this property to have a narrower UI range too?
YimingWu added the
Interest
Compositing
Type
Report
Priority
Normal
Status
Needs Triage
labels 2024-04-19 03:52:43 +02:00
YimingWu added the
Module
Render & Cycles
Interest
Images & Movies
labels 2024-04-19 03:53:44 +02:00
YimingWu added
Status
Confirmed
and removed
Status
Needs Triage
labels 2024-04-19 03:54:47 +02:00

Confirmed but the process abort will only occur in debug builds or for builds with the WITH_ASSERT_ABORT define set. Our official builds won't crash but they'll still print the exception message.

blender.exe!OCIO_reportError(const char * err) Line 44	C++
blender.exe!OCIO_reportException(OpenColorIO_v2_3::Exception & exception) Line 49	C++
blender.exe!`OCIOImpl::createDisplayProcessor'::`1'::catch$16() Line 752	C++
blender.exe!OCIOImpl::createDisplayProcessor
blender.exe!OCIO_createDisplayProcessor
blender.exe!create_display_buffer_processor
Confirmed but the process abort will only occur in debug builds or for builds with the `WITH_ASSERT_ABORT` define set. Our official builds won't crash but they'll still print the exception message. ``` blender.exe!OCIO_reportError(const char * err) Line 44 C++ blender.exe!OCIO_reportException(OpenColorIO_v2_3::Exception & exception) Line 49 C++ blender.exe!`OCIOImpl::createDisplayProcessor'::`1'::catch$16() Line 752 C++ blender.exe!OCIOImpl::createDisplayProcessor blender.exe!OCIO_createDisplayProcessor blender.exe!create_display_buffer_processor ```
Author
Member

@deadpin An thanks... Interesting. I made a fix anyway 😅

@deadpin An thanks... Interesting. I made a fix anyway 😅
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#120806
No description provided.