VSE: Retime doesn't work until Retime Keyframes are selected once #120834
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#120834
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Linux-6.8.6-gentoo-x86_64-Intel-R-_Core-TM-i9-9900K_CPU@_3.60GHz-with-glibc2.38 64 Bits, X11 UI
Blender Version
Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-04-18 21:44, hash:
05c1abe59c95Worked: Unknown.
Short description of error
After a strip is cut, dragging a retiming keyframe doesn't seem to work correctly unless both of the initial keyframes were briefly selected at some point.
In the video below (enjoy some fresh Taytay), the numbers displayed as the scaling percentage appear to be correct, and they reflect the issue: Dragging for the first time results in a (unexpected) speed of 140%, when dragging a similar amount from the left (now that both keys have been touched) results in a (expected) speed of 400%.
Exact steps for others to reproduce the error
Add a video
Cut out a piece in the middle with K
Add retiming with Ctrl R
Move the right-side keyframe to the left, observe the % value. It doesn't seem like it's working.
Drag from the left-side, now it works.
If you add retiming to a new strip and select both retiming keyframes, retiming will work when you slide for the first time.
To me this suggests that some important data is being initialized/updated on keyframe selection rather than the moment retiming is enabled.
Something is wrong happened here, after first try to catch bug this come so work the same for both directions, so this is so:
-> 140%.
<- 400%.
Undo.
-> 400%.
<- 400%.
I have now found out it starts behaving correctly after simply selecting both initial keyframe points at least once. No other interaction or undo needed. So, I think some data is initalized only when the keyframe points are selected, but it should be initialized when they are revealed, or something like that.
VSE: Retime Keyframes behave differently depending on which side is draggedto VSE: Retime doesn't work until Retime Keyframes are selected onceI updated the title and description with the more accurate repro steps, and was advised to ping @iss :)
Can confirm, this happens, because the key is actually created when it it clicked on. Before that it is just imaginary. This is done this way in order to not make these pernament when retiming is enabled and immediately disabled. But it would make sense to create both keys on click, since after clicking on it it is pernament.
Perhaps drawing code could ignore strips with 2 keys and 100% speed, but this can be quite slow to check. It would definitely simplify the code a bit...
BTW I almost had heart attack after playing the video :) Volume set to max...