bmesh.ops.convex_hull doesn't return usable 'geom_interior' or 'geom_unused' #120860

Open
opened 2024-04-20 20:04:59 +02:00 by Dmitry C. · 2 comments

System: Windows 10
Broken: Blender 2.79 - 4.1.1
Worked: never?

When using convex hull from bmesh, neither 'geom_interior' nor 'geom_unused' contain any faces or edges.
Furthermore, 'geom_unused' seems to always be completely empty, while the "Delete Unused" checkbox in the mesh op dialog actually corresponds to deleting 'geom_interior'.

The docs on the operation are a bit raw (e.g. no such thing as 'geom.out'). Intuitively, I would expect it to return the following:
'geom' - new geo that belongs to the hull's surface
'geom_holes' - old geo that belongs to the hull's surface (only applicable if use_existing_faces=True)
'geom_interior' - old geo that ends up inside of the hull's surface
'geom_unused' - old geo that ends up outside of the hull's surface (only applicable when using partial selection as input)
Such output would then allow to easily delete or modify the parts as necessary.

So this is part bug, part documentation issue, part mesh/bmesh inconsistency, and part potential improvement.

Ideally:

  • 'geom_interior' would contain faces and edges in addition to verts
  • 'geom_unused' would contain the unselected mesh (faces, edges, verts)
  • mesh and bmesh ops would use the same terms to refer to the same thing

Assuming I didn't miss anything obvious, I would additionally propose renaming 'geom_unused' to 'geom_exterior'. Or perhaps even 'geom_interior' & 'geom_unused' to 'geom_inner' & 'geom_outer'.
After all, both of these are unused, so naming only one as such seems to suggest that the other is "used", i.e. on the surface, which isn't the case.

I'm attaching a .blend file (2.79) with text editor script that illustrates behavior vs expectation.

System: Windows 10 Broken: Blender 2.79 - 4.1.1 Worked: never? When using convex hull from bmesh, neither 'geom_interior' nor 'geom_unused' contain any faces or edges. Furthermore, 'geom_unused' seems to always be completely empty, while the "Delete Unused" checkbox in the mesh op dialog actually corresponds to deleting 'geom_interior'. The docs on the operation are a bit raw (e.g. no such thing as 'geom.out'). Intuitively, I would expect it to return the following: **'geom'** - new geo that belongs to the hull's surface **'geom_holes'** - old geo that belongs to the hull's surface (only applicable if use_existing_faces=True) **'geom_interior'** - old geo that ends up inside of the hull's surface **'geom_unused'** - old geo that ends up outside of the hull's surface (only applicable when using partial selection as input) Such output would then allow to easily delete or modify the parts as necessary. So this is part bug, part documentation issue, part mesh/bmesh inconsistency, and part potential improvement. Ideally: - 'geom_interior' would contain faces and edges in addition to verts - 'geom_unused' would contain the unselected mesh (faces, edges, verts) - mesh and bmesh ops would use the same terms to refer to the same thing Assuming I didn't miss anything obvious, I would additionally propose renaming 'geom_unused' to 'geom_exterior'. Or perhaps even 'geom_interior' & 'geom_unused' to 'geom_inner' & 'geom_outer'. After all, both of these are *unused*, so naming only one as such seems to suggest that the other is "used", i.e. *on* the surface, which isn't the case. I'm attaching a .blend file (2.79) with text editor script that illustrates behavior vs expectation.
Dmitry C. added the
Type
Report
Priority
Normal
Status
Needs Triage
labels 2024-04-20 20:05:00 +02:00
Iliya Katushenock added the
Interest
Modeling
label 2024-04-20 20:05:56 +02:00
Author

To give an example where returning verts isn't sufficient:
hull_example.png
From bmesh, there is no (clean) way to delete the active face (index 0) after a convex hull operation.

  • All of its verts are in use by the hull, so deleting interior vert(s) isn't enough.
  • Subtracting 'geom' from all faces and deleting the rest isn't enough, because we want to keep the unselected geometry.
  • Tagging is unreliable: you'd expect tag value to transfer to new geometry, but it doesn't (seemingly at random).
  • Selection status is dodgy between different element types (flush), and, as with tags, what gets selected by the operation isn't clearly defined.
  • Using pre-hull face indices or references generally doesn't seem safe, but this is the only thing that appears to sort of work.
  • Splitting selection into another bmesh and doing the operation there is still NotImplementedError

From bpy.ops, everything works as expected: selection gets replaced by the hull.

To give an example where returning verts isn't sufficient: ![hull_example.png](/attachments/8256af7a-6e57-4175-b05e-602172566995) From bmesh, there is no (clean) way to delete the active face (index 0) after a convex hull operation. - All of its verts are in use by the hull, so deleting interior vert(s) isn't enough. - Subtracting 'geom' from all faces and deleting the rest isn't enough, because we want to keep the unselected geometry. - Tagging is unreliable: you'd expect tag value to transfer to new geometry, but it doesn't (seemingly at random). - Selection status is dodgy between different element types (flush), and, as with tags, what gets selected by the operation isn't clearly defined. - Using pre-hull face indices or references generally doesn't seem safe, but this is the only thing that appears to sort of work. - Splitting selection into another bmesh and doing the operation there is still `NotImplementedError` From bpy.ops, everything works as expected: selection gets replaced by the hull.
Dmitry C. changed title from bmesh.ops.convex_hull doesn't return usable 'geom_interior' or 'geom_unused' to `bmesh.ops.convex_hull` doesn't return usable `'geom_interior'` or `'geom_unused'` 2024-04-26 14:37:01 +02:00
@ideasman42 /
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#120860
No description provided.