sculpt mode | lose pivot position data #120864

New Issue

CODACOD · 2024-04-20T22:10:16+02:00

CODACOD commented

2024-04-20 22:10:16 +02:00

blender ver 4.1.1
while switching between undo\redo blender lose pivot position data and reset it to the original position. and everytime doing this i have to set back the pivot position and that registered as undo\redo steps.

beside that i hope there is an option for setting the pivot inside the object . same like set the origin to geometry. this is gonna be useful for posing . and rather than go to object mode and set origin to geometry we can do that in sculpt mode 😃

@farsthary @Sergey, @HooglyBoogly, @ideasman42, @Jeroen-Bakker, @mont29

blender ver 4.1.1 while switching between undo\redo blender lose pivot position data and reset it to the original position. and everytime doing this i have to set back the pivot position and that registered as undo\redo steps. ------ beside that i hope there is an option for setting the pivot inside the object . same like set the origin to geometry. this is gonna be useful for posing . and rather than go to object mode and set origin to geometry we can do that in sculpt mode 😃 ---- @farsthary @Sergey, @HooglyBoogly, @ideasman42, @Jeroen-Bakker, @mont29

2024-04-20 23-16-02.mp4

1.9 MiB

CODACOD added the

labels 2024-04-20 22:10:17 +02:00

Iliya Katushenock added

Module

Sculpt, Paint & Texture

Status

Needs Info from Developers

and removed

Status

Needs Triage

labels 2024-04-20 23:42:15 +02:00

Iliya Katushenock commented

2024-04-20 23:44:39 +02:00

I don't know if this is pivot point (as in operator settings) or 3d cursor (as it looks like and called in status bar). And depend on that fact what is that this can be correct bug or expected behavior.

CODACOD commented

2024-04-21 01:02:47 +02:00

I don't know if this is pivot point (as in operator settings) or 3d cursor (as it looks like and called in status bar). And depend on that fact what is that this can be correct bug or expected behavior.

when dev added shift+rightclick to set pivot in sculpt mode its comes with this problem . so i think its not expected behavior but should be corrected .

> I don't know if this is pivot point (as in operator settings) or 3d cursor (as it looks like and called in status bar). And depend on that fact what is that this can be correct bug or expected behavior. when dev added `shift+rightclick` to set pivot in sculpt mode its comes with this problem . so i think its not expected behavior but should be corrected .

Campbell Barton commented

2024-04-21 04:53:00 +02:00

@CODACOD what was the last Blender version that worked?

CODACOD commented

2024-04-21 16:02:36 +02:00

@CODACOD what was the last Blender version that worked?

this feature first added to blender 4.0 (i tried 3.6.9 and it was`nt there) and it have this problem ever since .

> @CODACOD what was the last Blender version that worked? this feature first added to blender 4.0 (i tried 3.6.9 and it was`nt there) and it have this problem ever since .

Sergey Sharybin commented

2024-04-22 16:24:03 +02:00

This is an oversight from the initial implementation. The SculptSession's pivot_point is only pushed to the undo stack with an actual geometry change with sculpt brushes. The Set Pivot Position operator does not invoke a code path which would put the pivot point to the undo stack.

@ideasman42 What I am not sure is what undo stack the OPTYPE_UNDO uses. Either I am missing something, or sculpt_undosys_step_encode is not called when the operator is called. Other than that it sounds like it shouldn't be that hard to fix this issue.

This is an oversight from the initial implementation. The `SculptSession`'s `pivot_point` is only pushed to the undo stack with an actual geometry change with sculpt brushes. The `Set Pivot Position` operator does not invoke a code path which would put the pivot point to the undo stack. @ideasman42 What I am not sure is what undo stack the `OPTYPE_UNDO` uses. Either I am missing something, or `sculpt_undosys_step_encode` is not called when the operator is called. Other than that it sounds like it shouldn't be that hard to fix this issue.

👍 1

Campbell Barton commented

2024-04-24 06:11:55 +02:00

This is an oversight from the initial implementation. The SculptSession's pivot_point is only pushed to the undo stack with an actual geometry change with sculpt brushes. The Set Pivot Position operator does not invoke a code path which would put the pivot point to the undo stack.

@ideasman42 What I am not sure is what undo stack the OPTYPE_UNDO uses. Either I am missing something, or sculpt_undosys_step_encode is not called when the operator is called. Other than that it sounds like it shouldn't be that hard to fix this issue.

The SCULPT_OT_set_pivot_position operator falls back to "Global Undo", however the global undo steps are not restored since the pivot position isn't written to the blend-file. It looks like this whole area needs some work as it doesn't seem undo was considered when adding the functionality.

If we want this to work reliably it should probably be made part of the blend file. However a more isolated fix can probably be made which resolves the bug reported here.

> This is an oversight from the initial implementation. The `SculptSession`'s `pivot_point` is only pushed to the undo stack with an actual geometry change with sculpt brushes. The `Set Pivot Position` operator does not invoke a code path which would put the pivot point to the undo stack. > > @ideasman42 What I am not sure is what undo stack the `OPTYPE_UNDO` uses. Either I am missing something, or `sculpt_undosys_step_encode` is not called when the operator is called. Other than that it sounds like it shouldn't be that hard to fix this issue. The `SCULPT_OT_set_pivot_position` operator falls back to "Global Undo", however the global undo steps are not restored since the pivot position isn't written to the blend-file. It looks like this whole area needs some work as it doesn't seem undo was considered when adding the functionality. If we want this to work reliably it should probably be made part of the blend file. However a more isolated fix can probably be made which resolves the bug reported here.

Sergey Sharybin commented

2024-04-24 10:32:36 +02:00

If we want this to work reliably it should probably be made part of the blend file.

I am not sure you can undo global-undo step while in sculpt mode? Not currently, anyway, and supporting it might be quite a challenge.

However a more isolated fix can probably be made which resolves the bug reported here.

The operator can skip OPTYPE_UNDO, and take care of sculpt-mode-specific push manually.

> If we want this to work reliably it should probably be made part of the blend file. I am not sure you can undo global-undo step while in sculpt mode? Not currently, anyway, and supporting it might be quite a challenge. > However a more isolated fix can probably be made which resolves the bug reported here. The operator can skip `OPTYPE_UNDO`, and take care of sculpt-mode-specific push manually.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

sculpt mode | lose pivot position data #120864