Regression: Key bindings not work in any keyboard layout except English #120892

New Issue

Alexandr · 2024-04-21T18:03:14+02:00

Alexandr commented

2024-04-21 18:03:14 +02:00

System Information
Operating system: Linux Debian Stable
Graphics card: Nvidia RTX 3050ti, RTX 3090, Intel TigerLake-H GT1

Blender Version
Broken: 4.1.1
Worked: 3.6.2

Short description of error
In English keyboard layout bindings works as expected, but in Russian keyboard layout keyboard bindings don't work at all. When you attepmt to rebind keys with Russian layout, it errors with "Unsupported key: Unknown". In other versions of Blender key bindings worked no matter what layout you use.

Exact steps for others to reproduce the error

Open startup file
Change keyboard layout to Russian
Press Q (or any other key).

**System Information** Operating system: Linux Debian Stable Graphics card: Nvidia RTX 3050ti, RTX 3090, Intel TigerLake-H GT1 **Blender Version** Broken: 4.1.1 Worked: 3.6.2 **Short description of error** In English keyboard layout bindings works as expected, but in Russian keyboard layout keyboard bindings don't work at all. When you attepmt to rebind keys with Russian layout, it errors with "Unsupported key: Unknown". In other versions of Blender key bindings worked no matter what layout you use. ![изображение](/attachments/4a358eb7-08b7-456c-ad06-22d8a6c889b5) **Exact steps for others to reproduce the error** 1. Open startup file 2. Change keyboard layout to Russian 3. Press Q (or any other key).

изображение.png

4.1 KiB

Alexandr added the

labels 2024-04-21 18:03:15 +02:00

YimingWu commented

2024-04-22 03:35:19 +02:00

It seems that wm_event_type_from_ghost_key and ghost_key_from_keysym is not dealing with any key values except e.g. XK_LATIN1. in this particular case, all values inside XK_CYRILLIC should also be taken care of in ghost_key_from_keysym, but likely we need to map those keys to corresponding english keyboard keys so the shortcut etc would still work, but a lot of manual mapping is needed.

Another solution is to use KeyCode which is only associated with hardware keys (as far as I'm understanding), we can get a key code for all the keys that GHOST is handling with XKeysymToKeycode first when blender starts and create a table, then for all the "Unknown" XK_xxx KeySyms we can fall back to using key code of that key and map to corresponding XK_LATIN1 ones from the table.

@Harley @ideasman42 Any opinions?

It seems that `wm_event_type_from_ghost_key` and `ghost_key_from_keysym` is not dealing with any key values except e.g. `XK_LATIN1`. in this particular case, all values inside `XK_CYRILLIC` should also be taken care of in `ghost_key_from_keysym`, but likely we need to map those keys to corresponding english keyboard keys so the shortcut etc would still work, but a lot of manual mapping is needed. Another solution is to use KeyCode which is only associated with hardware keys (as far as I'm understanding), we can get a key code for all the keys that GHOST _is_ handling with ` XKeysymToKeycode` first when blender starts and create a table, then for all the "Unknown" XK_xxx KeySyms we can fall back to using key code of that key and map to corresponding XK_LATIN1 ones from the table. @Harley @ideasman42 Any opinions?

YimingWu added

Module

Core

Status

Needs Info from Developers

and removed

labels 2024-04-22 03:35:48 +02:00

Sign in to join this conversation.