Blender doesn't ask "save modified image(s)?" when user choose "Revert" or "Recover ---> Auto Save..." option #121141

New Issue

Michael-Michael-10 · 2024-04-26T18:46:55+02:00

2024-04-26 18:46:55 +02:00

Blender Version
3.5 or newer ones. (I didn't try with older versions)

Short description of error
Blender doesn't ask "save modified image(s)?" when user choose "Revert" or "Recover ---> Auto Save..." option (in that case the current blender file saved (Ctrl + S)). When user use "New", "Open", "Open recent" or "Recover ---> Last session" option or when user just try to close Blender the behavior work as intended.

Exact steps for others to reproduce the error

Create a new general project
Go to Texture Paint tab
Create an image
Edit the image (draw something)
Save the project (Ctrl + S)
Revert the project or use "Recover ---> Auto Save..." option

I looked at someone announcing this before, but I couldn't find anything. I am surprised that a single person has not announced this bug (Blender is an awesome software (for fully free!), that's why people should be more responsible for help Blender, at least with bug reports!), as it is a very big one (it doesn't matter if a rookie user doesn't know it works like this right now, or a more experienced user accidentally forgot about this abnormal behavior and accidentally use for example revert option.), - even long hours of work can be lost.

**Blender Version** 3.5 or newer ones. (I didn't try with older versions) **Short description of error** Blender doesn't ask "save modified image(s)?" when user choose "Revert" or "Recover ---> Auto Save..." option (in that case the current blender file saved (Ctrl + S)). When user use "New", "Open", "Open recent" or "Recover ---> Last session" option or when user just try to close Blender the behavior work as intended. **Exact steps for others to reproduce the error** - Create a new general project - Go to Texture Paint tab - Create an image - Edit the image (draw something) - Save the project (Ctrl + S) - Revert the project or use "Recover ---> Auto Save..." option --------------------------------------------------------------------------------- I looked at someone announcing this before, but I couldn't find anything. I am surprised that a single person has not announced this bug (Blender is an awesome software (for fully free!), that's why people should be more responsible for help Blender, at least with bug reports!), as it is a very big one (it doesn't matter if a rookie user doesn't know it works like this right now, or a more experienced user accidentally forgot about this abnormal behavior and accidentally use for example revert option.), - even long hours of work can be lost.

Michael-Michael-10 added the

labels 2024-04-26 18:46:56 +02:00

Philipp Oeser commented

2024-04-30 09:14:58 +02:00

Can confirm the behavior.

At least for Recover ---> Auto Save... I would expect to be asked to save changes & modified image(s).
For Revert this sounds a bit strange though (since this explicitly drops unsaved changes and goes to the saved file)?

@Michael-Michael-10 : why would you expect to be asked to save changes & modified image(s) for Revert?

Can confirm the behavior. At least for `Recover ---> Auto Save...` I would expect to be asked to save changes & modified image(s). For `Revert` this sounds a bit strange though (since this explicitly drops unsaved changes and goes to the saved file)? @Michael-Michael-10 : why would you expect to be asked to save changes & modified image(s) for `Revert`?

Philipp Oeser added

Status

Needs Information from User

and removed

Status

Needs Triage

labels 2024-04-30 09:15:06 +02:00

Philipp Oeser commented

2024-04-30 10:05:29 +02:00

@Harley might be interested as well

Harley Acheson commented

2024-04-30 18:15:47 +02:00

Yes, the Recover / Autosave could have the same "Save changes before closing" dialog we get with Open, and it does show if there are unsaved images.

But Revert is a bit odd in that saving before reverting could be a disaster. It used to be that we just confirmed with a little "OK?" popup, where we now show a larger and more explicit warning that includes "Any unsaved changes will be lost". We could check for and warn of unsaved images there explicitly, but separate files aren't actually reverted, just the blend file, so it could actually add confusion.

Yes, the Recover / Autosave could have the same "Save changes before closing" dialog we get with Open, and it does show if there are unsaved images. But Revert is a bit odd in that saving before reverting could be a disaster. It used to be that we just confirmed with a little "OK?" popup, where we now show a larger and more explicit warning that includes "Any unsaved changes will be lost". We could check for and warn of unsaved images there explicitly, but separate files aren't actually reverted, just the blend file, so it could actually add confusion.

Michael-Michael-10 commented

2024-04-30 20:18:57 +02:00

Can confirm the behavior.

At least for Recover ---> Auto Save... I would expect to be asked to save changes & modified image(s).
For Revert this sounds a bit strange though (since this explicitly drops unsaved changes and goes to the saved file)?

@Michael-Michael-10 : why would you expect to be asked to save changes & modified image(s) for Revert?

Thanks for your intercession!

Why anybody would naturally think the modified image won't save after "I click the save button"? "Why I should think that picture what I modified in the last minutes, yet it wasn't save, despite I click save button - and by the way which picture is many times before my eyes before revert (that is part of the last frame on the monitor before revert).
I think there isn't people (who new in Blender) who think naturally, the "original, non modified image will be reverting", except those, who met behaviors like this in other softwares(personally I never see behaviors like this before).
"...this explicitly drops unsaved changes and goes to the saved file". I'm not sure, but it looks basically a natural behavior(?). But people don't know this, they just see only "revert". "Ok, what is supposed to be mean?", "Hmm, what else can this mean that just go to the last state of the saved project ("which project's part is that modified picture"), "Ok, clear".
If that behavior, that Blender doesn't ask "save modified image(s)" at revert is an important thing I can accept this, because I can imagine people who use this method, that fastly go to the saved file, but without "save unsaved elements". But if this is really the default behavior ("that at revert Blender doesn't ask: save modified image(s)), I'm sure it is just simply bad (not only because of new users, but what I wrote earlier that someone forgets to "save it separately". For example I use the faster revert option a lot (when a project use bigger memory) instead of "File ---> Open... ---> select the actual project".
Still all of this I'm sure the only default behavior it should be, as in other cases when Blender ask "save modified image(s)?", in addition extended by that what is better and with which both parties are doing well is that at the very first revert Blender asks the same way; you want to save or not, but then offers the option to remember (or not) this choice and not appear anymore (later of course should be changeable in the menu).

> Can confirm the behavior. > > At least for `Recover ---> Auto Save...` I would expect to be asked to save changes & modified image(s). > For `Revert` this sounds a bit strange though (since this explicitly drops unsaved changes and goes to the saved file)? > > @Michael-Michael-10 : why would you expect to be asked to save changes & modified image(s) for `Revert`? Thanks for your intercession! Why anybody would naturally think the modified image won't save after "I click the save button"? "Why I should think that picture what I modified in the last minutes, yet it wasn't save, despite I click save button - and by the way which picture is many times before my eyes before revert (that is part of the last frame on the monitor before revert). I think there isn't people (who new in Blender) who think naturally, the "original, non modified image will be reverting", except those, who met behaviors like this in other softwares(personally I never see behaviors like this before). "...this explicitly drops unsaved changes and goes to the saved file". I'm not sure, but it looks basically a natural behavior(?). But people don't know this, they just see only "revert". "Ok, what is supposed to be mean?", "Hmm, what else can this mean that just go to the last state of the saved project ("which project's part is that modified picture"), "Ok, clear". If that behavior, that Blender doesn't ask "save modified image(s)" at revert is an important thing I can accept this, because I can imagine people who use this method, that fastly go to the saved file, but without "save unsaved elements". But if this is really the default behavior ("that at revert Blender doesn't ask: save modified image(s)), I'm sure it is just simply bad (not only because of new users, but what I wrote earlier that someone forgets to "save it separately". For example I use the faster revert option a lot (when a project use bigger memory) instead of "File ---> Open... ---> select the actual project". Still all of this I'm sure the only default behavior it should be, as in other cases when Blender ask "save modified image(s)?", in addition extended by that what is better and with which both parties are doing well is that at the very first revert Blender asks the same way; you want to save or not, but then offers the option to remember (or not) this choice and not appear anymore (later of course should be changeable in the menu).

Harley Acheson commented

2024-04-30 20:46:36 +02:00

For Revert, I wonder if this might be enough. Just check if there are unsaved images and alter the warning. Above without unsaved images, below with unsaved images:

For Revert, I wonder if this might be enough. Just check if there are unsaved images and alter the warning. Above without unsaved images, below with unsaved images: ![image](/attachments/f911033f-43e9-4a4b-92cc-a70da22aea87)

image.png

38 KiB

Michael-Michael-10 commented

2024-05-01 19:17:15 +02:00

I welcome your suggestions.
If I should choose from the two warning I would choose the second one. I feel that is important to be specific about the picture and not only in general any unrelated element.
I feel it would be best for revert to have the same warning as in the case of "File ---> Open..." (or other options). But it is just me, until the user get the information, that he/she has not saved modified images, I think the warning's form doesn't really matter.

I welcome your suggestions. If I should choose from the two warning I would choose the second one. I feel that is important to be specific about the picture and not only in general any unrelated element. I feel it would be best for revert to have the same warning as in the case of "File ---> Open..." (or other options). But it is just me, until the user get the information, that he/she has not saved modified images, I think the warning's form doesn't really matter.

Philipp Oeser referenced this issue

2024-05-02 13:27:42 +02:00

Image with edits is reverted when opened again (e.g.importing a image as node) without showing any warning #121278

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Blender doesn't ask "save modified image(s)?" when user choose "Revert" or "Recover ---> Auto Save..." option #121141