EEVEE-Next: Shadow Terminator Artifacts #121194

Closed
opened 2024-04-28 20:03:10 +02:00 by xZaki · 7 comments

System Information
Operating system: Windows 11
Graphics card: 4060ti

Blender Version
Broken: 4.2 3e814bc702
Worked: 4.2 1d9d0f0056

Short description of error
Build from few days ago:
image
Today:
image
Still very visible if the light has small radius:
image
The only setting that affects the artifacts is shadow filter radius, they also completely disappear if shadows are turned off.
Might be caused by #121088

Exact steps for others to reproduce the error
N/A

**System Information** Operating system: Windows 11 Graphics card: 4060ti **Blender Version** Broken: 4.2 3e814bc70294 Worked: 4.2 1d9d0f0056f3 **Short description of error** Build from few days ago: ![image](/attachments/62297b76-0352-486e-bf37-c1e79765778b) Today: ![image](/attachments/2fb14827-f4c2-4fc3-8e9f-36966103aa5d) Still very visible if the light has small radius: ![image](/attachments/4779c2e9-8381-4460-b8be-3e83c3cc5236) The only setting that affects the artifacts is `shadow filter radius`, they also completely disappear if shadows are turned off. Might be caused by https://projects.blender.org/blender/blender/pulls/121088 **Exact steps for others to reproduce the error** N/A
xZaki added the
Priority
Normal
Status
Needs Triage
Type
Report
labels 2024-04-28 20:03:10 +02:00

Interesting, this comes from the slope bias used to avoid the artifact below. The bias shifts back the object from the shadow projection perspective. But this bias is not done in the direction of the tracing so the tracing actually intersect with the shifted version of the object. Disabling the slope bias almost completely fixes the issue but it breaks these two cases mentioned in the task.


I think we can just decide that the PCF overshadowing on zero slope receiver is just a limitation of the new shadows and remove the slope bias. This would also help with this issue.

Interesting, this comes from the slope bias used to avoid the artifact below. The bias shifts back the object from the shadow projection perspective. But this bias is not done in the direction of the tracing so the tracing actually intersect with the shifted version of the object. Disabling the slope bias almost completely fixes the issue but it breaks these two cases mentioned in the task. ![](https://projects.blender.org/attachments/17b8e914-fa46-4639-8e46-bbd8d01d00c1) ![](https://projects.blender.org/attachments/18737ed8-47d2-4f3f-91ab-66e9cf570f4f) I think we can just decide that the PCF overshadowing on zero slope receiver is just a limitation of the new shadows and remove the slope bias. This would also help with this issue. ![](https://projects.blender.org/attachments/901919ff-a8d8-4f45-b017-3c5a0c87ecea)
Clément Foucault added
Status
Confirmed
Interest
EEVEE
and removed
Status
Needs Triage
labels 2024-04-29 01:16:43 +02:00
Blender Bot added
Status
Resolved
and removed
Status
Confirmed
labels 2024-04-29 17:05:17 +02:00
Author

Artifacts are still present on the latest build.
(Light softness is turned all the way down in this image, same file)
image

Artifacts are still present on the latest build. (Light softness is turned all the way down in this image, same file) ![image](/attachments/14471a02-ba62-4b01-ae3e-7f2f942eaf22)
307 KiB
xZaki reopened this issue 2024-04-30 04:21:46 +02:00
Blender Bot added
Status
Needs Triage
and removed
Status
Resolved
labels 2024-04-30 04:23:06 +02:00
Member

Yes, can still confirm

Yes, can still confirm
Pratik Borhade added
Module
EEVEE & Viewport
Status
Confirmed
and removed
Status
Needs Triage
labels 2024-04-30 08:14:22 +02:00

The remaining artifacts are caused by the shadow terminator issue. We need a user facing bias for this case since it depends on the geometry. I still have to design it.

Also, reducing the shadow softness will break PBR rules which creates artifacts. I'm also looking into a solution for this.

The remaining artifacts are caused by the shadow terminator issue. We need a user facing bias for this case since it depends on the geometry. I still have to design it. Also, reducing the shadow softness will break PBR rules which creates artifacts. I'm also looking into a solution for this.
Author

Also, reducing the shadow softness will break PBR rules which creates artifacts. I'm also looking into a solution for this.

The artifacts are present regardless, I just noticed it makes them more visible.

> Also, reducing the shadow softness will break PBR rules which creates artifacts. I'm also looking into a solution for this. The artifacts are present regardless, I just noticed it makes them more visible.

Yes. That's what my first paragraph was about. We need a geometry bias of some sort.

Yes. That's what my first paragraph was about. We need a geometry bias of some sort.

This issue has been solved by the recent shadow cleanup/refactors.

Please reopen if you can reproduce it.

This issue has been solved by the recent shadow cleanup/refactors. Please reopen if you can reproduce it.
Blender Bot added
Status
Archived
and removed
Status
Confirmed
labels 2024-05-22 15:14:01 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#121194
No description provided.