Crash on Undo after appending multiple collections that share data through the Asset Browser #121457

Closed
opened 2024-05-06 02:15:43 +02:00 by Albert-OShea · 3 comments

System Information
Operating system: Windows-10-10.0.22631-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 551.23

Blender Version
Broken: version: version: 4.1.1, branch: blender-v4.1-release, commit date: 2024-04-15 15:11, hash: e1743a0317bc

Short description of error
Ctrl+Z'ing after appending certain collections through the asset browser can cause a crash. Notably, the behavior between appending through the asset browser differs from using File > Append.

Exact steps for others to reproduce the error

  • Download attached blend file and save it to an asset library path.
  • In a new Blender instance, make sure the asset path to this file is set correctly, open an asset browser and find the collection assets that are defined in library.blend. They are named asset_1 and asset_2.
  • Make sure the import method is set to Append (Reuse Data), then drag both of these assets into the scene.
  • Make sure Instance is turned on in the operator panel options, so that they are added as instanced collections. (Crashes can still happen if this is switched off, but it is a little more consistent with it switched on, I've found)
  • With both assets added to the scene, immediately undo the actions of appending the assets (Ctrl+Z multiple times).
  • Blender (very frequently) crashes. If it doesn't, try again.

Note the difference in behavior between appending using this method, and appending using File > Append. The latter seems to work in a more sensible and stable way, with no duplicated rig and no crashes.

**System Information** Operating system: Windows-10-10.0.22631-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 551.23 **Blender Version** Broken: version: version: 4.1.1, branch: blender-v4.1-release, commit date: 2024-04-15 15:11, hash: `e1743a0317bc` **Short description of error** Ctrl+Z'ing after appending certain collections through the asset browser can cause a crash. Notably, the behavior between appending through the asset browser differs from using `File > Append`. **Exact steps for others to reproduce the error** - Download attached blend file and save it to an asset library path. - In a new Blender instance, make sure the asset path to this file is set correctly, open an asset browser and find the collection assets that are defined in `library.blend`. They are named `asset_1` and `asset_2`. - Make sure the import method is set to `Append (Reuse Data)`, then drag both of these assets into the scene. - Make sure `Instance` is turned on in the operator panel options, so that they are added as instanced collections. (Crashes can still happen if this is switched off, but it is a little more consistent with it switched on, I've found) - With both assets added to the scene, immediately undo the actions of appending the assets (Ctrl+Z multiple times). - Blender (very frequently) crashes. If it doesn't, try again. Note the difference in behavior between appending using this method, and appending using File > Append. The latter seems to work in a more sensible and stable way, with no duplicated rig and no crashes.
Albert-OShea added the
Priority
Normal
Type
Report
Status
Needs Triage
labels 2024-05-06 02:15:44 +02:00
Member

Hi, thanks for the report. Can confirm the crash. 3.6 is good AFAICS.

Hi, thanks for the report. Can confirm the crash. 3.6 is good AFAICS.
Member

Guess ebb5643e59 introduced the crash

Broke between: ab6860f3de0f - 3ca1e828e22b

Guess ebb5643e598a17b2f21b4e50acac35afe82dbd55 introduced the crash Broke between: `ab6860f3de0f - 3ca1e828e22b`

The problem does not come from undo/readfile code, but from the append&reuse one (I think).

At least, after second append, we have a horrible corruption of Main data, with some linked IDs referencing local IDs - among many other issues.

ebb5643e59 most likely merely reveals the issue, as it removed a lot of over-processing in the final step of undo/readfile processing, that would had 'hid' the problem.

The problem does not come from undo/readfile code, but from the append&reuse one (I think). At least, after second append, we have a horrible corruption of Main data, with some linked IDs referencing local IDs - among many other issues. ebb5643e59 most likely merely reveals the issue, as it removed a lot of over-processing in the final step of undo/readfile processing, that would had 'hid' the problem.
Bastien Montagne added
Interest
BlendFile
Type
Bug
and removed
Type
Report
labels 2024-05-07 10:32:48 +02:00
Blender Bot added
Status
Resolved
and removed
Status
Confirmed
labels 2024-05-16 16:21:03 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#121457
No description provided.