blender/blender
165
519
Fork 792
Code Issues 6.8k Pull Requests 950 Projects 21 Wiki Activity

Camera placement is undone when changing Pose Asset properties from redo panel #122757

New Issue
Closed
opened 2024-06-05 06:18:36 +02:00 by Shyy-Anzr · 15 comments
Shyy-Anzr commented 2024-06-05 06:18:36 +02:00
Copy Link

System Information
Operating system: Windows-10-10.0.17763-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 516.94

Blender Version
Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-06-04 21:37, hash: 2ddc936cbb8b
Worked: never

Short description of error
My typical workflow with pose assets: make a pose, move camera so it captures the pose distinctly, press Create Pose Asset, tweak name and always uncheck Activate New Action(bad default). The problem is that when I type the name of new asset or uncheck the checkbox, camera moves back to where it was before I adjusted it. That also updates thumbnail and thus ruins it.

Exact steps for others to reproduce the error

  • Create armature and camera, typical setup for pose asset capturing.
  • Tweak pose
  • Switch to camera view and invoke walk navigation. (Ensure that last action was camera movement, make it big and obvious.)
  • Press on Create Pose Asset. Operator menu will popup, offering to set name of the new asset. Input the name or click on checkbox near it.
  • Observe that camera moved back and asset thumbnail updated to the "new" old position.

Video

**System Information** Operating system: Windows-10-10.0.17763-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 516.94 **Blender Version** Broken: version: 4.2.0 Alpha, branch: main, commit date: 2024-06-04 21:37, hash: `2ddc936cbb8b` Worked: never **Short description of error** My typical workflow with pose assets: make a pose, move camera so it captures the pose distinctly, press Create Pose Asset, tweak name and always uncheck Activate New Action(bad default). The problem is that when I type the name of new asset or uncheck the checkbox, camera moves back to where it was before I adjusted it. That also updates thumbnail and thus ruins it. **Exact steps for others to reproduce the error** - Create armature and camera, typical setup for pose asset capturing. - Tweak pose - Switch to camera view and invoke walk navigation. (Ensure that last action was camera movement, make it big and obvious.) - Press on Create Pose Asset. Operator menu will popup, offering to set name of the new asset. Input the name or click on checkbox near it. - Observe that camera moved back and asset thumbnail updated to the "new" old position. [Video](https://projects.blender.org/attachments/eafbcef4-6f71-426c-a463-b5f93852661c)
pose-asset.blend
915 KiB
Shyy-Anzr added the
Severity
Normal
Type
Report
Status
Needs Triage
 labels 2024-06-05 06:18:37 +02:00
Shyy-Anzr changed title from Camera placement is undone when changing Create Pose Asset parameters, ruins asset preview to Camera placement is undone when changing Create Pose Asset parameters, ruins asset thumbnail 2024-06-05 06:24:22 +02:00
Pratik Borhade commented 2024-06-05 07:22:02 +02:00
Member
Copy Link

...then camera position

Hi, thanks for the report. Guess camera is locked in view? Can confirm in that case.

I can no longer search for Create Pose Asset operator

In F3 search menu? Enable developer extras in preferences, it would resolve the problem.

> ...then camera position Hi, thanks for the report. Guess camera is locked in view? Can confirm in that case. > I can no longer search for Create Pose Asset operator In F3 search menu? Enable `developer extras` in preferences, it would resolve the problem.
Pratik Borhade added
Status
Needs Information from User
 and removed
Status
Needs Triage
 labels 2024-06-05 07:22:16 +02:00
Shyy-Anzr commented 2024-06-05 07:32:47 +02:00
Author
Copy Link

Oh, right, I forgot to mention that I do that from Camera Perspective(entered by Numpad 0). I move the camera by flying (Shift + ~) while it is locked to view and if I create an asset just after that and tweak the name, the camera moves back. This occurs even if I exit the Camera Perspective to observe the camera in 3rd person and then trigger the bug. Camera visibly moves back.

Should I edit the issue text to reflect that?

Oh, right, I forgot to mention that I do that from Camera Perspective(entered by Numpad 0). I move the camera by flying (Shift + ~) while it is locked to view and if I create an asset just after that and tweak the name, the camera moves back. This occurs even if I exit the Camera Perspective to observe the camera in 3rd person and then trigger the bug. Camera visibly moves back. Should I edit the issue text to reflect that?
Shyy-Anzr commented 2024-06-05 07:37:48 +02:00
Author
Copy Link

And yes, enabling extras does resolve searchability of the "Create Pose Asset" operator.

And yes, enabling extras does resolve searchability of the "Create Pose Asset" operator.
Pratik Borhade changed title from Camera placement is undone when changing Create Pose Asset parameters, ruins asset thumbnail to Camera placement is undone when changing Pose Asset properties from redo panel 2024-06-05 07:45:00 +02:00
Pratik Borhade commented 2024-06-05 07:58:32 +02:00
Member
Copy Link

With walk navigation, I'm not able to redo this. But can confirm If I move locked camera with trackpad (undo step is not registered with that)

With walk navigation, I'm not able to redo this. But can confirm If I move locked camera with trackpad (undo step is not registered with that)
Shyy-Anzr commented 2024-06-05 08:07:33 +02:00
Author
Copy Link

Here I recorded video where Fly Navigation is used and bug is apparent. Pressing Enter after adding letter to name moves camera back. I moved the mouse pointer but didn't press any mouse buttons, don't be distracted by that.

Here I recorded video where Fly Navigation is used and bug is apparent. Pressing Enter after adding letter to name moves camera back. I moved the mouse pointer but didn't press any mouse buttons, don't be distracted by that.
cam.mp4
240 KiB
Pratik Borhade commented 2024-06-05 08:39:48 +02:00
Member
Copy Link

Thanks, can confirm

Thanks, can confirm
Shyy-Anzr commented 2024-06-05 08:56:19 +02:00
Author
Copy Link

Should the labels be updated? The issue still says Status: Needs Information from User.

Should the labels be updated? The issue still says `Status: Needs Information from User`.
Pratik Borhade commented 2024-06-05 09:01:53 +02:00
Member
Copy Link

Yeah, bit confused what should be the correct module here. Camera view got reset after the "redo panel changes" so I guess it's related to undo/core module? (But it's not happening with the redo panel properties of other operators...)

Yeah, bit confused what should be the correct module here. Camera view got reset after the "redo panel changes" so I guess it's related to undo/core module? (But it's not happening with the redo panel properties of other operators...)
Bart van der Braak added
Type
Bug
 and removed
Type
Report
 labels 2024-08-14 12:59:42 +02:00
Bastien Montagne commented 2024-08-22 12:21:09 +02:00
Owner
Copy Link

I cannot reproduce this behavior in current 4.3/main?

I always get undo steps written when moving the locked camera currently (walk mode or rotation using numpad keys)

I cannot reproduce this behavior in current 4.3/main? I always get undo steps written when moving the locked camera currently (walk mode or rotation using numpad keys)
Bastien Montagne added
Module
User Interface
 and removed
Module
Core
 labels 2024-08-22 12:22:21 +02:00
Bastien Montagne commented 2024-08-22 12:23:04 +02:00
Owner
Copy Link

Also if the undo step is missing, this is an issue in 3DView editor, so rather a UI module problem - definitively not Core.

Also if the undo step is missing, this is an issue in 3DView editor, so rather a UI module problem - definitively not Core.
Pratik Borhade commented 2024-08-22 12:26:34 +02:00
Member
Copy Link

Can still confirm in current main :)
@mont29 , can you check the attached file?:

  • Open the file (make sure to be in pose mode)
  • rotate bone
  • invoke walk navigation to change camera view
  • call create pose asset in viewport
  • Expand redo panel and change the name
Can still confirm in current main :) @mont29 , can you check the attached file?: - Open the file (make sure to be in pose mode) - rotate bone - invoke walk navigation to change camera view - call `create pose asset` in viewport - Expand redo panel and change the name
Bastien Montagne commented 2024-08-22 12:33:54 +02:00
Owner
Copy Link

I'm confused... In this file the camera is not locked in the 3DView?

So it looks like the issue here is that walk/fly modes are not creating undo steps when the camera is not locked in 3DView?

I'm confused... In this file the camera is _not_ locked in the 3DView? So it looks like the issue here is that walk/fly modes are _not_ creating undo steps when the camera is _not_ locked in 3DView?
Pratik Borhade commented 2024-08-22 12:37:32 +02:00
Member
Copy Link

Camera was never locked. I also had this confusion when I first looked at the report 😅
AFAICS, whether it's in camera view or not, walk mode is never writing an undo step

I always get undo steps written when moving the locked camera currently

I remember I added the "undo step when navigating locked camera" 1-2 years ago. Maybe we could also write undo step for walk navigation? But I think this will work only in object mode (uses memfile undo)

Camera was never locked. I also had this confusion when I first looked at the report 😅 AFAICS, whether it's in camera view or not, walk mode is never writing an undo step - - - > I always get undo steps written when moving the locked camera currently I remember I added the "undo step when navigating locked camera" 1-2 years ago. Maybe we could also write undo step for walk navigation? But I think this will work only in object mode (uses memfile undo)
Bastien Montagne commented 2024-08-22 12:49:12 +02:00
Owner
Copy Link

Here the problem is that even in camera view, walk.fly do not add an undo step, which they should do, since they are effectively editing the camera object.

Here the problem is that even in camera view, walk.fly do not add an undo step, which they should do, since they are effectively editing the camera object.
Bastien Montagne commented 2024-08-22 12:51:48 +02:00
Owner
Copy Link

I always get undo steps written when moving the locked camera currently

I remember I added the "undo step when navigating locked camera" 1-2 years ago. Maybe we could also write undo step for walk navigation? But I think this will work only in object mode (uses memfile undo)

Yeah I saw that limitation in code re. memfile undo... I do not know why this is there tbh, afaik we can mix memfile undo steps with editmode ones, that's e.g. what happens when removing a modifier while in Edit mode. (Although it is somewhat broken currently, see all the 'undo' open bugs...)

> > I always get undo steps written when moving the locked camera currently > > I remember I added the "undo step when navigating locked camera" 1-2 years ago. Maybe we could also write undo step for walk navigation? But I think this will work only in object mode (uses memfile undo) Yeah I saw that limitation in code re. memfile undo... I do not know why this is there tbh, afaik we can mix memfile undo steps with editmode ones, that's e.g. what happens when removing a modifier while in Edit mode. (Although it is somewhat broken currently, see all the 'undo' open bugs...)
👍 1
Blender Bot added
Status
Resolved
 and removed
Status
Confirmed
 labels 2024-08-22 14:29:56 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Code Documentation
Code comments, Python/RNA API descriptions

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Viewport & EEVEE

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/

  
Module
Animation & Rigging

  
Module
Asset System
Asset datablocks, libraries, browser and shelf

  
Module
Asset System

  
Module
Core

  
Module
Development Management

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Module
Viewport & EEVEE

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Severity
High

  
Severity
Low

  
Severity
Normal

  
Severity
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

Archived

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#122757
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?