Colorspace inconsistency between color sampling operators #124401

Open
opened 2024-07-09 12:16:09 +02:00 by Simon Thommes · 4 comments
Member

System Information
Operating system: Linux-6.8.12-gentoo-x86_64-AMD_Ryzen_9_5950X_16-Core_Processor-with-glibc2.39 64 Bits, X11 UI
Graphics card: NVIDIA RTX A6000/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 550.90.07

Blender Version
Broken: version: 4.3.0 Alpha, branch: main, commit date: 2024-07-08 23:09, hash: bbcc720c1328
Worked: current 4.2 LTS

Short description of error
There is an inconsistency in the color space used for the back-transformation from display space between the sampling tool attached to the color picker and the modal operator on shift + x in Blender's draw modes. This is not the case in Blender 4.2.

Besides this issue, I'd also like to point out that neither of these two seem to actually do the proper back-transformation in all cases. In the steps I'm outlining to reproduce the issue neither of the two sampling operators retrieve the actual linear color values that are set. I would assume that both the AGX and the sRGB transformation are taken into account properly, so I'm not sure why that would not work.
This is another (separate) bug. or am I misunderstanding how the system is supposed to work?

Exact steps for others to reproduce the error

  • set world color to (0.5, 0.5, 0.5, 1)
  • set viewport to rendered mode
  • go to image texture paint mode
  • sample world with shift-x and inspect color (0.667, 0.667, 0.667, 1)
  • sample world with the sampling tool in the color picker (0.735, 0.735, 0.735, 1)
**System Information** Operating system: Linux-6.8.12-gentoo-x86_64-AMD_Ryzen_9_5950X_16-Core_Processor-with-glibc2.39 64 Bits, X11 UI Graphics card: NVIDIA RTX A6000/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 550.90.07 **Blender Version** Broken: version: 4.3.0 Alpha, branch: main, commit date: 2024-07-08 23:09, hash: `bbcc720c1328` Worked: current 4.2 LTS **Short description of error** There is an inconsistency in the color space used for the back-transformation from display space between the sampling tool attached to the color picker and the modal operator on `shift + x` in Blender's draw modes. This is not the case in Blender 4.2. Besides this issue, I'd also like to point out that neither of these two seem to actually do the proper back-transformation in all cases. In the steps I'm outlining to reproduce the issue neither of the two sampling operators retrieve the actual linear color values that are set. I would assume that both the AGX and the sRGB transformation are taken into account properly, so I'm not sure why that would not work. This is another (separate) bug. or am I misunderstanding how the system is supposed to work? **Exact steps for others to reproduce the error** - set world color to (0.5, 0.5, 0.5, 1) - set viewport to rendered mode - go to image texture paint mode - sample world with `shift-x` and inspect color (0.667, 0.667, 0.667, 1) - sample world with the sampling tool in the color picker (0.735, 0.735, 0.735, 1)
Simon Thommes added the
Type
Report
Severity
Normal
Status
Needs Triage
labels 2024-07-09 12:16:10 +02:00
Member

Hi, thanks for the report. Can confirm

Hi, thanks for the report. Can confirm
Member

From a quick look, significant difference in values started to occur between 25d4d645cdac - b59fbbe86546
With standard view transform on lite build, color values are close to equal.

From a quick look, significant difference in values started to occur between `25d4d645cdac - b59fbbe86546` With standard view transform on lite build, color values are close to equal.
Pratik Borhade added
Module
Render & Cycles
and removed
Module
Viewport & EEVEE
labels 2024-07-10 07:31:01 +02:00
Pratik Borhade added this to the 4.2 LTS milestone 2024-07-10 07:31:06 +02:00
Pratik Borhade modified the milestone from 4.2 LTS to 4.3 2024-07-10 07:31:10 +02:00

The eyedropper has been changed in #123408. This is to make it so the sampled color gives the same exact result after re-applying the color management. The value (0.735, 0.735, 0.735, 1) seems to be the correct one for sampling, as it gives the color matching (0.5, 0.5, 0.5, 1) after applying the color management.

Wouldn't really call it high priority bug, is more like the similar fix needs to be appleid to the Sample Color operator.

@LukasStockner is it something you feel comfortable to dig into?

The eyedropper has been changed in #123408. This is to make it so the sampled color gives the same exact result after re-applying the color management. The value `(0.735, 0.735, 0.735, 1)` seems to be the correct one for sampling, as it gives the color matching (0.5, 0.5, 0.5, 1) after applying the color management. Wouldn't really call it high priority bug, is more like the similar fix needs to be appleid to the Sample Color operator. @LukasStockner is it something you feel comfortable to dig into?
Lukas Stockner self-assigned this 2024-08-04 22:36:01 +02:00
Sergey Sharybin added
Severity
Normal
and removed
Severity
High
labels 2024-08-07 19:31:02 +02:00

Lowering priority.
It is a bit annoying issue, but it is jus another aspect of color picking that needs fixing. Is not a regression or anything like this.

Lowering priority. It is a bit annoying issue, but it is jus another aspect of color picking that needs fixing. Is not a regression or anything like this.
Bart van der Braak added
Type
Bug
and removed
Type
Report
labels 2024-08-14 12:57:27 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#124401
No description provided.