File Browser: Back button doesn't go back to first folder (in the new Video Editor > Video Editor workspace) #124771
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#124771
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Linux-6.8.0-36-generic-x86_64-with-glibc2.39 64 Bits, X11 UI
Blender Version
Broken: version: 2.8x, 2.9x all the way to 4.3.0 Alpha, branch: main, commit date: 2024-07-16 08:11, hash:
c3f79ee250ee
Worked: 2.79 ♡
Short description of error
Back button doesn't go back to first folder in the Video Sequencer workspace.
Exact steps for others to reproduce the error
I'm seeing more errors than reported, so expanding the steps to recreate to make sure it all gets tested:
The last error is because in
folderlist_pushdir
the "previous_folder" (folderlist->last) is deallocated ram ("dddddd"). Note that if you skip the first use of "back" in the list above (the problem 1) line then the last error does not occur.In a nutshell, when we File / Open to view the File Browser in a window we are going from
wm_handler_fileselect_do
toED_fileselect_set_params_from_userdef
,fileselect_ensure_updated_file_params
, tofileselect_initialize_params_common
In that last step the current starting folder is pushed to the sfile->folders_prev list. That way you can go somewhere else, hit "back" and come back to the first folder. That works great.
But open Blender with default layout. Change the 3D view to a File Browser. At that point we also get a call to
fileselect_ensure_updated_file_params
, then fileselect_initialize_params_common` which pushes the current folder to the previous list. Yeah. But do this: Double-click on a folder, hit back. It works. But then close Blender and get an exception in MEM_lockfree_freeN.However, follow the instructions in this complaint and we see that there is no call that pushes the current folder to the previous list. So when we change to the new folder, then hit "back" the only thing on the previous list is the folder you are in, so it does nothing. We need to call
fileselect_ensure_updated_file_params
somewhere.Yikes, I think there are two different errors here.
I think this report is "fixed" by just doing this:
Basically just ensure that everything is in a nice state, including pushing the current directory to the previous list, in file browser init.
However, you can then quickly run into the other error, which I believe is not related. Using current main, open Blender with default layout. Select File / Open. In this case the previous list is populate correctly. Click "Parent" and then "back" and you will be back where you started. repeat this, clicking "parent", then "back" and either get an exception in
BLI_strcasecmp
or in MEM_freeN. As mentioned this is with unchanged main and not in the Video Editor workspace.Yup, two different errors, will make two separate PRs
Reopening after reverting my changes. I have not found reliable place to ensure that the previous_dir contains the current directory (in cases where File Browser is part of a workspace) that does not have unintended consequence.