GPv3: SVG export corrupted #126606

New Issue

Antonio Vazquez · 2024-08-21T16:37:41+02:00

Antonio Vazquez commented

2024-08-21 16:37:41 +02:00

System Information
Operating system: Windows-10-10.0.22621-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 552.12

Blender Version
Broken: version: 4.3.0 Alpha, branch: main (modified), commit date: 2024-08-21 13:20, hash: 08d5eb8f9cba
Worked: 4.2

Short description of error
When you export a demo file, the result is totally wrong.

Exact steps for others to reproduce the error

Download Cowboy demo file
Open file
Select cowboy characted and try to export in SVG for Selected or Visible object.

**System Information** Operating system: Windows-10-10.0.22621-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 552.12 **Blender Version** Broken: version: 4.3.0 Alpha, branch: main (modified), commit date: 2024-08-21 13:20, hash: `08d5eb8f9cba` Worked: 4.2 **Short description of error** When you export a demo file, the result is totally wrong. **Exact steps for others to reproduce the error** 1) Download Cowboy demo file 2) Open file 3) Select cowboy characted and try to export in SVG for Selected or Visible object.

Result in GPv2.png

705 KiB

Result in GPv3.png

294 KiB

Antonio Vazquez added the

labels 2024-08-21 16:37:42 +02:00

Antonio Vazquez added this to the Grease Pencil project 2024-08-21 16:37:42 +02:00

Pratik Borhade added

and removed

labels 2024-08-22 08:10:00 +02:00

Pratik Borhade commented

2024-08-22 08:10:23 +02:00

@LukasTonne ^ :)

Lukas Tönne self-assigned this 2024-08-22 11:16:44 +02:00

Lukas Tönne referenced a pull request that will close this issue

2024-08-23 15:30:32 +02:00

Fix #126606: GPv3: Wrong projection and various other issues with exporters #126691

Lukas Tönne commented

2024-08-23 15:38:32 +02:00

The SVG export is looking good for this file with the fix above.

PDF export, however, looks bad because of the materials used here: A number of materials have both Stroke and Fill color, but with Fill alpha set to zero. That makes these strokes invisible in the viewport and in SVG they also render transparent. PDF does not support transparency, so all these strokes show up with weird extra triangles. This is not really a bug but a limitation of the GP renderer and the PDF format:

The SVG export is looking good for this file with the fix above. PDF export, however, looks bad because of the materials used here: A number of materials have both Stroke and Fill color, but with Fill alpha set to zero. That makes these strokes invisible in the viewport and in SVG they also render transparent. PDF does not support transparency, so all these strokes show up with weird extra triangles. This is not really a bug but a limitation of the GP renderer and the PDF format: <img width="920" alt="image" src="attachments/4e9a457d-47cb-4475-b1b9-b4653f081030">

image.png

267 KiB

Antonio Vazquez commented

2024-08-23 16:01:45 +02:00

There is something I am missing. If the GPv3 Render Engine is the same and the materials are the same as in GPv2 and in GPv2 the exporter is able to do it, why can't it be done in GPv3? The PDF exporter is very important for transferring animation to other software and for creating scene documentation.

Lukas Tönne commented

2024-08-23 16:06:44 +02:00

What is GP supposed to do with a material that it cannot render properly in pdf?

Antonio Vazquez commented

2024-08-23 16:09:47 +02:00

Why you can't? This is my question. The same file exported in GPv2 using Blender 4.2,1.

Why you can't? This is my question. The same file exported in GPv2 using Blender 4.2,1. ![image](/attachments/5c9c8ec9-a2db-414e-9a4d-b7a8913e9f4c)

image.png

1.1 MiB

Cowboy Exported in GPv2.pdf

6.8 MiB

Antonio Vazquez commented

2024-08-23 16:13:23 +02:00

Here you have how set transparency. You need create a HPDF_ExtGState

void GpencilExporterPDF::color_set(bGPDlayer *gpl, const bool do_fill)
{
  const float fill_opacity = fill_color_[3] * gpl->opacity;
  const float stroke_opacity = stroke_color_[3] * stroke_average_opacity_get() * gpl->opacity;
  const bool need_state = (do_fill && fill_opacity < 1.0f) || (stroke_opacity < 1.0f);

  HPDF_Page_GSave(page_);
  HPDF_ExtGState gstate = (need_state) ? HPDF_CreateExtGState(pdf_) : nullptr;

  float3 col;
  if (do_fill) {
    interp_v3_v3v3(col, fill_color_, gpl->tintcolor, gpl->tintcolor[3]);
    linearrgb_to_srgb_v3_v3(col, col);
    col = math::clamp(col, 0.0f, 1.0f);
    HPDF_Page_SetRGBFill(page_, col[0], col[1], col[2]);
    if (gstate) {
      HPDF_ExtGState_SetAlphaFill(gstate, clamp_f(fill_opacity, 0.0f, 1.0f));
    }
  }
  else {
    interp_v3_v3v3(col, stroke_color_, gpl->tintcolor, gpl->tintcolor[3]);
    linearrgb_to_srgb_v3_v3(col, col);
    col = math::clamp(col, 0.0f, 1.0f);

    HPDF_Page_SetRGBFill(page_, col[0], col[1], col[2]);
    HPDF_Page_SetRGBStroke(page_, col[0], col[1], col[2]);
    if (gstate) {
      HPDF_ExtGState_SetAlphaFill(gstate, clamp_f(stroke_opacity, 0.0f, 1.0f));
      HPDF_ExtGState_SetAlphaStroke(gstate, clamp_f(stroke_opacity, 0.0f, 1.0f));
    }
  }
  if (gstate) {
    HPDF_Page_SetExtGState(page_, gstate);
  }
}

Here you have how set transparency. You need create a HPDF_ExtGState ``` void GpencilExporterPDF::color_set(bGPDlayer *gpl, const bool do_fill) { const float fill_opacity = fill_color_[3] * gpl->opacity; const float stroke_opacity = stroke_color_[3] * stroke_average_opacity_get() * gpl->opacity; const bool need_state = (do_fill && fill_opacity < 1.0f) || (stroke_opacity < 1.0f); HPDF_Page_GSave(page_); HPDF_ExtGState gstate = (need_state) ? HPDF_CreateExtGState(pdf_) : nullptr; float3 col; if (do_fill) { interp_v3_v3v3(col, fill_color_, gpl->tintcolor, gpl->tintcolor[3]); linearrgb_to_srgb_v3_v3(col, col); col = math::clamp(col, 0.0f, 1.0f); HPDF_Page_SetRGBFill(page_, col[0], col[1], col[2]); if (gstate) { HPDF_ExtGState_SetAlphaFill(gstate, clamp_f(fill_opacity, 0.0f, 1.0f)); } } else { interp_v3_v3v3(col, stroke_color_, gpl->tintcolor, gpl->tintcolor[3]); linearrgb_to_srgb_v3_v3(col, col); col = math::clamp(col, 0.0f, 1.0f); HPDF_Page_SetRGBFill(page_, col[0], col[1], col[2]); HPDF_Page_SetRGBStroke(page_, col[0], col[1], col[2]); if (gstate) { HPDF_ExtGState_SetAlphaFill(gstate, clamp_f(stroke_opacity, 0.0f, 1.0f)); HPDF_ExtGState_SetAlphaStroke(gstate, clamp_f(stroke_opacity, 0.0f, 1.0f)); } } if (gstate) { HPDF_Page_SetExtGState(page_, gstate); } } ```

Lukas Tönne commented

2024-08-23 16:37:51 +02:00

@antoniov thanks for the hint, it was in fact setting the opacity, but ignoring the color alpha. PDF export should be ok now.

Lukas Tönne referenced this issue from a commit

2024-08-23 17:51:45 +02:00

Fix #126606: GPv3: Wrong projection and various other issues with exporters

Lukas Tönne closed this issue

2024-08-23 17:51:46 +02:00

Blender Bot added

and removed

labels 2024-08-23 17:51:47 +02:00

Antonio Vazquez commented

2024-08-23 19:11:16 +02:00

@LukasTonne Checked! The export is correct now. Thanks for fixing!

I have found a different bug with the selected frames and open a new report: #126702

@LukasTonne Checked! The export is correct now. Thanks for fixing! I have found a different bug with the selected frames and open a new report: https://projects.blender.org/blender/blender/issues/126702

👍 1

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

GPv3: SVG export corrupted #126606