blender/blender
162
515
Fork 780
Code Issues 6.8k Pull Requests 928 Projects 19 Wiki Activity

NPR Prototype (To Dos) #127354

New Issue
Open
opened 2024-09-09 17:30:36 +02:00 by Miguel Pozo · 7 comments
Miguel Pozo commented 2024-09-09 17:30:36 +02:00
Member
Copy Link

This is a list of the features we would like to support for the NPR prototype.
We want to support as many as we can, to get as close to the "full picture" as possible, but we may have to cut corners for features that would take too much development time.

  • Core (NPR Step and Node Tree) #127258
  • Texture Sockets #127591
  • Shader Node Zones #128862
  • Script Node
  • Custom Refraction (Mesh-Based Compositing) #127591
  • Multi-Layer Refraction #129590
  • AOVs #127927
  • Light Linking #127514
  • Shadow Linking #127514
  • Custom Light Loops: #129402
    • Shading WorldPosition ?
    • Self-Shadows detection ?
  • Built-in Filters:
    • Built-in with implicit inputs:
      • Curvature
      • Cavity
      • Rim
    • Built-in with explicit inputs:
      • Kuwahara

Dependency Graph

flowchart LR
    C(Core)
    IF(Implicit Input Filters)
    EF(Explicit Input Filters)
    SN(Script Node)
    TS(Texture Sockets)
    CR(Custom Refraction)
    MLR(Multi-Layer Refraction)
    LSL(Light/Shadow Linking)
    SNZ(Shader Node Zones)
    CLL(Custom Light Loops)
    SO(Shading Offset ?)
    SS(Self-Shadow detection ?)
    AOV(AOVs)

    classDef done stroke:#3A3;
    class C done;
    class TS done;
    class CR done;
    class LSL done;
    class AOV done;
    class SNZ done;
    class CLL done;
    class MLR done;


    C --> TS
    C --> IF
    C --> LSL
    TS -.-> SN
    TS -.-> CR -.-> MLR
    TS -.-> AOV
    TS --> EF
    SNZ --> CLL
    CLL -.-> SO
    CLL --> SS
    LSL -.-> CLL

Dotted line means soft dependency

This is a list of the features we would like to support for the NPR prototype. We want to support as many as we can, to get as close to the "full picture" as possible, but we may have to cut corners for features that would take too much development time. - [x] Core (NPR Step and Node Tree) #127258 - [x] Probes support #129698 - [x] Texture Sockets #127591 - [x] Shader Node Zones #128862 - [ ] Script Node - [x] Custom Refraction (Mesh-Based Compositing) #127591 - [x] Multi-Layer Refraction #129590 - [x] AOVs #127927 - [x] Light Linking #127514 - [x] Shadow Linking #127514 - [x] Custom Light Loops: #129402 - [ ] Shading WorldPosition ? - [ ] Self-Shadows detection ? - [ ] Built-in Filters: - [ ] Built-in with implicit inputs: - [ ] Curvature - [ ] Cavity - [ ] Rim - [ ] Built-in with explicit inputs: - [ ] Kuwahara --- ### Dependency Graph ```mermaid flowchart LR C(Core) IF(Implicit Input Filters) EF(Explicit Input Filters) SN(Script Node) TS(Texture Sockets) CR(Custom Refraction) MLR(Multi-Layer Refraction) LSL(Light/Shadow Linking) SNZ(Shader Node Zones) CLL(Custom Light Loops) SO(Shading Offset ?) SS(Self-Shadow detection ?) AOV(AOVs) classDef done stroke:#3A3; class C done; class TS done; class CR done; class LSL done; class AOV done; class SNZ done; class CLL done; class MLR done; C --> TS C --> IF C --> LSL TS -.-> SN TS -.-> CR -.-> MLR TS -.-> AOV TS --> EF SNZ --> CLL CLL -.-> SO CLL --> SS LSL -.-> CLL ``` *Dotted line means soft dependency*
npr-node-group-assets.blend
939 KiB
❤️ 8
Miguel Pozo added the
Interest
EEVEE
Type
To Do
Module
Viewport & EEVEE
 labels 2024-09-09 17:30:37 +02:00
Miguel Pozo added this to the Viewport & EEVEE project 2024-09-09 17:30:38 +02:00
Rob commented 2024-09-15 03:09:50 +02:00
Copy Link

Thanks @pragma37 this looks exciting!

Thanks @pragma37 this looks exciting!
❤️ 2
Rob commented 2024-10-11 15:49:49 +02:00
Copy Link

Hi @pragma37 I noticed in the dev notes that there were design discussions that needed to be resolved before progress could continue on the project - is this something that you want general feedback on, or is this more of a between developers discussion?

I've tried the prototype a few times and I have to say that I'm very impressed!

It took a few minutes to figure out exactly how I was supposed to use it, but once I got into the swing of things I had a green Principled BSDF with a blue gradient NPR node setup, and a red light shining on it, and I had a beautiful and dynamic mix of all three!

I am beginning to see the power of this system, though I have only done simple shading tests.

Two things stuck out when I was using the system:

  • it would be nice to initialize a new NPR node tree with an Input and Output node - the Combined Color output connected to the Color output - that way the user gets instant feedback that the system is working, and can tell that the BSDF and NPR nodes can work together
  • I found myself wanting to Tab back and forth between NPR and Object shader types - might be nice to have this as a shortcut to toggle or cycle shader types

Thank you and Chris for all your work, and everyone else who is contributing!

Hi @pragma37 I noticed in the dev notes that there were design discussions that needed to be resolved before progress could continue on the project - is this something that you want general feedback on, or is this more of a between developers discussion? I've tried the prototype a few times and I have to say that I'm very impressed! It took a few minutes to figure out exactly how I was supposed to use it, but once I got into the swing of things I had a green Principled BSDF with a blue gradient NPR node setup, and a red light shining on it, and I had a beautiful and dynamic mix of all three! I am beginning to see the power of this system, though I have only done simple shading tests. Two things stuck out when I was using the system: - it would be nice to initialize a new NPR node tree with an Input and Output node - the Combined Color output connected to the Color output - that way the user gets instant feedback that the system is working, and can tell that the BSDF and NPR nodes can work together - I found myself wanting to Tab back and forth between NPR and Object shader types - might be nice to have this as a shortcut to toggle or cycle shader types Thank you and Chris for all your work, and everyone else who is contributing!
Miguel Pozo commented 2024-10-11 16:34:28 +02:00
Author
Member
Copy Link

@SpectralVectors Thanks!

Those design discussions are technically oriented, mostly about figuring out how NPR features would affect the internal implementation of future EEVEE versions.

We will open a thread on Devtalk for user feedback soon.

I agree with your suggestions. We may not have time to focus too much on usability features for the prototype, but basic things like these should be supported.

@SpectralVectors Thanks! Those design discussions are technically oriented, mostly about figuring out how NPR features would affect the internal implementation of future EEVEE versions. We will open a thread on Devtalk for user feedback soon. I agree with your suggestions. We may not have time to focus too much on usability features for the prototype, but basic things like these should be supported.
👍 1 ❤️ 1
xZaki commented 2024-10-11 17:22:23 +02:00
Copy Link
  • I found myself wanting to Tab back and forth between NPR and Object shader types - might be nice to have this as a shortcut to toggle or cycle shader types

On that, in the 3D viewport the Tab key is used to change the Object Interaction modes with a pie menu (when a setting is enabled), can't that just be re-used for switching shader types in the shader editor since it's already a familiar interaction the Tab key doesn't seem to be used in it?
This could probably apply to all Editor Types that use this kind of drop down.

> - I found myself wanting to Tab back and forth between NPR and Object shader types - might be nice to have this as a shortcut to toggle or cycle shader types On that, in the 3D viewport the Tab key is used to change the Object Interaction modes with a pie menu (when a setting is enabled), can't that just be re-used for switching shader types in the shader editor since it's already a familiar interaction the Tab key doesn't seem to be used in it? This could probably apply to all Editor Types that use this kind of drop down.
thorn-neverwake commented 2024-10-11 17:42:23 +02:00
Copy Link

Have spent some time with the Sept build, and the one from earlier this week. So far I'm seeing some promising things here.

One thing I'm missing is outputs on the NPR node for self-shadows. This is nice feature in goo engine, so I'm hoping we'll see it here as well.

Terminators from sun lights still seem a bit hit or miss in the NPR build, and I'm also sometimes seeing that small "hazy shadow overlay" look that Eevee Next brought about. Will keep an eye on this to see if/how it improves as the NPR engine falls more into place.

Have spent some time with the Sept build, and the one from earlier this week. So far I'm seeing some promising things here. One thing I'm missing is outputs on the NPR node for self-shadows. This is nice feature in goo engine, so I'm hoping we'll see it here as well. Terminators from sun lights still seem a bit hit or miss in the NPR build, and I'm also sometimes seeing that small "hazy shadow overlay" look that Eevee Next brought about. Will keep an eye on this to see if/how it improves as the NPR engine falls more into place.
Miguel Pozo commented 2024-10-15 16:09:33 +02:00
Author
Member
Copy Link

@xZaki @thorn-neverwake I've opened a feedback thread on Devtalk.
Please, post your feedback/questions there. :)

@xZaki @thorn-neverwake I've opened a [feedback thread on Devtalk](https://devtalk.blender.org/t/eevee-npr-prototype-feedback). Please, post your feedback/questions there. :)
👍 2
Miguel Pozo commented 2024-10-22 15:41:50 +02:00
Author
Member
Copy Link

@marquis Please, post your questions on the devtalk thread.

@marquis Please, post your questions on the devtalk thread.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset System
Asset datablocks, libraries, browser and shelf

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Code Documentation
Code comments, Python/RNA API descriptions

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Viewport & EEVEE

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Module
Viewport & EEVEE

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Severity
High

  
Severity
Low

  
Severity
Normal

  
Severity
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

Archived

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Viewport & EEVEE
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#127354
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?