blender/blender

An Empty Panel is Shown in The Modifier while not in Group Node. #129087

New Issue

Closed

opened 2024-10-16 04:23:01 +02:00 by Gerstmann Bradley · 3 comments

Gerstmann Bradley commented

2024-10-16 04:23:01 +02:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 4070 SUPER/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 560.94

Blender Version
Broken: version: 4.3.0 Beta, branch: blender-v4.3-release, commit date: 2024-10-13 22:49, hash: 72be365c6ba6
Broken: 4.2

Short description of error

Not sure If it is a known limitation in Modifier Panel.

A side note is that I noticed that while sockets can be chosen to "hide in modifier", panels can't be chosen to do so.
I want to always mention the importance for a node group to be used as both group node and modifier, to reduce the amount of nodes over all. Otherwise there can be many nodes with the same function only because they are respectively designed for group node and modifier.

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 4070 SUPER/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 560.94 **Blender Version** Broken: version: 4.3.0 Beta, branch: blender-v4.3-release, commit date: 2024-10-13 22:49, hash: `72be365c6ba6` Broken: 4.2 **Short description of error** ![image](/attachments/7485568b-82cb-435d-8136-6fdbf66ddd65) ![image](/attachments/92a06b75-7b0d-4c32-9c60-620385f141bc) Not sure If it is a known limitation in Modifier Panel. A side note is that I noticed that while sockets can be chosen to "hide in modifier", panels can't be chosen to do so. I want to always mention the importance for a node group to be used as both group node and modifier, to reduce the amount of nodes over all. Otherwise there can be many nodes with the same function only because they are respectively designed for group node and modifier.

46 KiB

70 KiB

Panel Shown.blend

542 KiB

Gerstmann Bradley added the

labels 2024-10-16 04:23:01 +02:00

Pratik Borhade commented

2024-10-16 05:35:12 +02:00

Member

Hi, thanks for the report. If you ask me, panel tree-view element in modifier panel should be visible if it has any child element (similar to gpv3 groups in dopesheet).

Hi, thanks for the report. If you ask me, panel tree-view element in modifier panel should be visible if it has any child element (similar to gpv3 groups in dopesheet).

Pratik Borhade added

Nodes & Physics

Needs Info from Developers

and removed

labels 2024-10-16 05:35:56 +02:00

Pratik Borhade commented

2024-10-16 10:14:18 +02:00

Member

Like this:

diff --git a/source/blender/modifiers/intern/MOD_nodes.cc b/source/blender/modifiers/intern/MOD_nodes.cc
index 67a04bda3a1..80b63de007b 100644
--- a/source/blender/modifiers/intern/MOD_nodes.cc
+++ b/source/blender/modifiers/intern/MOD_nodes.cc
@@ -2256,6 +2256,9 @@ static void draw_interface_panel_content(const bContext *C,
   for (const bNodeTreeInterfaceItem *item : interface_panel.items()) {
     if (item->item_type == NODE_INTERFACE_PANEL) {
       const auto &sub_interface_panel = *reinterpret_cast<const bNodeTreeInterfacePanel *>(item);
+      if (sub_interface_panel.items_num == 0) {
+        continue;
+      }
       NodesModifierPanel *panel = find_panel_by_id(nmd, sub_interface_panel.identifier);
       PointerRNA panel_ptr = RNA_pointer_create(
           modifier_ptr->owner_id, &RNA_NodesModifierPanel, panel);

Like this: ```Diff diff --git a/source/blender/modifiers/intern/MOD_nodes.cc b/source/blender/modifiers/intern/MOD_nodes.cc index 67a04bda3a1..80b63de007b 100644 --- a/source/blender/modifiers/intern/MOD_nodes.cc +++ b/source/blender/modifiers/intern/MOD_nodes.cc @@ -2256,6 +2256,9 @@ static void draw_interface_panel_content(const bContext *C, for (const bNodeTreeInterfaceItem *item : interface_panel.items()) { if (item->item_type == NODE_INTERFACE_PANEL) { const auto &sub_interface_panel = *reinterpret_cast<const bNodeTreeInterfacePanel *>(item); + if (sub_interface_panel.items_num == 0) { + continue; + } NodesModifierPanel *panel = find_panel_by_id(nmd, sub_interface_panel.identifier); PointerRNA panel_ptr = RNA_pointer_create( modifier_ptr->owner_id, &RNA_NodesModifierPanel, panel); ```

Iliya Katushenock commented

2024-10-16 20:41:09 +02:00

Member

I remember there was some refactoring to properly support optional panel visibility, but not sure\

I remember there was some refactoring to properly support optional panel visibility, but not sure\

Jacques Lucke referenced this issue from a commit

2024-10-21 15:47:31 +02:00

Fix #129087: don't show empty panels in geometry nodes modifier

Jacques Lucke closed this issue

2024-10-21 15:48:24 +02:00

Blender Bot added

and removed

Needs Info from Developers

labels 2024-10-21 15:48:25 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Automated Testing

Blender Asset Bundle

Code Documentation

Dependency Graph

Development Management

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Viewport & EEVEE

Virtual Reality

Asset Browser Project

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Viewport & EEVEE

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#129087

No description provided.