blender/blender
162
515
Fork 780
Code Issues 6.8k Pull Requests 929 Projects 19 Wiki Activity

Speakers in nested VSE scenes don't respect edit offsets #129126

New Issue
Open
opened 2024-10-16 23:52:51 +02:00 by gabriel montagné · 7 comments
gabriel montagné commented 2024-10-16 23:52:51 +02:00
Copy Link

System Information
Operating system: Linux-6.1.0-25-amd64-x86_64-with-glibc2.36 64 Bits, X11 UI
Graphics card: Mesa Intel(R) Xe Graphics (TGL GT2) Intel 4.6 (Core Profile) Mesa 22.3.6

Blender Version
Broken: version: 4.2.0, branch: blender-v4.2-release, commit date: 2024-07-16 06:20, hash: a51f293548ad
Worked: NA - I tried as far back as 2.92 - same problem.

Short description of error
Scenes in VSE with Speaker objects will not respect the edits and will play at wrong frames

Exact steps for others to reproduce the error

  1. On a new blend file, create a scene "NESTED"
  2. Switch to NESTED scene, and add speaker that will play a sound.
  3. On the NLA set the sound to start on frame 15 -- if you play the current NESTED scene, sound will play correctly on frame 15.
  4. Create a new scene called EDIT
  5. On the VSE add the NESTED scene.
  6. Move the nested scene 10 frames to the right.
  7. Play the sequence or render the audio file.

Expected behaviour

Because the scene was 10 frames to the right, the sound should now play on frame 25.

Current incorrect behaviour.

The sound on the nested scene will incorrectly play on frame 15, as if it the scene had not been been moved.

Please see the attached file. On NESTED scene the sound plays on frame 15. on EDIT scene, with NESTED scene offset by ten frames, the sound still incorrectly plays on frame 15 -- the sound should be offset with the scene.

**System Information** Operating system: Linux-6.1.0-25-amd64-x86_64-with-glibc2.36 64 Bits, X11 UI Graphics card: Mesa Intel(R) Xe Graphics (TGL GT2) Intel 4.6 (Core Profile) Mesa 22.3.6 **Blender Version** Broken: version: 4.2.0, branch: blender-v4.2-release, commit date: 2024-07-16 06:20, hash: `a51f293548ad` Worked: NA - I tried as far back as 2.92 - same problem. **Short description of error** Scenes in VSE with Speaker objects will not respect the edits and will play at wrong frames **Exact steps for others to reproduce the error** 1. On a new blend file, create a scene "NESTED" 2. Switch to NESTED scene, and add speaker that will play a sound. 3. On the NLA set the sound to start on frame 15 -- if you play the current NESTED scene, sound will play correctly on frame 15. 4. Create a new scene called EDIT 5. On the VSE add the NESTED scene. 6. Move the nested scene 10 frames to the right. 7. Play the sequence or render the audio file. Expected behaviour Because the scene was 10 frames to the right, the sound should now play on frame 25. Current incorrect behaviour. The sound on the nested scene will incorrectly play on frame 15, as if it the scene had not been been moved. Please see the attached file. On NESTED scene the sound plays on frame 15. on EDIT scene, with NESTED scene offset by ten frames, the sound still incorrectly plays on frame 15 -- the sound should be offset with the scene.
edit.blend
1.9 MiB
gabriel montagné added the
Status
Needs Triage
Type
Bug
Severity
Normal
 labels 2024-10-16 23:52:52 +02:00
Pratik Borhade commented 2024-10-17 05:59:59 +02:00
Member
Copy Link

Hi, thanks for the report. Can confirm. We have few reports of audio failing to play at exact frame when it has been referenced in other scene via vse strip.
cc @iss

Hi, thanks for the report. Can confirm. We have few reports of audio failing to play at exact frame when it has been referenced in other scene via vse strip. cc @iss
Richard Antalik commented 2024-10-18 12:17:34 +02:00
Member
Copy Link

It seems that VSE setup is overridden by NLA in sound_update_base(). This seems to happen, because dependency graph evaluates objects in bit weird way - in BKE_sound_update_scene() it goes over all speakers, but adds their sound handles to active scene sound_scene.

This seems to be fine for non-VSE workflow, but VSE would really want speaker sound handle to be added to its owner scene and then add sound_scene of scene owner to active scene (with VSE).

I can try to make a fix, but won't guarantee outcome, as I have failed in past in this area heh.

It seems that VSE setup is overridden by NLA in `sound_update_base()`. This seems to happen, because dependency graph evaluates objects in bit weird way - in `BKE_sound_update_scene()` it goes over all speakers, but adds their sound handles to active scene `sound_scene`. This seems to be fine for non-VSE workflow, but VSE would really want speaker sound handle to be added to its owner scene and then add `sound_scene` of scene owner to active scene (with VSE). I can try to make a fix, but won't guarantee outcome, as I have failed in past in this area heh.
gabriel montagné commented 2024-10-18 22:05:39 +02:00
Author
Copy Link

I can try to make a fix, but won't guarantee outcome, as I have failed in past in this area heh.

Go for it 💪, Richard!

> I can try to make a fix, but won't guarantee outcome, as I have failed in past in this area heh. Go for it 💪, Richard!
Richard Antalik commented 2024-11-04 04:37:00 +01:00
Member
Copy Link

So I have looked into this very briefly, and realized, that this is the same issue as #70569 but from slightly different perspective - There is nothing that is handling time of nested scenes. Or in other words, sequencer needs it's own sound scene that is mixed with scene sound scene. Even if that existed though, the difficulty here is evaluating the nested scene. Current system just iterates whole tree ad "dumps all sounds" to single timeline with assumption, that there is no time shift.

So this needs rewrite of pretty much whole sound system which needs accepted design first.

So I have looked into this very briefly, and realized, that this is the same issue as #70569 but from slightly different perspective - There is nothing that is handling time of nested scenes. Or in other words, sequencer needs it's own sound scene that is mixed with scene sound scene. Even if that existed though, the difficulty here is evaluating the nested scene. Current system just iterates whole tree ad "dumps all sounds" to single timeline with assumption, that there is no time shift. So this needs rewrite of pretty much whole sound system which needs accepted design first.
Richard Antalik added
Type
Known Issue
 and removed
Type
Bug
 labels 2024-11-04 04:37:18 +01:00
gabriel montagné commented 2024-11-16 17:59:56 +01:00
Author
Copy Link

To work around this (and that, #69444) I created a simple operator that will pluck the sounds from a parent considering start frames and offsets to "finalize" the top-level edit. (https://gist.github.com/gabrielmontagne/0009135e29caea256972f848a1a19573) . Could something like that not be implemented here? You get the sounds, and do a bit of maths for start times, etc?

To work around this (and that, https://projects.blender.org/blender/blender/issues/69444) I created a simple operator that will pluck the sounds from a parent considering start frames and offsets to "finalize" the top-level edit. (https://gist.github.com/gabrielmontagne/0009135e29caea256972f848a1a19573) . Could something like that not be implemented here? You get the sounds, and do a bit of maths for start times, etc?
Richard Antalik commented 2024-11-18 21:02:13 +01:00
Member
Copy Link

To work around this (and that, #69444) I created a simple operator that will pluck the sounds from a parent considering start frames and offsets to "finalize" the top-level edit. (https://gist.github.com/gabrielmontagne/0009135e29caea256972f848a1a19573) . Could something like that not be implemented here? You get the sounds, and do a bit of maths for start times, etc?

Sure, but that still would be workaround and not a proper solution.

> To work around this (and that, https://projects.blender.org/blender/blender/issues/69444) I created a simple operator that will pluck the sounds from a parent considering start frames and offsets to "finalize" the top-level edit. (https://gist.github.com/gabrielmontagne/0009135e29caea256972f848a1a19573) . Could something like that not be implemented here? You get the sounds, and do a bit of maths for start times, etc? Sure, but that still would be workaround and not a proper solution.
gabriel montagné commented 2024-11-19 21:12:32 +01:00
Author
Copy Link

I see. It'd add a bit of tech debt, but it would make it usable. Now it's completely impossible to work with nested sound in scenes. There's now way to do it.

The original bug I reported, #69444 is already over 5 years old. I fear the "proper solution" might come 10 years after report :-( .

I see. It'd add a bit of tech debt, but it would make it usable. Now it's completely impossible to work with nested sound in scenes. There's now way to do it. The original bug I reported, https://projects.blender.org/blender/blender/issues/69444 is already over 5 years old. I fear the "proper solution" might come 10 years after report :-( .
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset System
Asset datablocks, libraries, browser and shelf

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Code Documentation
Code comments, Python/RNA API descriptions

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Viewport & EEVEE

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Module
Viewport & EEVEE

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Severity
High

  
Severity
Low

  
Severity
Normal

  
Severity
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

Archived

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#129126
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?