GPV3 Running repeat on duplicate and shift keyframe does not work #130793

Open
opened 2024-11-23 14:39:55 +01:00 by raylee · 16 comments

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3080 Ti/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 565.90

Blender Version
Broken: version: 4.3
Worked: 4.2

Short description of error
GPV3,Timeline and animation photography sheet cannot use the shortcut key shift+r

Exact steps for others to reproduce the error
1.creat GP
2.draw something
3.copy keyframes to frame 5 or other positions
4.use shift +R,in previous versions, keyframes were copied again and moved backwards by the same frame, but now they become invalid

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3080 Ti/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 565.90 **Blender Version** Broken: version: 4.3 Worked: 4.2 **Short description of error** GPV3,Timeline and animation photography sheet cannot use the shortcut key shift+r **Exact steps for others to reproduce the error** 1.creat GP 2.draw something 3.copy keyframes to frame 5 or other positions 4.use shift +R,in previous versions, keyframes were copied again and moved backwards by the same frame, but now they become invalid
raylee added the
Type
Bug
Severity
Normal
Status
Needs Triage
labels 2024-11-23 14:39:55 +01:00
Member

I can confirm this change of behaviour between Blender 4.2 and 4.3+. I will mark as high severity as it is a regression.


Broken: version: 4.1.1, branch: blender-v4.1-release, commit date: 2024-04-15 15:11, hash: e1743a0317bc

Considering you're talking about Grease Pencil v3, I would assume that 4.3 is the actually broken version and have updated the report.

For future reports, please fill out this information accurately.

I can confirm this change of behaviour between Blender 4.2 and 4.3+. I will mark as high severity as it is a regression. --- > Broken: version: 4.1.1, branch: blender-v4.1-release, commit date: 2024-04-15 15:11, hash: `e1743a0317bc` Considering you're talking about Grease Pencil v3, I would assume that 4.3 is the actually broken version and have updated the report. For future reports, please fill out this information accurately.
Alaska added this to the 4.3 milestone 2024-11-24 06:24:58 +01:00
Alaska changed title from GPV3,Timeline and animation photography sheet cannot use the shortcut key shift+r to GPV3 Running repeat on duplicate and shift keyframe does not work 2024-11-24 06:25:45 +01:00
Member

Looks like all Grease Pencil Dopesheet operators are failing. Will check

Looks like all Grease Pencil Dopesheet operators are failing. Will check
Member

Regarding paste operator, previous frame is deleted and replaced with new keyframe so drawing is not duplicated (same strokes and points on that frame). So "repeat" operation makes no change.

3.copy keyframes to frame 5 or other positions
4.use shift +R,in previous versions, keyframes were copied again and moved backwards by the same frame, but now they become invalid

I might be misunderstanding. Can someone explain these steps further? Are we running "paste" operation then "repeat: Shift R" operation?

Regarding paste operator, previous frame is deleted and replaced with new keyframe so drawing is not duplicated (same strokes and points on that frame). So "repeat" operation makes no change. > 3.copy keyframes to frame 5 or other positions > 4.use shift +R,in previous versions, keyframes were copied again and moved backwards by the same frame, but now they become invalid I might be misunderstanding. Can someone explain these steps further? Are we running "paste" operation then "repeat: Shift R" operation?
Member

I was selecting the keyframe in the time line, then duplicating it with Shift + D, shifting with my mouse, clicking to confirm the duplicate and move, then running the repeat command Shift + R

I was selecting the keyframe in the time line, then duplicating it with `Shift + D`, shifting with my mouse, clicking to confirm the duplicate and move, then running the repeat command `Shift + R`
Member

Might be because duplicate is two operators: duplicate + move.

Might be because duplicate is two operators: duplicate + move.
Member

Also looks like a undo thing. I tried Duplicate Move operation in time line, and use the undo panel to adjust values, the newly created frame will immediately disappear :/

Also looks like a undo thing. I tried `Duplicate Move` operation in time line, and use the undo panel to adjust values, the newly created frame will immediately disappear :/
Member

Maybe there is a way to group the undo step for the operator macro.

Maybe there is a way to group the undo step for the operator macro.
Member

I see, this is about "duplicating keys". Can take a look later.

Maybe there is a way to group the undo step for the operator macro.

OPTYPE_UNDO_GROUPED?

I see, this is about "duplicating keys". Can take a look later. > Maybe there is a way to group the undo step for the operator macro. `OPTYPE_UNDO_GROUPED`?
Member
CC @amelief (127eee87ce31)
Member

Seems a bit unconventional to tie these two (duplicate & move) so close together?
If you just call duplicate (ACTION_OT_duplicate), you get nothing (since it is just some temporary runtime thingie which then gets further processed by the transform system? -- but havent spent time digging deeper...) ?!

Seems a bit unconventional to tie these two (duplicate & move) so close together? If you just call duplicate (`ACTION_OT_duplicate`), you get nothing (since it is just some temporary runtime thingie which then gets further processed by the transform system? -- but havent spent time digging deeper...) ?!
Member

Yes, just duplicate doesn't make any sense for Grease Pencil. It's not possible to have a keyframe that's on the same frame as another keyframe.
And making this duplicate+move it's own separate operator also is an issue, because we'd have to reimplement a lot of the transform code then.

Yes, just duplicate doesn't make any sense for Grease Pencil. It's not possible to have a keyframe that's on the same frame as another keyframe. And making this duplicate+move it's own separate operator also is an issue, because we'd have to reimplement a lot of the transform code then.
Member

OK, thx for the info. Not really sure how to handle that then

OK, thx for the info. Not really sure how to handle that then
Member

Seems to me that we probably would need to make an exception case in the transform operator and the GP call to duplicate frames, otherwise we can't use the transform operator combo to do achieve such things...

Seems to me that we probably would need to make an exception case in the transform operator and the GP call to duplicate frames, otherwise we can't use the transform operator combo to do achieve such things...
Member

@ChengduLittleA Not exactly sure what you mean but the transform operator already has a setting use_duplicated_keyframes that tells it to move keys that just have been duplicated.

@ChengduLittleA Not exactly sure what you mean but the transform operator already has a setting `use_duplicated_keyframes` that tells it to move keys that just have been duplicated.
Member

But apparently now it will snap on shift-r... Probably will take a closer look on how it failed. Undo is quite a myth

But apparently now it will snap on shift-r... Probably will take a closer look on how it failed. Undo is quite a myth

Yes, that is the reason why they are so tied. I think with the old structure, it was creating some kind of ghost duplicate frame that lived in the structure but was not displayed, but with the new one that is just impossible to do.
I do not know how to fix this for the undo, sorry.

Yes, that is the reason why they are so tied. I think with the old structure, it was creating some kind of ghost duplicate frame that lived in the structure but was not displayed, but with the new one that is just impossible to do. I do not know how to fix this for the undo, sorry.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
7 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#130793
No description provided.